Skip to contentSkip to conversation

Small cleanup for hotplugmem

RFC PATCH In review [email protected] 2 participants 4 messages May 28, 2018 – Jun 1, 2018 Memory management

lore
Share & tools
lore
#0 lore raw

cover Small cleanup for hotplugmem

From: Oscar Salvador <[email protected]>

Hi guys,

I wanted to give it a chance a do a small cleanup in the hotplug memory code. A lot more could be done, but I wanted to start somewhere.
I tried to unify/remove duplicated code.

Here I have just done three things

1) add_memory_resource() had code to allocate a node in case it was offline. Since try_online_node already does that, I just made add_memory_resource() to use that function.
This is better explained in patch 1/3.

2) register_mem_sect_under_node() will be called only from link_mem_sections

3) Get rid of link_mem_sections() in favour of walk_memory_range with a callback to register_mem_sect_under_node()

I am posting this as a RFC because I could not see that these patches break anything, but expert eyes might see something that I am missing here.

Oscar Salvador (3):
mm/memory_hotplug: Make add_memory_resource use __try_online_node mm/memory_hotplug: Call register_mem_sect_under_node mm/memory_hotplug: Get rid of link_mem_sections

 drivers/base/memory.c |   2 -
 drivers/base/node.c   |  47 +++++------------------
 include/linux/node.h  |  21 +++++------
 mm/memory_hotplug.c   | 101 ++++++++++++++++++++++++++------------------------
 4 files changed, 71 insertions(+), 100 deletions(-)
Signature · 1 line
2.13.6
#1 lore raw
Quoted 28 lines · On Mon, May 28, 2018 at 10:13:52AM +0200, [email protected] wrote:

From: Oscar Salvador <[email protected]>

Hi guys,

I wanted to give it a chance a do a small cleanup in the hotplug memory code. A lot more could be done, but I wanted to start somewhere.
I tried to unify/remove duplicated code.

Here I have just done three things

1) add_memory_resource() had code to allocate a node in case it was offline. Since try_online_node already does that, I just made add_memory_resource() to use that function.
This is better explained in patch 1/3.

2) register_mem_sect_under_node() will be called only from link_mem_sections

3) Get rid of link_mem_sections() in favour of walk_memory_range with a callback to register_mem_sect_under_node()

I am posting this as a RFC because I could not see that these patches break anything, but expert eyes might see something that I am missing here.

Oscar Salvador (3):
mm/memory_hotplug: Make add_memory_resource use __try_online_node mm/memory_hotplug: Call register_mem_sect_under_node mm/memory_hotplug: Get rid of link_mem_sections

Quoted 11 lines
 drivers/base/memory.c |   2 -
 drivers/base/node.c   |  47 +++++------------------
 include/linux/node.h  |  21 +++++------
 mm/memory_hotplug.c   | 101 ++++++++++++++++++++++++++------------------------
 4 files changed, 71 insertions(+), 100 deletions(-)
Signature · 1 line
2.13.6

Since there have not been any concerns so far, I will send v1 of this patchset.

Thanks

Oscar Salvador

#2 lore raw

On Fri 01-06-18 13:25:30, Oscar Salvador wrote:
[...]

Quoted 1 line

Since there have not been any concerns so far, I will send v1 of this patchset.

I suspect nobody had time to look at those patches yet. It is getting close to the merge window and I expect people are busy. I will try to get to this after merge window.

Signature · 2 lines
Michal Hocko
SUSE Labs
#3 lore raw
Quoted 7 lines · Michal Hocko

On Fri 01-06-18 13:25:30, Oscar Salvador wrote:
[...]

Quoted 1 line

Since there have not been any concerns so far, I will send v1 of this patchset.

I suspect nobody had time to look at those patches yet. It is getting close to the merge window and I expect people are busy. I will try to get to this after merge window.

No problem at all, I know people are busy and merge window is coming so I did not really expect a lot of movement here.

But since next week I am going to be quite busy and I will be tight in time,
I just sent the patchset (<[email protected]>), so you might want to comment there in case you want.

Anyway, thanks for the time.

Oscar Salvador