Improvements for the dwc3_generic driver

Add 2 functions to wrap the calls to board_usb_init() and board_usb_cleanup().

Signed-off-by Jean-Jacques Hiblot <[email protected]>

---

 cmd/fastboot.c             |  4 ++--
 cmd/rockusb.c              |  4 ++--
 cmd/thordown.c             |  4 ++--
 cmd/usb_gadget_sdp.c       |  4 ++--
 cmd/usb_mass_storage.c     |  4 ++--
 common/dfu.c               |  6 +++---
 drivers/usb/gadget/ether.c | 38 +++++---------------------------------
 include/linux/usb/gadget.h | 10 ++++++++++
 8 files changed, 28 insertions(+), 46 deletions(-)

cmd/fastboot.c +2 -2

index a5ec5f4..93f97fd 100644
@@ -24,7 +24,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 	usb_controller = argv[1];
 	controller_index = simple_strtoul(usb_controller, NULL, 0);
 
-	ret = board_usb_init(controller_index, USB_INIT_DEVICE);
+	ret = usb_gadget_initialize(controller_index);
 	if (ret) {
 		pr_err("USB init failed: %d", ret);
 		return CMD_RET_FAILURE;

@@ -55,7 +55,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 exit:
 	g_dnl_unregister();
 	g_dnl_clear_detach();
-	board_usb_cleanup(controller_index, USB_INIT_DEVICE);
+	usb_gadget_release(controller_index);
 
 	return ret;
 }

cmd/rockusb.c +2 -2

index 8206643..e0c1480 100644
@@ -33,7 +33,7 @@ static int do_rockusb(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 	dev_index = simple_strtoul(devnum, NULL, 0);
 	rockusb_dev_init(devtype, dev_index);
 
-	ret = board_usb_init(controller_index, USB_INIT_DEVICE);
+	ret = usb_gadget_initialize(controller_index);
 	if (ret) {
 		printf("USB init failed: %d\n", ret);
 		return CMD_RET_FAILURE;

@@ -62,7 +62,7 @@ static int do_rockusb(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 exit:
 	g_dnl_unregister();
 	g_dnl_clear_detach();
-	board_usb_cleanup(controller_index, USB_INIT_DEVICE);
+	usb_gadget_release(controller_index);
 
 	return ret;
 }

cmd/thordown.c +2 -2

index e297de2..b7866d1 100644
@@ -30,7 +30,7 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		goto done;
 
 	int controller_index = simple_strtoul(usb_controller, NULL, 0);
-	ret = board_usb_init(controller_index, USB_INIT_DEVICE);
+	ret = usb_gadget_initialize(controller_index);
 	if (ret) {
 		pr_err("USB init failed: %d", ret);
 		ret = CMD_RET_FAILURE;

@@ -55,7 +55,7 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 exit:
 	g_dnl_unregister();
-	board_usb_cleanup(controller_index, USB_INIT_DEVICE);
+	usb_gadget_realease(controller_index);
 done:
 	dfu_free_entities();
 

cmd/usb_gadget_sdp.c +2 -2

index ba1f66a..808ed97 100644
@@ -20,7 +20,7 @@ static int do_sdp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 	char *usb_controller = argv[1];
 	int controller_index = simple_strtoul(usb_controller, NULL, 0);
-	board_usb_init(controller_index, USB_INIT_DEVICE);
+	usb_gadget_initialize(controller_index);
 
 	g_dnl_clear_detach();
 	g_dnl_register("usb_dnl_sdp");

@@ -37,7 +37,7 @@ static int do_sdp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 exit:
 	g_dnl_unregister();
-	board_usb_cleanup(controller_index, USB_INIT_DEVICE);
+	usb_gadget_release(controller_index);
 
 	return ret;
 }

cmd/usb_mass_storage.c +2 -2

index 89b9ddf..7c6d0c6 100644
@@ -160,7 +160,7 @@ static int do_usb_mass_storage(cmd_tbl_t *cmdtp, int flag,
 
 	controller_index = (unsigned int)(simple_strtoul(
 				usb_controller,	NULL, 0));
-	if (board_usb_init(controller_index, USB_INIT_DEVICE)) {
+	if (usb_gadget_initialize(controller_index)) {
 		pr_err("Couldn't init USB controller.");
 		rc = CMD_RET_FAILURE;
 		goto cleanup_ums_init;

@@ -231,7 +231,7 @@ static int do_usb_mass_storage(cmd_tbl_t *cmdtp, int flag,
 cleanup_register:
 	g_dnl_unregister();
 cleanup_board:
-	board_usb_cleanup(controller_index, USB_INIT_DEVICE);
+	usb_gadget_release(controller_index);
 cleanup_ums_init:
 	ums_fini();
 

common/dfu.c +3 -3

index 2620d32..44d1484 100644
@@ -23,9 +23,9 @@ int run_usb_dnl_gadget(int usbctrl_index, char *usb_dnl_gadget)
 	bool dfu_reset = false;
 	int ret, i = 0;
 
-	ret = board_usb_init(usbctrl_index, USB_INIT_DEVICE);
+	ret = usb_gadget_initialize(usbctrl_index);
 	if (ret) {
-		pr_err("board usb init failed\n");
+		pr_err("usb_gadget_initialize failed\n");
 		return CMD_RET_FAILURE;
 	}
 	g_dnl_clear_detach();

@@ -84,7 +84,7 @@ int run_usb_dnl_gadget(int usbctrl_index, char *usb_dnl_gadget)
 	}
 exit:
 	g_dnl_unregister();
-	board_usb_cleanup(usbctrl_index, USB_INIT_DEVICE);
+	usb_gadget_release(usbctrl_index);
 
 	if (dfu_reset)
 		do_reset(NULL, 0, 0, NULL);

drivers/usb/gadget/ether.c +5 -33

index 8ab9b9f..1c438c3 100644
@@ -105,9 +105,6 @@ struct eth_dev {
 	struct usb_gadget	*gadget;
 	struct usb_request	*req;		/* for control responses */
 	struct usb_request	*stat_req;	/* for cdc & rndis status */
-#ifdef CONFIG_DM_USB
-	struct udevice		*usb_udev;
-#endif
 
 	u8			config;
 	struct usb_ep		*in_ep, *out_ep, *status_ep;

@@ -2341,40 +2338,17 @@ fail:
 }
 
 /*-------------------------------------------------------------------------*/
-
-#ifdef CONFIG_DM_USB
-int dm_usb_init(struct eth_dev *e_dev)
-{
-	struct udevice *dev = NULL;
-	int ret;
-
-	ret = uclass_first_device(UCLASS_USB_DEV_GENERIC, &dev);
-	if (!dev || ret) {
-		pr_err("No USB device found\n");
-		return -ENODEV;
-	}
-
-	e_dev->usb_udev = dev;
-
-	return ret;
-}
-#endif
-
 static int _usb_eth_init(struct ether_priv *priv)
 {
 	struct eth_dev *dev = &priv->ethdev;
 	struct usb_gadget *gadget;
 	unsigned long ts;
+	int ret;
 	unsigned long timeout = USB_CONNECT_TIMEOUT;
 
-#ifdef CONFIG_DM_USB
-	if (dm_usb_init(dev)) {
-		pr_err("USB ether not found\n");
-		return -ENODEV;
-	}
-#else
-	board_usb_init(0, USB_INIT_DEVICE);
-#endif
+	ret = usb_gadget_initialize(0);
+	if (ret)
+		return ret;
 
 	/* Configure default mac-addresses for the USB ethernet device */
 #ifdef CONFIG_USBNET_DEV_ADDR

@@ -2546,9 +2520,7 @@ void _usb_eth_halt(struct ether_priv *priv)
 	}
 
 	usb_gadget_unregister_driver(&priv->eth_driver);
-#ifndef CONFIG_DM_USB
-	board_usb_cleanup(0, USB_INIT_DEVICE);
-#endif
+	usb_gadget_release(0);
 }
 
 #ifndef CONFIG_DM_ETH

include/linux/usb/gadget.h +10 -0

index b824f13..40ca2d3 100644
@@ -19,6 +19,7 @@
 #define __LINUX_USB_GADGET_H
 
 #include <errno.h>
+#include <usb.h>
 #include <linux/compat.h>
 #include <linux/list.h>
 

@@ -926,4 +927,13 @@ extern void usb_ep_autoconfig_reset(struct usb_gadget *);
 
 extern int usb_gadget_handle_interrupts(int index);
 
+static inline int usb_gadget_initialize(int index)
+{
+	return board_usb_init(index, USB_INIT_DEVICE);
+}
+
+static inline int usb_gadget_release(int index)
+{
+	return board_usb_cleanup(index, USB_INIT_DEVICE);
+}
 #endif	/* __LINUX_USB_GADGET_H */

Quoted 2 lines · Jean-Jacques Hiblot

Add 2 functions to wrap the calls to board_usb_init() and board_usb_cleanup().

Here should be written why you need this change.

M

Quoted 246 lines

Signed-off-by Jean-Jacques Hiblot <[email protected]>

---

  cmd/fastboot.c             |  4 ++--
  cmd/rockusb.c              |  4 ++--
  cmd/thordown.c             |  4 ++--
  cmd/usb_gadget_sdp.c       |  4 ++--
  cmd/usb_mass_storage.c     |  4 ++--
  common/dfu.c               |  6 +++---
  drivers/usb/gadget/ether.c | 38 +++++---------------------------------
  include/linux/usb/gadget.h | 10 ++++++++++
  8 files changed, 28 insertions(+), 46 deletions(-)

cmd/fastboot.c +2 -2

index a5ec5f4..93f97fd 100644
@@ -24,7 +24,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
  	usb_controller = argv[1];
  	controller_index = simple_strtoul(usb_controller, NULL, 0);
 
-	ret = board_usb_init(controller_index, USB_INIT_DEVICE);
+	ret = usb_gadget_initialize(controller_index);
  	if (ret) {
  		pr_err("USB init failed: %d", ret);
  		return CMD_RET_FAILURE;

@@ -55,7 +55,7 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
  exit:
  	g_dnl_unregister();
  	g_dnl_clear_detach();
-	board_usb_cleanup(controller_index, USB_INIT_DEVICE);
+	usb_gadget_release(controller_index);
 
  	return ret;
  }

cmd/rockusb.c +2 -2

index 8206643..e0c1480 100644
@@ -33,7 +33,7 @@ static int do_rockusb(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
  	dev_index = simple_strtoul(devnum, NULL, 0);
  	rockusb_dev_init(devtype, dev_index);
 
-	ret = board_usb_init(controller_index, USB_INIT_DEVICE);
+	ret = usb_gadget_initialize(controller_index);
  	if (ret) {
  		printf("USB init failed: %d\n", ret);
  		return CMD_RET_FAILURE;

@@ -62,7 +62,7 @@ static int do_rockusb(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
  exit:
  	g_dnl_unregister();
  	g_dnl_clear_detach();
-	board_usb_cleanup(controller_index, USB_INIT_DEVICE);
+	usb_gadget_release(controller_index);
 
  	return ret;
  }

cmd/thordown.c +2 -2

index e297de2..b7866d1 100644
@@ -30,7 +30,7 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
  		goto done;
 
  	int controller_index = simple_strtoul(usb_controller, NULL, 0);
-	ret = board_usb_init(controller_index, USB_INIT_DEVICE);
+	ret = usb_gadget_initialize(controller_index);
  	if (ret) {
  		pr_err("USB init failed: %d", ret);
  		ret = CMD_RET_FAILURE;

@@ -55,7 +55,7 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
  exit:
  	g_dnl_unregister();
-	board_usb_cleanup(controller_index, USB_INIT_DEVICE);
+	usb_gadget_realease(controller_index);
  done:
  	dfu_free_entities();
 

cmd/usb_gadget_sdp.c +2 -2

index ba1f66a..808ed97 100644
@@ -20,7 +20,7 @@ static int do_sdp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
  	char *usb_controller = argv[1];
  	int controller_index = simple_strtoul(usb_controller, NULL, 0);
-	board_usb_init(controller_index, USB_INIT_DEVICE);
+	usb_gadget_initialize(controller_index);
 
  	g_dnl_clear_detach();
  	g_dnl_register("usb_dnl_sdp");

@@ -37,7 +37,7 @@ static int do_sdp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
  exit:
  	g_dnl_unregister();
-	board_usb_cleanup(controller_index, USB_INIT_DEVICE);
+	usb_gadget_release(controller_index);
 
  	return ret;
  }

cmd/usb_mass_storage.c +2 -2

index 89b9ddf..7c6d0c6 100644
@@ -160,7 +160,7 @@ static int do_usb_mass_storage(cmd_tbl_t *cmdtp, int flag,
 
  	controller_index = (unsigned int)(simple_strtoul(
  				usb_controller,	NULL, 0));
-	if (board_usb_init(controller_index, USB_INIT_DEVICE)) {
+	if (usb_gadget_initialize(controller_index)) {
  		pr_err("Couldn't init USB controller.");
  		rc = CMD_RET_FAILURE;
  		goto cleanup_ums_init;

@@ -231,7 +231,7 @@ static int do_usb_mass_storage(cmd_tbl_t *cmdtp, int flag,
  cleanup_register:
  	g_dnl_unregister();
  cleanup_board:
-	board_usb_cleanup(controller_index, USB_INIT_DEVICE);
+	usb_gadget_release(controller_index);
  cleanup_ums_init:
  	ums_fini();
 

common/dfu.c +3 -3

index 2620d32..44d1484 100644
@@ -23,9 +23,9 @@ int run_usb_dnl_gadget(int usbctrl_index, char *usb_dnl_gadget)
  	bool dfu_reset = false;
  	int ret, i = 0;
 
-	ret = board_usb_init(usbctrl_index, USB_INIT_DEVICE);
+	ret = usb_gadget_initialize(usbctrl_index);
  	if (ret) {
-		pr_err("board usb init failed\n");
+		pr_err("usb_gadget_initialize failed\n");
  		return CMD_RET_FAILURE;
  	}
  	g_dnl_clear_detach();

@@ -84,7 +84,7 @@ int run_usb_dnl_gadget(int usbctrl_index, char *usb_dnl_gadget)
  	}
  exit:
  	g_dnl_unregister();
-	board_usb_cleanup(usbctrl_index, USB_INIT_DEVICE);
+	usb_gadget_release(usbctrl_index);
 
  	if (dfu_reset)
  		do_reset(NULL, 0, 0, NULL);

drivers/usb/gadget/ether.c +5 -33

index 8ab9b9f..1c438c3 100644
@@ -105,9 +105,6 @@ struct eth_dev {
  	struct usb_gadget	*gadget;
  	struct usb_request	*req;		/* for control responses */
  	struct usb_request	*stat_req;	/* for cdc & rndis status */
-#ifdef CONFIG_DM_USB
-	struct udevice		*usb_udev;
-#endif
 
  	u8			config;
  	struct usb_ep		*in_ep, *out_ep, *status_ep;

@@ -2341,40 +2338,17 @@ fail:
  }
 
  /*-------------------------------------------------------------------------*/
-
-#ifdef CONFIG_DM_USB
-int dm_usb_init(struct eth_dev *e_dev)
-{
-	struct udevice *dev = NULL;
-	int ret;
-
-	ret = uclass_first_device(UCLASS_USB_DEV_GENERIC, &dev);
-	if (!dev || ret) {
-		pr_err("No USB device found\n");
-		return -ENODEV;
-	}
-
-	e_dev->usb_udev = dev;
-
-	return ret;
-}
-#endif
-
  static int _usb_eth_init(struct ether_priv *priv)
  {
  	struct eth_dev *dev = &priv->ethdev;
  	struct usb_gadget *gadget;
  	unsigned long ts;
+	int ret;
  	unsigned long timeout = USB_CONNECT_TIMEOUT;
 
-#ifdef CONFIG_DM_USB
-	if (dm_usb_init(dev)) {
-		pr_err("USB ether not found\n");
-		return -ENODEV;
-	}
-#else
-	board_usb_init(0, USB_INIT_DEVICE);
-#endif
+	ret = usb_gadget_initialize(0);
+	if (ret)
+		return ret;
 
  	/* Configure default mac-addresses for the USB ethernet device */
  #ifdef CONFIG_USBNET_DEV_ADDR

@@ -2546,9 +2520,7 @@ void _usb_eth_halt(struct ether_priv *priv)
  	}
 
  	usb_gadget_unregister_driver(&priv->eth_driver);
-#ifndef CONFIG_DM_USB
-	board_usb_cleanup(0, USB_INIT_DEVICE);
-#endif
+	usb_gadget_release(0);
  }
 
  #ifndef CONFIG_DM_ETH

include/linux/usb/gadget.h +10 -0

index b824f13..40ca2d3 100644
@@ -19,6 +19,7 @@
  #define __LINUX_USB_GADGET_H
 
  #include <errno.h>
+#include <usb.h>
  #include <linux/compat.h>
  #include <linux/list.h>
 

@@ -926,4 +927,13 @@ extern void usb_ep_autoconfig_reset(struct usb_gadget *);
 
  extern int usb_gadget_handle_interrupts(int index);
 
+static inline int usb_gadget_initialize(int index)
+{
+	return board_usb_init(index, USB_INIT_DEVICE);
+}
+
+static inline int usb_gadget_release(int index)
+{
+	return board_usb_cleanup(index, USB_INIT_DEVICE);
+}
  #endif	/* __LINUX_USB_GADGET_H */

Using CONFIG_DM_USB for this purpose prevents using DM_USB for host and not for device.

Signed-off-by Jean-Jacques Hiblot <[email protected]>

---

 drivers/usb/Kconfig             | 6 ++++++
 drivers/usb/dwc3/core.c         | 2 +-
 drivers/usb/dwc3/dwc3-generic.c | 4 +++-
 3 files changed, 10 insertions(+), 2 deletions(-)

drivers/usb/Kconfig +6 -0

index 4fbe172..3587ba4 100644
@@ -47,6 +47,12 @@ config DM_USB
 	  declared with the U_BOOT_USB_DEVICE() macro and will be
 	  automatically probed when found on the bus.
 
+config DM_USB_DEV
+	bool "Enable driver model for USB (Peripheral mode)"
+	depends on DM_USB
+	help
+	  Enable driver model for USB (Peripheral mode).
+
 source "drivers/usb/host/Kconfig"
 
 source "drivers/usb/dwc3/Kconfig"

drivers/usb/dwc3/core.c +1 -1

index 1ab5cee..d5ee6d9 100644
@@ -789,7 +789,7 @@ MODULE_AUTHOR("Felipe Balbi <[email protected]>");
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("DesignWare USB3 DRD Controller Driver");
 
-#ifdef CONFIG_DM_USB
+#ifdef CONFIG_DM_USB_DEV
 
 int dwc3_init(struct dwc3 *dwc)
 {

drivers/usb/dwc3/dwc3-generic.c +0 -0

index ca63eac..2c1e696 100644

drivers/usb/dwc3/dwc3-generic.c +3 -0

+#ifdef CONFIG_DM_USB_DEV
 
 int usb_gadget_handle_interrupts(int index)
 {

@@ -98,6 +98,8 @@ U_BOOT_DRIVER(dwc3_generic_peripheral) = {
 	.flags	= DM_FLAG_ALLOC_PRIV_DMA,
 };
 
+#endif
+
 static int dwc3_generic_bind(struct udevice *parent)
 {
 	const void *fdt = gd->fdt_blob;

Quoted 49 lines · Jean-Jacques Hiblot

Using CONFIG_DM_USB for this purpose prevents using DM_USB for host and not for device.

Signed-off-by Jean-Jacques Hiblot <[email protected]>

---

  drivers/usb/Kconfig             | 6 ++++++
  drivers/usb/dwc3/core.c         | 2 +-
  drivers/usb/dwc3/dwc3-generic.c | 4 +++-
  3 files changed, 10 insertions(+), 2 deletions(-)

drivers/usb/Kconfig +6 -0

index 4fbe172..3587ba4 100644
@@ -47,6 +47,12 @@ config DM_USB
  	  declared with the U_BOOT_USB_DEVICE() macro and will be
  	  automatically probed when found on the bus.
 
+config DM_USB_DEV
+	bool "Enable driver model for USB (Peripheral mode)"
+	depends on DM_USB
+	help
+	  Enable driver model for USB (Peripheral mode).
+
  source "drivers/usb/host/Kconfig"
 
  source "drivers/usb/dwc3/Kconfig"

drivers/usb/dwc3/core.c +1 -1

index 1ab5cee..d5ee6d9 100644
@@ -789,7 +789,7 @@ MODULE_AUTHOR("Felipe Balbi <[email protected]>");
  MODULE_LICENSE("GPL v2");
  MODULE_DESCRIPTION("DesignWare USB3 DRD Controller Driver");
 
-#ifdef CONFIG_DM_USB
+#ifdef CONFIG_DM_USB_DEV
 
  int dwc3_init(struct dwc3 *dwc)
  {

drivers/usb/dwc3/dwc3-generic.c +0 -0

index ca63eac..2c1e696 100644
@@ -21,7 +21,7 @@
  #include "gadget.h"
  #include "linux-compat.h"
 

drivers/usb/dwc3/dwc3-generic.c line 24

Quoted 1 line

drivers/usb/dwc3/dwc3-generic.c +0 -1

-DECLARE_GLOBAL_DATA_PTR;

Removing this looks weird. I would expect that there will be new error/warning when you compile it because gd is used in bind function.

M

Quoted 14 lines

drivers/usb/dwc3/dwc3-generic.c +3 -0

+#ifdef CONFIG_DM_USB_DEV
 
  int usb_gadget_handle_interrupts(int index)
  {

@@ -98,6 +98,8 @@ U_BOOT_DRIVER(dwc3_generic_peripheral) = {
  	.flags	= DM_FLAG_ALLOC_PRIV_DMA,
  };
 
+#endif
+
  static int dwc3_generic_bind(struct udevice *parent)
  {
  	const void *fdt = gd->fdt_blob;

When DM_USB_DEV the platform code for the USB device must be replaced by calls to a USB device driver.

usb_gadget_initialize() probes the USB device driver. usb_gadget_release() removes the USB device driver.

Signed-off-by Jean-Jacques Hiblot <[email protected]>

This series aims at bringing improvements to the dwc3_generic driver so that it can be used by most of the platforms using the dwc3 controller.

I tested this on with DRA7 and AM57x platforms for both Peripheral and Host operations. The code to enable DM USB host & dev support for those platforms will be submitted in a separate series.

Enhancements:
- use separate Kconfig option for DM USB Periphal and DM USB Host. This allow platforms to keep their non-DM USB peripheral code and use the DM USB host.
- fixes the bind/probe confusion in dwc3_generic. The probe is done when the USB device is first needed.
- handles PHYs when in the peripheral mode. The code to handle the PHYs is shared with the host side
- handles clock and reset
- bind host controller to the more generic driver 'xhci-dwc3'

Jean-Jacques Hiblot (7):
usb: gadget: Do not call board_usb_xxx() directly in USB gadget
drivers
usb: introduce a separate config option for DM USB device
usb: udc: implement DM versions of
usb_gadget_initialize()/_release()/_handle_interrupt()
dwc3_generic: do not probe the USB device driver when it's bound
dwc3: move phy operation to core.c
dwc3-generic: Handle the PHYs, the clocks and the reset lines
dwc3-generic: Add select_dr_mode operation

 cmd/fastboot.c                    |   4 +-
 cmd/rockusb.c                     |   4 +-
 cmd/thordown.c                    |   4 +-
 cmd/usb_gadget_sdp.c              |   4 +-
 cmd/usb_mass_storage.c            |   4 +-
 common/dfu.c                      |   6 +-
 drivers/usb/Kconfig               |   6 ++
 drivers/usb/dwc3/Kconfig          |   7 +-
 drivers/usb/dwc3/core.c           |  86 +++++++++++++++-
 drivers/usb/dwc3/dwc3-generic.c   | 206 +++++++++++++++++++++++++++++---------
 drivers/usb/dwc3/ep0.c            |   1 -
 drivers/usb/gadget/ether.c        |  38 +------
 drivers/usb/gadget/udc/udc-core.c |  44 +++++++-
 drivers/usb/host/xhci-dwc3.c      |  93 ++---------------
 include/dwc3-uboot.h              |   7 ++
 include/linux/usb/gadget.h        |  18 ++++
 16 files changed, 348 insertions(+), 184 deletions(-)

Hi Jean,

Quoted 7 lines · Jean-Jacques Hiblot

This series aims at bringing improvements to the dwc3_generic driver so that it can be used by most of the platforms using the dwc3 controller.

I tested this on with DRA7 and AM57x platforms for both Peripheral and Host operations. The code to enable DM USB host & dev support for those platforms will be submitted in a separate series.

Quoted 10 lines

Enhancements:
- use separate Kconfig option for DM USB Periphal and DM USB Host. This allow platforms to keep their non-DM USB peripheral code and use the DM USB host.
- fixes the bind/probe confusion in dwc3_generic. The probe is done when the USB device is first needed.
- handles PHYs when in the peripheral mode. The code to handle the PHYs is shared with the host side
- handles clock and reset
- bind host controller to the more generic driver 'xhci-dwc3'

I see two series which were sent recently without any description of dependencies.

Will be good to push these patches somewhere to git and send a link that I can easily test.

Thanks,
Michal

Quoted 31 lines

Jean-Jacques Hiblot (7):
usb: gadget: Do not call board_usb_xxx() directly in USB gadget
drivers
usb: introduce a separate config option for DM USB device
usb: udc: implement DM versions of
usb_gadget_initialize()/_release()/_handle_interrupt()
dwc3_generic: do not probe the USB device driver when it's bound
dwc3: move phy operation to core.c
dwc3-generic: Handle the PHYs, the clocks and the reset lines
dwc3-generic: Add select_dr_mode operation

  cmd/fastboot.c                    |   4 +-
  cmd/rockusb.c                     |   4 +-
  cmd/thordown.c                    |   4 +-
  cmd/usb_gadget_sdp.c              |   4 +-
  cmd/usb_mass_storage.c            |   4 +-
  common/dfu.c                      |   6 +-
  drivers/usb/Kconfig               |   6 ++
  drivers/usb/dwc3/Kconfig          |   7 +-
  drivers/usb/dwc3/core.c           |  86 +++++++++++++++-
  drivers/usb/dwc3/dwc3-generic.c   | 206 +++++++++++++++++++++++++++++---------
  drivers/usb/dwc3/ep0.c            |   1 -
  drivers/usb/gadget/ether.c        |  38 +------
  drivers/usb/gadget/udc/udc-core.c |  44 +++++++-
  drivers/usb/host/xhci-dwc3.c      |  93 ++---------------
  include/dwc3-uboot.h              |   7 ++
  include/linux/usb/gadget.h        |  18 ++++
  16 files changed, 348 insertions(+), 184 deletions(-)

Hi Michal

Quoted 22 lines · Michal Simek

Hi Jean,

Quoted 19 lines · Jean-Jacques Hiblot

This series aims at bringing improvements to the dwc3_generic driver so that it can be used by most of the platforms using the dwc3 controller.

I tested this on with DRA7 and AM57x platforms for both Peripheral and Host
operations. The code to enable DM USB host & dev support for those platforms will be submitted in a separate series.

Enhancements:
- use separate Kconfig option for DM USB Periphal and DM USB Host. This allow platforms to keep their non-DM USB peripheral code and use the DM USB host.
- fixes the bind/probe confusion in dwc3_generic. The probe is done when the USB device is first needed.
- handles PHYs when in the peripheral mode. The code to handle the PHYs is
shared with the host side
- handles clock and reset
- bind host controller to the more generic driver 'xhci-dwc3'

Quoted 2 lines

I see two series which were sent recently without any description of dependencies.

Right I forgot. This series applies on to of the master branch of the USB tree

Quoted 2 lines

Will be good to push these patches somewhere to git and send a link that I can easily test.

I pushed all on github : https://github.com/jjhiblot/u-boot

Hi,

Quoted 28 lines · Jean-Jacques Hiblot

Hi Michal

Quoted 24 lines · Michal Simek

Hi Jean,

Quoted 8 lines · Jean-Jacques Hiblot

This series aims at bringing improvements to the dwc3_generic driver so that it can be used by most of the platforms using the dwc3 controller.

I tested this on with DRA7 and AM57x platforms for both Peripheral and Host
operations. The code to enable DM USB host & dev support for those platforms will be submitted in a separate series.

Quoted 11 lines

Enhancements:
- use separate Kconfig option for DM USB Periphal and DM USB Host. This allow platforms to keep their non-DM USB peripheral code and use the DM USB host.
- fixes the bind/probe confusion in dwc3_generic. The probe is done when the USB device is first needed.
- handles PHYs when in the peripheral mode. The code to handle the PHYs is
shared with the host side
- handles clock and reset
- bind host controller to the more generic driver 'xhci-dwc3'

I see two series which were sent recently without any description of dependencies.

Quoted 5 lines

Right I forgot. This series applies on to of the master branch of the USB tree

Quoted 2 lines

Will be good to push these patches somewhere to git and send a link that I can easily test.

I pushed all on github : https://github.com/jjhiblot/u-boot

I didn't build all patches to identify which one is introducing the issue. But look below at issues and please fix them. Then I will test.

Thanks,
Michal

[u-boot](dwc3)$ nice -n 19 ./tools/buildman/buildman -b dwc3 zynqmp -o ../tmp/ -C -I -c 1 -sSed
boards.cfg is up to date. Nothing to do.
Summary of 1 commit for 20 boards (8 threads, 1 job per thread) 01: board: ti: am57xx: remove USB platform code

    aarch64:  +   xilinx_zynqmp_zc1751_xm016_dc2

xilinx_zynqmp_zcu102_revA xilinx_zynqmp_zcu100_revC xilinx_zynqmp_zcu104_revA xilinx_zynqmp_zc1751_xm017_dc3 xilinx_zynqmp_zcu102_revB xilinx_zynqmp_zcu106_revA xilinx_zynqmp_zc1751_xm015_dc1 xilinx_zynqmp_zcu111_revA xilinx_zynqmp_zcu102_rev1_0 xilinx_zynqmp_zcu104_revC

(quoted diff) +2 -0

+common/built-in.o: In function `run_usb_dnl_gadget':
+build/../common/dfu.c:73: undefined reference to

`usb_gadget_handle_interrupts'
+build/../common/dfu.c:83: undefined reference to
`usb_gadget_handle_interrupts'

(quoted diff) +6 -0

+make[1]: *** [u-boot] Error 139
+make: *** [sub-make] Error 2
+  usb_gadget_realease(controller_index);
+  ^~~~~~~~~~~~~~~~~~~
+cmd/built-in.o: In function `do_fastboot':
+build/../cmd/fastboot.c:50: undefined reference to

`usb_gadget_handle_interrupts'

(quoted diff) +4 -0

+cmd/built-in.o: In function `do_thor_down':
+build/../cmd/thordown.c:58: undefined reference to `usb_gadget_realease'
+drivers/usb/gadget/built-in.o: In function `thor_rx_data':
+build/../drivers/usb/gadget/f_thor.c:555: undefined reference to

`usb_gadget_handle_interrupts'

(quoted diff) +2 -0

+drivers/usb/gadget/built-in.o: In function `thor_tx_data':
+build/../drivers/usb/gadget/f_thor.c:589: undefined reference to

`usb_gadget_handle_interrupts'

(quoted diff) +2 -0

+drivers/usb/gadget/built-in.o: In function `thor_init':
+build/../drivers/usb/gadget/f_thor.c:706: undefined reference to

`usb_gadget_handle_interrupts'
w+../cmd/thordown.c: In function ?do_thor_down?:
w+../cmd/thordown.c:58:2: warning: implicit declaration of function ?usb_gadget_realease? [-Wimplicit-function-declaration]

Quoted 38 lines · Michal Simek

Hi,

Quoted 35 lines · Jean-Jacques Hiblot

Hi Michal

Quoted 27 lines · Michal Simek

Hi Jean,

Quoted 10 lines · Jean-Jacques Hiblot

This series aims at bringing improvements to the dwc3_generic driver so
that it can be used by most of the platforms using the dwc3 controller.

I tested this on with DRA7 and AM57x platforms for both Peripheral and Host
operations. The code to enable DM USB host & dev support for those platforms will be submitted in a separate series.

Quoted 14 lines

Enhancements:
- use separate Kconfig option for DM USB Periphal and DM USB Host. This
allow platforms to keep their non-DM USB peripheral code and use the DM
USB host.
- fixes the bind/probe confusion in dwc3_generic. The probe is done when
the USB device is first needed.
- handles PHYs when in the peripheral mode. The code to handle the PHYs is
shared with the host side
- handles clock and reset
- bind host controller to the more generic driver 'xhci-dwc3'

Quoted 2 lines

I see two series which were sent recently without any description of dependencies.

Right I forgot. This series applies on to of the master branch of the USB tree

Quoted 6 lines

Quoted 4 lines

Quoted 3 lines

Will be good to push these patches somewhere to git and send a link that
I can easily test.

I pushed all on github : https://github.com/jjhiblot/u-boot

I didn't build all patches to identify which one is introducing the issue. But look below at issues and please fix them. Then I will test.

The CONFIG_DM_USB_DEV is missing from configuration. This will be fixed in v2