Skip to contentSkip to conversation

board: sun50i: Add Amarula A64-Relic initial support

PATCH Superseded Jagan Teki 3 participants 6 messages May 28, 2018 – Jun 1, 2018

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH v3 1/1 board: sun50i: Add Amarula A64-Relic initial support

Amarula A64-Relic is A64 based IoT device, which support
- Allwinner A64 Cortex-A53
- Mali-400MP2 GPU
- AXP803 PMIC
- 1GB DDR3 RAM
- 8GB eMMC
- AP6330 Wifi/BLE
- MIPI-DSI
- CSI: OV5640 sensor
- USB OTG
- 12V DC power supply

---
Changes for v3:
- Use sun50i-a64-relic.dts name
Changes for v2:
- Rename dts name to sun50i-a64-relic.dts which is simple to use
- Rename defconfig to a64_relic_defconfig
- Use licence year as 2018

 arch/arm/dts/Makefile                     |  1 +
 arch/arm/dts/sun50i-a64-amarula-relic.dts | 65 +++++++++++++++++++++++++++++++
 board/sunxi/MAINTAINERS                   |  6 +++
 configs/amarula_a64_relic_defconfig       | 18 +++++++++
 4 files changed, 90 insertions(+)
 create mode 100644 arch/arm/dts/sun50i-a64-amarula-relic.dts
 create mode 100644 configs/amarula_a64_relic_defconfig
arch/arm/dts/Makefile +1 -0
index a0349a8975..3efa3b99b9 100644
@@ -381,6 +381,7 @@ dtb-$(CONFIG_MACH_SUN50I_H5) += \
 	sun50i-h5-orangepi-prime.dtb \
 	sun50i-h5-orangepi-zero-plus2.dtb
 dtb-$(CONFIG_MACH_SUN50I) += \
+	sun50i-a64-amarula-relic.dtb \
 	sun50i-a64-bananapi-m64.dtb \
 	sun50i-a64-nanopi-a64.dtb \
 	sun50i-a64-olinuxino.dtb \
arch/arm/dts/sun50i-a64-amarula-relic.dts new file +65 -0

65 lines not on this page · raw message

board/sunxi/MAINTAINERS +6 -0
index 1bb2fa8f51..e90c87b560 100644
@@ -116,6 +116,12 @@ M:	Paul Kocialkowski <[email protected]>
 S:	Maintained
 F:	configs/Ainol_AW1_defconfig
 
+AMARULA A64-RELIC
+M:	Jagan Teki <[email protected]>
+S:	Maintained
+F:	configs/amarula_a64_relic_defconfig
+F:	arch/arm/dts/sun50i-a64-amarula-relic.dts
+
 AMPE A76 BOARD
 M:	Paul Kocialkowski <[email protected]>
 S:	Maintained
configs/amarula_a64_relic_defconfig new file +18 -0
new file mode 100644
index 0000000000..6eab0d2ae5
@@ -0,0 +1,18 @@
+CONFIG_ARM=y
+CONFIG_ARCH_SUNXI=y
+CONFIG_SPL=y
+CONFIG_MACH_SUN50I=y
+CONFIG_DRAM_ODT_EN=y
+CONFIG_RESERVE_ALLWINNER_BOOT0_HEADER=y
+CONFIG_MMC_SUNXI_SLOT_EXTRA=2
+CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-amarula-relic"
+# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+# CONFIG_VIDEO_DE2 is not set
+# CONFIG_CMD_FLASH is not set
+# CONFIG_CMD_FPGA is not set
+# CONFIG_SPL_DOS_PARTITION is not set
+CONFIG_CMD_USB_MASS_STORAGE=y
+# CONFIG_SPL_ISO_PARTITION is not set
+# CONFIG_SPL_EFI_PARTITION is not set
+CONFIG_USB_MUSB_GADGET=y
+CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
Signature · 1 line
2.14.3
#1 lore raw

PATCH v3 1/1 board: sun50i: Add Amarula A64-Relic initial support

Quoted 1 line · Jagan Teki

+CONFIG_CMD_USB_MASS_STORAGE=y

You still haven't explained why this is useful to add it by default on this particular board.

Maxime

Signature · 3 lines
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH v3 1/1 board: sun50i: Add Amarula A64-Relic initial support

Quoted 5 lines · Maxime Ripard
Quoted 1 line · Jagan Teki

+CONFIG_CMD_USB_MASS_STORAGE=y

You still haven't explained why this is useful to add it by default on this particular board.

This board does have only eMMC and no external storage possibilities(like eMMC or Ethernet) so to copy images between eMMC vs host intermediate way (other than fastboot) ums can be the possible way.

#3 lore raw

PATCH v3 1/1 board: sun50i: Add Amarula A64-Relic initial support

Quoted 5 lines · Jagan Teki
Quoted 3 lines · Maxime Ripard
Quoted 1 line · Jagan Teki

+CONFIG_CMD_USB_MASS_STORAGE=y

Quoted 7 lines
Quoted 2 lines

You still haven't explained why this is useful to add it by default on this particular board.

This board does have only eMMC and no external storage possibilities(like eMMC or Ethernet) so to copy images between eMMC vs host intermediate way (other than fastboot) ums can be the possible way.

We have fastboot and DFU to address that already, and a number of other boards accomodate that just fine (the CHIP, the NES Classic, etc.).

Maxime

Signature · 10 lines
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180531/5a8449bc/attachment.sig>
#4 lore raw

PATCH v3 1/1 board: sun50i: Add Amarula A64-Relic initial support

Quoted 9 lines · Maxime Ripard
Quoted 8 lines · Jagan Teki
Quoted 5 lines · Maxime Ripard
Quoted 1 line · Jagan Teki

+CONFIG_CMD_USB_MASS_STORAGE=y

You still haven't explained why this is useful to add it by default on this particular board.

Quoted 8 lines
Quoted 4 lines

This board does have only eMMC and no external storage possibilities(like eMMC or Ethernet) so to copy images between eMMC vs host intermediate way (other than fastboot) ums can be the possible way.

We have fastboot and DFU to address that already, and a number of other boards accomodate that just fine (the CHIP, the NES Classic, etc.).

Yes, but ums is different where we can simply mount the flash on host and update the partitions data directly instead of create partitions with new data to write again. what's wrong with using ums. I always believe fastboot, DFU is different than ums where former need to create image file and later simply copy.

Jagan.

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#5 lore raw

PATCH v3 1/1 board: sun50i: Add Amarula A64-Relic initial support

Quoted 20 lines · Jagan Teki
Quoted 9 lines · Maxime Ripard
Quoted 8 lines · Jagan Teki
Quoted 5 lines · Maxime Ripard
Quoted 1 line · Jagan Teki

+CONFIG_CMD_USB_MASS_STORAGE=y

You still haven't explained why this is useful to add it by default on this particular board.

Quoted 8 lines
Quoted 4 lines

This board does have only eMMC and no external storage possibilities(like eMMC or Ethernet) so to copy images between eMMC vs host intermediate way (other than fastboot) ums can be the possible way.

We have fastboot and DFU to address that already, and a number of other boards accomodate that just fine (the CHIP, the NES Classic, etc.).

Quoted 5 lines

Yes, but ums is different where we can simply mount the flash on host and update the partitions data directly instead of create partitions with new data to write again. what's wrong with using ums. I always believe fastboot, DFU is different than ums where former need to create image file and later simply copy.

I'm not arguing the usefulness of the UMS gadget itself, I don't have any objections to that, and I totally get why and how it can be useful. What I'm arguing for is why you should enable it *by default*.

You can very easily do that with menuconfig already, and we won't enable each and every command and feature someone finds interesting. We've already been bitten hard by this, and I have no intention of doing that kind of thing a second time.

So yeah, you can definitely use UMS if you wish so. But enabling it by default when we have already two alternatives for the same use case enabled is pointless.

Maxime

Signature · 10 lines
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180601/32af04a4/attachment.sig>