Skip to contentSkip to conversation

libselinux: Fix spelling errors in manpages

PATCH In review Laurent Bigonville 2 participants 4 messages May 28, 2018 – May 30, 2018 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 libselinux: Fix spelling errors in manpages

From: Laurent Bigonville <[email protected]>

---
 libselinux/man/man3/selinux_boolean_sub.3      | 2 +-
 libselinux/man/man3/selinux_restorecon_xattr.3 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
libselinux/man/man3/selinux_boolean_sub.3 +1 -1
index 308c2684..d24c12a3 100644
@@ -12,7 +12,7 @@ selinux_boolean_sub \-
 searches the
 .I \%/etc/selinux/{POLICYTYPE}/booleans.subs_dist
 file
-for a maching boolean_name record.  If the record exists the boolean substitution name is returned.  If not
+for a matching boolean_name record.  If the record exists the boolean substitution name is returned.  If not
 .BR \%selinux_boolean_sub ()
 returns the original
 .IR \%boolean_name .
libselinux/man/man3/selinux_restorecon_xattr.3 +1 -1
index 7280c958..516d2669 100644
@@ -119,7 +119,7 @@ By default
 .BR selinux_restorecon_xattr (3)
 will use the default set of specfiles described in
 .BR files_contexts (5)
-to calculate the initial SHA1 digest to be used for comparision.
+to calculate the initial SHA1 digest to be used for comparison.
 To change this default behavior
 .BR selabel_open (3)
 must be called specifying the required
Signature · 1 line
2.17.0
#1 lore raw

PATCH 2/3 libselinux: Fix line wrapping in selabel_file.5

From: Laurent Bigonville <[email protected]>

Fix line wrapping with limited to 80 columns

Fix lintian error:
W: selinux-utils: manpage-has-errors-from-man usr/share/man/man5/selabel_file.5.gz 104: warning [p 2, 10.0i]: cannot adjust line

---
 libselinux/man/man5/selabel_file.5 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
libselinux/man/man5/selabel_file.5 +1 -1
index e7388242..e97bd826 100644
@@ -92,7 +92,7 @@ The optional local and distribution substitution files that perform any path ali
 .RE
 .sp
 The default file context series of files are:
-.RS
+.RS 6
 .I /etc/selinux/{SELINUXTYPE}/contexts/files/file_contexts
 .br
 .I  /etc/selinux/{SELINUXTYPE}/contexts/files/file_contexts.local
Signature · 1 line
2.17.0
#2 lore raw

Re: [PATCH 2/3] libselinux: Fix line wrapping in selabel_file.5

Quoted 26 lines · Laurent Bigonville

From: Laurent Bigonville <[email protected]>

Fix line wrapping with limited to 80 columns

Fix lintian error:
W: selinux-utils: manpage-has-errors-from-man usr/share/man/man5/selabel_file.5.gz 104: warning [p 2, 10.0i]: cannot adjust line

---
 libselinux/man/man5/selabel_file.5 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
libselinux/man/man5/selabel_file.5 +1 -2
index e7388242..e97bd826 100644
@@ -92,7 +92,7 @@ The optional local and distribution substitution files that perform any path ali
 .RE
 .sp
 The default file context series of files are:
-.RS
+.RS 6
 .I /etc/selinux/{SELINUXTYPE}/contexts/files/file_contexts
 .br
 .I  /etc/selinux/{SELINUXTYPE}/contexts/files/file_contexts.local
--
Quoted 1 line

2.17.0

All the manpage patches look good to me (and I give them an ack).

For information, I didn't know what the default indent value of ".RS"
[1] is and it seems to be 8. I tested running "man ./selabel_file.5" in a 80-char-wide terminal and the line "/etc/selinux/{SELINUXTYPE}/contexts/files/file_contexts.subs_dist" is no longer cut after this patch.

Thanks,
Nicolas

[1] For those who are unfamiliar with manpage code, this instruction increases the indent by moving the left margin to the right.

#3 lore raw

PATCH 3/3 libselinux: fix the whatis line for the selinux_boolean_sub.3 manpage

In reply to Laurent Bigonville

From: Laurent Bigonville <[email protected]>

---
 libselinux/man/man3/selinux_boolean_sub.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
libselinux/man/man3/selinux_boolean_sub.3 +1 -1
index d24c12a3..a29a38d5 100644
@@ -1,6 +1,6 @@
 .TH "selinux_boolean_sub" "3" "11 June 2012" "[email protected]" "SELinux API documentation"
 .SH "NAME"
-selinux_boolean_sub \-
+selinux_boolean_sub \- Search the translated name for a boolean_name record
 .
 .SH "SYNOPSIS"
 .B #include <selinux/selinux.h>
Signature · 1 line
2.17.0