Skip to contentSkip to conversation

mtd: ubi: Add missing newlines in ubi_init()

PATCH New Stefan Roese 2 participants 2 messages May 29, 2018 – Jun 8, 2018

Subsystems (2)
Memory technology devices (MTD) Unsorted block images (UBI)
lore
Share & tools
lore

Stefan Roese

author
#0 lore raw

PATCH 1/1 mtd: ubi: Add missing newlines in ubi_init()

I just stumbled over some cluttered UBI messages. It seems some newline chars are missing in the current U-Boot UBI source. Lets fix this in U-Boot as well (Linux has those fixes already).

Signed-off-by Stefan Roese <[email protected]>
Cc Heiko Schocher <[email protected]>
---
 drivers/mtd/ubi/build.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/mtd/ubi/build.c +6 -6
index 0198d8bfa8..42c5270c7f 100644
@@ -1250,7 +1250,7 @@ int ubi_init(void)
 	BUILD_BUG_ON(sizeof(struct ubi_vid_hdr) != 64);
 
 	if (mtd_devs > UBI_MAX_DEVICES) {
-		pr_err("UBI error: too many MTD devices, maximum is %d",
+		pr_err("UBI error: too many MTD devices, maximum is %d\n",
 		       UBI_MAX_DEVICES);
 		return -EINVAL;
 	}

@@ -1262,7 +1262,7 @@ int ubi_init(void)
 
 	err = misc_register(&ubi_ctrl_cdev);
 	if (err) {
-		pr_err("UBI error: cannot register device");
+		pr_err("UBI error: cannot register device\n");
 		goto out;
 	}
 

@@ -1289,7 +1289,7 @@ int ubi_init(void)
 		mtd = open_mtd_device(p->name);
 		if (IS_ERR(mtd)) {
 			err = PTR_ERR(mtd);
-			pr_err("UBI error: cannot open mtd %s, error %d",
+			pr_err("UBI error: cannot open mtd %s, error %d\n",
 			       p->name, err);
 			/* See comment below re-ubi_is_module(). */
 			if (ubi_is_module())

@@ -1302,7 +1302,7 @@ int ubi_init(void)
 					 p->vid_hdr_offs, p->max_beb_per1024);
 		mutex_unlock(&ubi_devices_mutex);
 		if (err < 0) {
-			pr_err("UBI error: cannot attach mtd%d",
+			pr_err("UBI error: cannot attach mtd%d\n",
 			       mtd->index);
 			put_mtd_device(mtd);
 

@@ -1326,7 +1326,7 @@ int ubi_init(void)
 
 	err = ubiblock_init();
 	if (err) {
-		pr_err("UBI error: block: cannot initialize, error %d", err);
+		pr_err("UBI error: block: cannot initialize, error %d\n", err);
 
 		/* See comment above re-ubi_is_module(). */
 		if (ubi_is_module())

@@ -1353,7 +1353,7 @@ out:
 	mtd_devs = 0;
 #endif
 	class_unregister(&ubi_class);
-	pr_err("UBI error: cannot initialize UBI, error %d", err);
+	pr_err("UBI error: cannot initialize UBI, error %d\n", err);
 	return err;
 }
 late_initcall(ubi_init);
Signature · 1 line
2.17.0
#1 lore raw

PATCH 1/1 mtd: ubi: Add missing newlines in ubi_init()

Hello Stefan,

Am 29.05.2018 um 15:28 schrieb Stefan Roese:

Quoted 9 lines

I just stumbled over some cluttered UBI messages. It seems some newline chars are missing in the current U-Boot UBI source. Lets fix this in U-Boot as well (Linux has those fixes already).

Signed-off-by Stefan Roese <[email protected]>
Cc Heiko Schocher <[email protected]>
---
  drivers/mtd/ubi/build.c | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)

Applied to u-boot-ubi.git master

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de