USB: fhci-hcd: no need to check return value of debugfs_create functions
Greg Kroah-Hartman
maintainerPATCH 11/22 USB: fhci-hcd: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
There is also no need to keep the file dentries around at all, so remove those variables from the host controller structure.
Cc Felipe Balbi <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Johan Hovold <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/usb/host/fhci-dbg.c | 23 +++++------------------ drivers/usb/host/fhci.h | 2 -- 2 files changed, 5 insertions(+), 20 deletions(-)
drivers/usb/host/fhci-dbg.c +5 -18
@@ -83,27 +83,14 @@ void fhci_dfs_create(struct fhci_hcd *fhci)struct device *dev =fhci_to_hcd (fhci)->self.controller; fhci->dfs_root =debugfs_create_dir (dev_name (dev), usb_debug_root); -if (!fhci->dfs_root) { -WARN_ON (1 ); -return ; - } - - fhci->dfs_regs =debugfs_create_file ("regs" ,S_IFREG |S_IRUGO , - fhci->dfs_root, fhci, &fhci_dfs_regs_fops); - fhci->dfs_irq_stat =debugfs_create_file ("irq_stat" , -S_IFREG |S_IRUGO , fhci->dfs_root, fhci, - &fhci_dfs_irq_stat_fops); - -WARN_ON (!fhci->dfs_regs || !fhci->dfs_irq_stat); +debugfs_create_file ("regs" ,S_IFREG |S_IRUGO , fhci->dfs_root, fhci, + &fhci_dfs_regs_fops); +debugfs_create_file ("irq_stat" ,S_IFREG |S_IRUGO , fhci->dfs_root, fhci, + &fhci_dfs_irq_stat_fops); }void fhci_dfs_destroy (struct fhci_hcd *fhci) { -if (!fhci->dfs_root) -return ; - -debugfs_remove (fhci->dfs_irq_stat); -debugfs_remove (fhci->dfs_regs); -debugfs_remove (fhci->dfs_root); +debugfs_remove_recursive (fhci->dfs_root); }
drivers/usb/host/fhci.h +0 -2
@@ -262,8 +262,6 @@ struct fhci_hcd {#ifdef CONFIG_FHCI_DEBUG int usb_irq_stat[13 ];struct dentry *dfs_root; -struct dentry *dfs_regs; -struct dentry *dfs_irq_stat;#endif };