USB: gadget: udc: gr_udc: no need to check return value of debugfs_create functions
Greg Kroah-Hartman
maintainerPATCH 19/22 USB: gadget: udc: gr_udc: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
There is also no need to keep the file dentries around at all, so remove those variables from the device structure.
Cc Felipe Balbi <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc "Paul E. McKenney" <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Jaejoong Kim <[email protected]>
Cc Li Yang <[email protected]>
Cc Johan Hovold <[email protected]>
Cc Robert Jarzmik <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/usb/gadget/udc/gr_udc.c | 7 ++----- drivers/usb/gadget/udc/gr_udc.h | 1 - 2 files changed, 2 insertions(+), 6 deletions(-)
drivers/usb/gadget/udc/gr_udc.c +2 -5
@@ -209,15 +209,12 @@ static void gr_dfs_create(struct gr_udc *dev)const char *name ="gr_udc_state" ; dev->dfs_root =debugfs_create_dir (dev_name (dev->dev),NULL ); - dev->dfs_state =debugfs_create_file (name,0444 , dev->dfs_root, dev, - &gr_dfs_fops); + debugfs_create_file(name, 0444, dev->dfs_root, dev, &gr_dfs_fops); }static void gr_dfs_delete (struct gr_udc *dev) { -/* Handles NULL and ERR pointers internally */ -debugfs_remove (dev->dfs_state); -debugfs_remove (dev->dfs_root); +debugfs_remove_recursive (dev->dfs_root); }#else /* !CONFIG_USB_GADGET_DEBUG_FS */
drivers/usb/gadget/udc/gr_udc.h +0 -1
@@ -217,7 +217,6 @@ struct gr_udc {spinlock_t lock;/* General lock, a.k.a. "dev->lock" in comments */ struct dentry *dfs_root; -struct dentry *dfs_state; };#define to_gr_udc (gadget) (container_of((gadget), struct gr_udc, gadget))