rtc: sun6i: Fix bit_idx value for clk_register_gate
Subsystems (2)
PATCH v2 1/1 rtc: sun6i: Fix bit_idx value for clk_register_gate
From: Michael Trimarchi <[email protected]>
clk-gate core will take bit_idx through clk_register_gate and then do clk_gate_ops by using BIT(bit_idx), but rtc-sun6i is passing bit_idx as BIT(bit_idx) it becomes BIT(BIT(bit_idx) which is wrong and eventually external gate clock is not enabling.
This patch fixed by passing bit index and the original change introduced from below commit.
"rtc: sun6i: Add support for the external oscillator gate"
(sha1: 17ecd246414b3a0fe0cb248c86977a8bda465b7b)
---
Changes for v2:
- add suffix _OFFSET with macro name to distinguish b/w register actual values vs offset.
drivers/rtc/rtc-sun6i.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/rtc/rtc-sun6i.c +2 -2
@@ -74,7 +74,7 @@#define SUN6I_ALARM_CONFIG_WAKEUP BIT(0)#define SUN6I_LOSC_OUT_GATING 0x0060 -#define SUN6I_LOSC_OUT_GATING_EN BIT(0) +#define SUN6I_LOSC_OUT_GATING_EN_OFFSET 0/* * Get date values
@@ -255,7 +255,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node) &clkout_name); rtc->ext_losc =clk_register_gate (NULL , clkout_name, rtc->hw.init->name,0 , rtc->base +SUN6I_LOSC_OUT_GATING , -SUN6I_LOSC_OUT_GATING_EN ,0 , +SUN6I_LOSC_OUT_GATING_EN_OFFSET ,0 , &rtc->lock);if (IS_ERR (rtc->ext_losc)) {pr_crit ("Couldn't register the LOSC external gate\n" );
Signature · 1 line
2.14.3
Quoted 7 lines · Jagan Teki
From: Michael Trimarchi <[email protected]>
clk-gate core will take
bit_idxthroughclk_register_gateand then doclk_gate_opsby usingBIT(bit_idx), but rtc-sun6i is passingbit_idxasBIT(bit_idx)it becomes BIT(BIT(bit_idx) which is wrong and eventually external gate clock is not enabling.
Quoted 7 lines
This patch fixed by passing bit index and the original change introduced from below commit.
"rtc: sun6i: Add support for the external oscillator gate"
(sha1:17ecd246414b3a0fe0cb248c86977a8bda465b7b)Signed-off-by Michael Trimarchi <[email protected]>Signed-off-by Jagan Teki <[email protected]>
I said it in the v1 already, but this should be sent to stable and have a fixes tag.
Maxime
Signature · 3 lines
Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com