Skip to contentSkip to conversation

powerpc/mm/hash: Add missing update in slb update sequence.

PATCH Applied Aneesh Kumar K.V 2 participants 2 messages May 30, 2018 – Jun 4, 2018 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/mm/hash: Add missing update in slb update sequence.

Quoted 1 line

From ISA

"For data accesses, the context synchronizing instruction before the slbie, slbieg, slbia, slbmte, tlbie, or tlbiel instruction ensures that all preceding instructions that access data storage have completed to a point at which they have reported all exceptions they will cause."

Add the missing isync when updating Kernel stack slb entry.

---
 arch/powerpc/kernel/entry_64.S | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/kernel/entry_64.S +1 -0
index 51695608c68b..3d1af55e09dc 100644
@@ -596,6 +596,7 @@ END_MMU_FTR_SECTION_IFSET(MMU_FTR_1T_SEGMENT)
 	 * actually hit this code path.
 	 */
 
+	isync
 	slbie	r6
 	slbie	r6		/* Workaround POWER5 < DD2.1 issue */
 	slbmte	r7,r0
Signature · 1 line
2.17.0
#1 lore raw
Quoted 10 lines · Aneesh Kumar K.V
Quoted 1 line

From ISA

"For data accesses, the context synchronizing instruction before the slbie, slbieg, slbia, slbmte, tlbie, or tlbiel instruction ensures that all preceding instructions that access data storage have completed to a point at which they have reported all exceptions they will cause."

Add the missing isync when updating Kernel stack slb entry.

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/91d06971881f71d945910de1286580

cheers