Skip to contentSkip to conversation

lib/plist.c: Export plist_*() APIs

PATCH In review Hareesh Gundu 2 participants 6 messages Dec 5, 2017 – May 30, 2018 Library code

lore
Share & tools
lore

Hareesh Gundu

author
#0 lore raw

PATCH 1/1 lib/plist.c: Export plist_*() APIs

Allow plist_add(), plist_del() and plist_requeue() APIs to be referenced by kernel modules by adding the EXPORT_SYMBOL().

Signed-off-by Hareesh Gundu <[email protected]>
---
 lib/plist.c | 3 +++
 1 file changed, 3 insertions(+)
lib/plist.c +3 -0
index 199408f..6109b75 100644
@@ -103,6 +103,7 @@ void plist_add(struct plist_node *node, struct plist_head *head)
 
 	plist_check_head(head);
 }
+EXPORT_SYMBOL(plist_add);
 
 /**
  * plist_del - Remove a @node from plist.

@@ -132,6 +133,7 @@ void plist_del(struct plist_node *node, struct plist_head *head)
 
 	plist_check_head(head);
 }
+EXPORT_SYMBOL(plist_del);
 
 /**
  * plist_requeue - Requeue @node at end of same-prio entries.

@@ -172,6 +174,7 @@ void plist_requeue(struct plist_node *node, struct plist_head *head)
 
 	plist_check_head(head);
 }
+EXPORT_SYMBOL(plist_requeue);
 
 #ifdef CONFIG_DEBUG_PI_LIST
 #include <linux/sched.h>
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Hareesh Gundu

Allow plist_add(), plist_del() and plist_requeue() APIs to be referenced by kernel modules by adding the EXPORT_SYMBOL().

No, not without also showing those modules.

author
#2 lore raw
Quoted 3 lines · Peter Zijlstra
Quoted 2 lines · Hareesh Gundu

Allow plist_add(), plist_del() and plist_requeue() APIs to be referenced by kernel modules by adding the EXPORT_SYMBOL().

This change is not for in-tree kernel module. It's for modules built outside of kernel tree modules.

Is it really required to show out tree kernel modules ?

Quoted 2 lines

No, not without also showing those modules.

#3 lore raw
Quoted 9 lines · Hareesh Gundu
Quoted 3 lines · Peter Zijlstra
Quoted 2 lines · Hareesh Gundu

Allow plist_add(), plist_del() and plist_requeue() APIs to be referenced by kernel modules by adding the EXPORT_SYMBOL().

This change is not for in-tree kernel module. It's for modules built outside of kernel tree modules.

Is it really required to show out tree kernel modules ?

Typically we don't add EXPORTs for functions not used in in-tree modules.

author
#4 lore raw
Quoted 11 lines · Peter Zijlstra
Quoted 8 lines · Hareesh Gundu
Quoted 3 lines · Peter Zijlstra
Quoted 2 lines · Hareesh Gundu

Allow plist_add(), plist_del() and plist_requeue() APIs to be referenced by kernel modules by adding the EXPORT_SYMBOL().

This change is not for in-tree kernel module. It's for modules built outside of kernel tree modules.

Is it really required to show out tree kernel modules ?

Typically we don't add EXPORTs for functions not used in in-tree modules.

We changed our design and planned to have our module in-tree kernel instead of out tree kernel module. Below is the reference for in-tree kernel module proposal for "drviers/gpu/msm" which is referring to plist_* symbols.

https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/gpu/msm/adreno_dispatch.c?h=msm-4.9#n533

Could you please revisit the patch and approve for upstream.

#5 lore raw
Quoted 6 lines · Hareesh Gundu

Below is the reference for in-tree kernel module proposal for "drviers/gpu/msm" which is referring to plist_* symbols.

https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/gpu/msm/adreno_dispatch.c?h=msm-4.9#n533

Could you please revisit the patch and approve for upstream.

I could not find where you actually use the priority. In any case, the normal way is to submit the export patch along with the patches that use it.

Please post the lot to the appropriate lists and people and go from there.

Also, you're missing all the SPDX tags, see Documentation/process/license-rules.rst