Skip to contentSkip to conversation

samples: mbochs: add DMA_SHARED_BUFFER dependency

PATCH In review Arnd Bergmann 2 participants 2 messages May 30, 2018 – Jun 9, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 samples: mbochs: add DMA_SHARED_BUFFER dependency

The new bochs vbe sample fails to link when DMA_SHARED_BUFFER is disabled:

ERROR: "dma_buf_export" [samples/vfio-mdev/mbochs.ko] undefined!
ERROR: "dma_buf_fd" [samples/vfio-mdev/mbochs.ko] undefined!

This uses a 'select' statement to enable that framework, like all other users do.

Fixes 8021194eb3da ("sample: vfio bochs vbe display (host device for bochs-drm)")
---
 samples/Kconfig | 1 +
 1 file changed, 1 insertion(+)
samples/Kconfig +1 -0
index 3aeaaca77831..bd133efc1a56 100644
@@ -135,6 +135,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
 config SAMPLE_VFIO_MDEV_MBOCHS
 	tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
 	depends on VFIO_MDEV_DEVICE && m
+	select DMA_SHARED_BUFFER
 	help
 	  Build a virtual display sample driver for use as a VFIO
 	  mediated device.  It supports the region display interface
Signature · 1 line
2.9.0
#1 lore raw
Quoted 20 lines · On Wed, 30 May 2018 23:37:31 +0200 Arnd Bergmann <[email protected]> wrote:

The new bochs vbe sample fails to link when DMA_SHARED_BUFFER is disabled:

ERROR: "dma_buf_export" [samples/vfio-mdev/mbochs.ko] undefined!
ERROR: "dma_buf_fd" [samples/vfio-mdev/mbochs.ko] undefined!

This uses a 'select' statement to enable that framework, like all other users do.

Fixes 8021194eb3da ("sample: vfio bochs vbe display (host device for bochs-drm)")
---
 samples/Kconfig | 1 +
 1 file changed, 1 insertion(+)
samples/Kconfig +0 -0
index 3aeaaca77831..bd133efc1a56 100644

samples/Kconfig config SAMPLE_VFIO_MDEV_MDPY_FB · line 141

Quoted 7 lines
samples/Kconfig +1 -0
@@ -135,6 +135,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
 config SAMPLE_VFIO_MDEV_MBOCHS
 	tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
 	depends on VFIO_MDEV_DEVICE && m
+	select DMA_SHARED_BUFFER
 	help
 	  Build a virtual display sample driver for use as a VFIO
 	  mediated device.  It supports the region display interface

Almost missed this one. Applied to my next branch for v4.18, also updated the referenced commit ID as I've had to rebase to account for a reverted patch in the base. Thanks,

Alex