Skip to contentSkip to conversation

selftests: intel_pstate: notification about privilege required to run intel_pstate testing script

PATCH RESEND In review Jeffrin Jose T 2 participants 3 messages May 30, 2018 – May 31, 2018 Kselftest

lore
Share & tools
lore

Jeffrin Jose T

author
#0 lore raw

PATCH RESEND 1/1 selftests: intel_pstate: notification about privilege required to run intel_pstate testing script

The intel_pstate related testing script need root level privileges when trying to access certain file for the successful execution of the script.But this is not the case always like when using evaluation only mode, which only require user level privilege.

This patch is to notify the user about the privilege the script demands for the successful execution of the test.

Signed-off-by Jeffrin Jose T (Rajagiri SET) <ahiliation at gmail.com>
---
 tools/testing/selftests/intel_pstate/run.sh | 6 ++++++
 1 file changed, 6 insertions(+)
tools/testing/selftests/intel_pstate/run.sh +6 -0
index 8576f6564307..e7008f614ad7 100755
@@ -38,6 +38,12 @@ if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then
 	exit $ksft_skip
 fi
 
+msg="skip all tests:"
+if [ $UID != 0 ] && [ $EVALUATE_ONLY == 0 ]; then
+    echo $msg please run this as root >&2
+    exit $ksft_skip
+fi
+
 max_cpus=$(($(nproc)-1))
 
 function run_test () {
Signature · 6 lines
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#1 lore raw
Quoted 10 lines · Jeffrin Jose T

The intel_pstate related testing script need root level privileges when trying to access certain file for the successful execution of the script.But this is not the case always like when using evaluation only mode, which only require user level privilege.

This patch is to notify the user about the privilege the script demands for the successful execution of the test.

Signed-off-by Jeffrin Jose T (Rajagiri SET) <ahiliation at gmail.com>

---

I will take this patch and apply it to linux-kselftest next for 4.18-rc1.

For next time, this patch should have been tagged v2 not RESEND. Also please include changes made since the last version in this spot after the Signed-off-by line.

Quoted 11 lines
 tools/testing/selftests/intel_pstate/run.sh | 6 ++++++
 1 file changed, 6 insertions(+)
tools/testing/selftests/intel_pstate/run.sh +0 -0
index 8576f6564307..e7008f614ad7 100755
@@ -38,6 +38,12 @@ if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then
 	exit $ksft_skip
 fi

tools/testing/selftests/intel_pstate/run.sh if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then · line 49

Quoted 10 lines
tools/testing/selftests/intel_pstate/run.sh +6 -0
 
+msg="skip all tests:"
+if [ $UID != 0 ] && [ $EVALUATE_ONLY == 0 ]; then
+    echo $msg please run this as root >&2
+    exit $ksft_skip
+fi
+
 max_cpus=$(($(nproc)-1))
 
 function run_test () {

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
Quoted 1 line · Shuah Khan

I will take this patch and apply it to linux-kselftest next for 4.18-rc1.

anyway thanks .

Quoted 3 lines

For next time, this patch should have been tagged v2 not RESEND. Also please include changes made since the last version in this spot after the Signed-off-by line.

thanks for correction

--
software engineer
rajagiri school of engineering and technology
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html