Skip to contentSkip to conversation

USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

PATCH Superseded Greg Kroah-Hartman 1 participant 1 message May 31, 2018

Subsystems (2)
USB USB Type-C class
lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH v2 2/22 USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.

Clean up the fsusb302 driver to not care if the root directory was created, as the code should work properly either way.

Cc Heikki Krogerus <[email protected]>
Cc Guenter Roeck <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Adam Thomson <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>

---

v2: changes based on review from Guenter, we still need to keep
chip->dentry and the removal of the rootdir is properly reference counted, making this patch a lot smaller.

 drivers/usb/typec/fusb302/fusb302.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)
drivers/usb/typec/fusb302/fusb302.c +4 -11
index 9c1eba9ea004..1e68da10bf17 100644
@@ -215,20 +215,15 @@ DEFINE_SHOW_ATTRIBUTE(fusb302_debug);
 
 static struct dentry *rootdir;
 
-static int fusb302_debugfs_init(struct fusb302_chip *chip)
+static void fusb302_debugfs_init(struct fusb302_chip *chip)
 {
 	mutex_init(&chip->logbuffer_lock);
-	if (!rootdir) {
+	if (!rootdir)
 		rootdir = debugfs_create_dir("fusb302", NULL);
-		if (!rootdir)
-			return -ENOMEM;
-	}
 
 	chip->dentry = debugfs_create_file(dev_name(chip->dev),
 					   S_IFREG | 0444, rootdir,
 					   chip, &fusb302_debug_fops);
-
-	return 0;
 }
 
 static void fusb302_debugfs_exit(struct fusb302_chip *chip)

@@ -241,7 +236,7 @@ static void fusb302_debugfs_exit(struct fusb302_chip *chip)
 
 static void fusb302_log(const struct fusb302_chip *chip,
 			const char *fmt, ...) { }
-static int fusb302_debugfs_init(const struct fusb302_chip *chip) { return 0; }
+static void fusb302_debugfs_init(const struct fusb302_chip *chip) { }
 static void fusb302_debugfs_exit(const struct fusb302_chip *chip) { }
 
 #endif

@@ -1773,9 +1768,7 @@ static int fusb302_probe(struct i2c_client *client,
 			return -EPROBE_DEFER;
 	}
 
-	ret = fusb302_debugfs_init(chip);
-	if (ret < 0)
-		return ret;
+	fusb302_debugfs_init(chip);
 
 	chip->wq = create_singlethread_workqueue(dev_name(chip->dev));
 	if (!chip->wq) {