Skip to contentSkip to conversation

ARM: dts: aspeed: Fix hwrng register address

PATCH New Joel Stanley 2 participants 2 messages May 30, 2018 – Jun 2, 2018

Subsystems (2)
lore
Share & tools
lore

Joel Stanley

author maintainer
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: Fix hwrng register address

The register address should be the full address of the rng, not the offset from the start of the SCU.

Fixes 5daa8212c08e ("ARM: dts: aspeed: Describe random number device")

---
Hi ARM maintainers, this was found when testing next-20180529 after the merge of the aspeed 4.18 pull request. Can you please apply this one to your -next tree?

I'll also send a PR with some defconfig updates so the rng driver is enabled by default.
---

 arch/arm/boot/dts/aspeed-g4.dtsi | 4 ++--
 arch/arm/boot/dts/aspeed-g5.dtsi | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/aspeed-g4.dtsi +2 -2
index 5e947ed496c2..75df1573380e 100644
@@ -145,9 +145,9 @@
 
 			};
 
-			rng: hwrng at 78 {
+			rng: hwrng at 1e6e2078 {
 				compatible = "timeriomem_rng";
-				reg = <0x78 0x4>;
+				reg = <0x1e6e2078 0x4>;
 				period = <1>;
 				quality = <100>;
 			};
arch/arm/boot/dts/aspeed-g5.dtsi +2 -2
index 24eec00c4a95..17f2714d18a7 100644
@@ -189,9 +189,9 @@
 				};
 			};
 
-			rng: hwrng at 78 {
+			rng: hwrng at 1e6e2078 {
 				compatible = "timeriomem_rng";
-				reg = <0x78 0x4>;
+				reg = <0x1e6e2078 0x4>;
 				period = <1>;
 				quality = <100>;
 			};
Signature · 1 line
2.17.0
#1 lore raw

PATCH 1/1 ARM: dts: aspeed: Fix hwrng register address

Quoted 10 lines · Joel Stanley

The register address should be the full address of the rng, not the offset from the start of the SCU.

Fixes 5daa8212c08e ("ARM: dts: aspeed: Describe random number device")

---
Hi ARM maintainers, this was found when testing next-20180529 after the merge of the aspeed 4.18 pull request. Can you please apply this one to your -next tree?

Certainly, applied to our next/dt branch now.

Thanks,

-Olof