Skip to contentSkip to conversation

ARM: kirkwood: Enforce size limit for sheevaplug

PATCH New Chris Packham 2 participants 6 messages Jun 4, 2018 – Jun 5, 2018

lore
Share & tools
lore

Chris Packham

author
#0 lore raw

PATCH 1/2 ARM: kirkwood: Enforce size limit for sheevaplug

The u-boot binary sits in flash immediately before the environment. Don't allow the binary size to grow into the environment space.

Signed-off-by Chris Packham <[email protected]>

---
This will actually result in a build failure. Which is what we want, at least until https://lists.denx.de/pipermail/u-boot/2018-June/330467.html
is merged.

 include/configs/sheevaplug.h | 5 +++++
 1 file changed, 5 insertions(+)
include/configs/sheevaplug.h +5 -0
index 23dd5ceb7cb9..dc6375841ed8 100644
@@ -44,6 +44,11 @@
 #define CONFIG_ENV_SIZE			0x20000	/* 128k */
 #define CONFIG_ENV_ADDR			0x80000
 #define CONFIG_ENV_OFFSET		0x80000	/* env starts here */
+/*
+ * Environment is right behind U-Boot in flash. Make sure U-Boot
+ * doesn't grow into the environment area.
+ */
+#define CONFIG_BOARD_SIZE_LIMIT		CONFIG_ENV_OFFSET
 
 /*
  * Default environment variables
Signature · 1 line
2.17.0
author
#1 lore raw

PATCH 2/2 ARM: kirkwood: Enforce size limit for guruplug

The u-boot binary sits in flash immediately before the environment. Don't allow the binary size to grow into the environment space.

Signed-off-by Chris Packham <[email protected]>

---

 include/configs/guruplug.h | 5 +++++
 1 file changed, 5 insertions(+)
include/configs/guruplug.h +5 -0
index 9e7ca60f112f..04b7e944a461 100644
@@ -39,6 +39,11 @@
  */
 #define CONFIG_ENV_SIZE			0x20000	/* 128k */
 #define CONFIG_ENV_OFFSET		0xE0000	/* env starts here */
+/*
+ * Environment is right behind U-Boot in flash. Make sure U-Boot
+ * doesn't grow into the environment area.
+ */
+#define CONFIG_BOARD_SIZE_LIMIT		CONFIG_ENV_OFFSET
 
 /*
  * Default environment variables
Signature · 1 line
2.17.0
#2 lore raw

PATCH 2/2 ARM: kirkwood: Enforce size limit for guruplug

Quoted 8 lines · Chris Packham

The u-boot binary sits in flash immediately before the environment. Don't allow the binary size to grow into the environment space.

Signed-off-by Chris Packham <[email protected]>

---

  include/configs/guruplug.h | 5 +++++
  1 file changed, 5 insertions(+)
Reviewed-by Stefan Roese <[email protected]>

Thanks,
Stefan

#4 lore raw

PATCH 1/2 ARM: kirkwood: Enforce size limit for sheevaplug

In reply to Chris Packham
Quoted 11 lines · Chris Packham

The u-boot binary sits in flash immediately before the environment. Don't allow the binary size to grow into the environment space.

Signed-off-by Chris Packham <[email protected]>

---
This will actually result in a build failure. Which is what we want, at least until https://lists.denx.de/pipermail/u-boot/2018-June/330467.html
is merged.

  include/configs/sheevaplug.h | 5 +++++
  1 file changed, 5 insertions(+)
Reviewed-by Stefan Roese <[email protected]>

Thanks,
Stefan