Skip to contentSkip to conversation

m4/ltp-kernel_devel.m4: get LINUX_VERSION from LINUX_DIR during configure

PATCH New Yixin Zhang 3 participants 3 messages Jun 4, 2018 – Jun 5, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 m4/ltp-kernel_devel.m4: get LINUX_VERSION from LINUX_DIR during configure

If LINUX_DIR is given, get LINUX_VERSION for kernel source code instead of uname -r. So when we need to build .ko with a kernel differernt than the one on current host PC, we only need to provide "--with-linux-dir", and LINUX_VERSION will be generated automatically.

---
 m4/ltp-kernel_devel.m4 | 1 +
 1 file changed, 1 insertion(+)
m4/ltp-kernel_devel.m4 +1 -0
index 1c4e71f73..477a34aa9 100644
@@ -47,6 +47,7 @@ AC_ARG_WITH([linux-dir],
 AC_SUBST(LINUX_DIR)
 
 if test -f "$LINUX_DIR/Makefile"; then
+	LINUX_VERSION=`make -C ${LINUX_DIR} -s kernelversion`
 	LINUX_VERSION_MAJOR=`make -C ${LINUX_DIR} -s kernelversion | cut -d. -f1`
 	LINUX_VERSION_PATCH=`make -C ${LINUX_DIR} -s kernelversion | cut -d. -f2`
 fi
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 m4/ltp-kernel_devel.m4: get LINUX_VERSION from LINUX_DIR during configure

Hi!

Quoted 4 lines

If LINUX_DIR is given, get LINUX_VERSION for kernel source code instead of uname -r. So when we need to build .ko with a kernel differernt than the one on current host PC, we only need to provide "--with-linux-dir", and LINUX_VERSION will be generated automatically.

Looking at the m4 file for kernel-devel it seems we only use the LINUX_VERSION in order to construct the LINUX_DIR path and the rest of the code, i.e. include/mk/module.mk uses the LINUX_VERSION_MAJOR and LINUX_VERSION_MINOR generated based on the LINUX_DIR.

What is the LINUX_VERSION variable needed for? It does not seem to be used anywhere outside the m4 kernel devel file.

Signature · 2 lines
Cyril Hrubis
[email protected]
#2 lore raw

PATCH 1/1 m4/ltp-kernel_devel.m4: get LINUX_VERSION from LINUX_DIR during configure

Hi Cyril,

I've double check the code and re-test multiple times today and you are right, the "LINUX_VERSION" variable has nothing to do with building kernel module. There was something wrong with my environment yesterday I think. Please ignore this patch, thanks.

Yixin

Quoted 17 lines · Cyril Hrubis

Hi!

Quoted 4 lines

If LINUX_DIR is given, get LINUX_VERSION for kernel source code instead of uname -r. So when we need to build .ko with a kernel differernt than the one on current host PC, we only need to provide "--with-linux-dir", and LINUX_VERSION will be generated automatically.

Looking at the m4 file for kernel-devel it seems we only use the LINUX_VERSION in order to construct the LINUX_DIR path and the rest of the code, i.e. include/mk/module.mk uses the LINUX_VERSION_MAJOR and LINUX_VERSION_MINOR generated based on the LINUX_DIR.

What is the LINUX_VERSION variable needed for? It does not seem to be used anywhere outside the m4 kernel devel file.

Signature · 2 lines
Cyril Hrubis
[email protected]