tcg-target.inc.c: Use byte form of xgetbv instruction
PATCH 1/1 tcg-target.inc.c: Use byte form of xgetbv instruction
The assembler in most versions of Mac OS X is pretty old and does not support the xgetbv instruction. To go around this problem the raw encoding of the instruction is used instead.
--- tcg/i386/tcg-target.inc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
tcg/i386/tcg-target.inc.c +5 -1
@@ -3501,7 +3501,11 @@ static void tcg_target_init(TCGContext *s)sure of not hitting invalid opcode. */ if (c & bit_OSXSAVE) {unsigned xcrl, xcrh; - asm ("xgetbv" :"=a" (xcrl),"=d" (xcrh) :"c" (0 )); +/* +* The xgetbv instruction is not available to older versions of the +* assembler, so we encode the instruction manually. +*/ + asm (".byte 0x0f, 0x01, 0xd0" :"=a" (xcrl),"=d" (xcrh) :"c" (0 ));if ((xcrl &6 ) ==6 ) { have_avx1 = (c & bit_AVX) !=0 ; have_avx2 = (b7 & bit_AVX2) !=0 ;
Signature · 1 line
2.10.2
This series seems to have some coding style problems. See output below for more information:
Hi,
This series seems to have some coding style problems. See output below for more information:
Type: series
Message-id: [email protected]
Subject: [Qemu-devel] [PATCH] tcg-target.inc.c: Use byte form of xgetbv instruction
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/[email protected] -> patchew/[email protected]
* [new tag] patchew/[email protected] -> patchew/[email protected]
Switched to a new branch 'test'8ee6e3972e tcg-target.inc.c: Use byte form of xgetbv instruction
=== OUTPUT BEGIN ===
Checking PATCH 1/1: tcg-target.inc.c: Use byte form of xgetbv instruction...
ERROR: trailing whitespace
#23: FILE: tcg/i386/tcg-target.inc.c:3505:
+ * The xgetbv instruction is not available to older versions of the $
ERROR: spaces required around that ':' (ctx:VxW)
#26: FILE: tcg/i386/tcg-target.inc.c:3508:
+ asm (".byte 0x0f, 0x01, 0xd0": "=a" (xcrl), "=d" (xcrh) : "c" (0));
^total: 2 errors, 0 warnings, 12 lines checked
Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [email protected]