Skip to contentSkip to conversation

Inherit default value for bootdelay from distro_bootcmd on odroid-xu3.

PATCH RESEND New Vagrant Cascadian 4 participants 5 messages Jun 3, 2018 – Jun 4, 2018

v1 of 2 New Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 Inherit default value for bootdelay from distro_bootcmd on odroid-xu3.

The default value with distro_bootcmd is 2 seconds, which is reasonably fast, and provides a consistent experience across platforms supporting distro_bootcmd.

The current bootdelay value of 0 seconds is a bit challenging to interrupt when desired.

---

 include/configs/odroid_xu3.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/odroid_xu3.h +0 -1
index 9898c42b8e..f495f6219b 100644
@@ -101,7 +101,6 @@
 	EXYNOS_FDTFILE_SETTING \
 	MEM_LAYOUT_ENV_SETTINGS \
 	BOOTENV \
-	"bootdelay=0\0" \
 	"rootfstype=ext4\0" \
 	"console=" CONFIG_DEFAULT_CONSOLE "\0"\
 	"fdtfile=exynos5422-odroidxu3.dtb\0" \
Signature · 1 line
2.11.0
#1 lore raw

PATCH RESEND 1/1 Inherit default value for bootdelay from distro_bootcmd on odroid-xu3.

Quoted 8 lines · Vagrant Cascadian

The default value with distro_bootcmd is 2 seconds, which is reasonably fast, and provides a consistent experience across platforms supporting distro_bootcmd.

The current bootdelay value of 0 seconds is a bit challenging to interrupt when desired.

We should not make console access unnecessarily difficult. The patch is applicable and building sets bootdelay=2 in the default environment.

@Tom:
As Jaehoon did not find time for reviewing since March, would you pick up the patch?

Quoted 18 lines

---

 include/configs/odroid_xu3.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/odroid_xu3.h +0 -1
index 9898c42b8e..f495f6219b 100644
@@ -101,7 +101,6 @@
 	EXYNOS_FDTFILE_SETTING \
 	MEM_LAYOUT_ENV_SETTINGS \
 	BOOTENV \
-	"bootdelay=0\0" \
 	"rootfstype=ext4\0" \
 	"console=" CONFIG_DEFAULT_CONSOLE "\0"\
 	"fdtfile=exynos5422-odroidxu3.dtb\0" \
#2 lore raw

PATCH RESEND 1/1 Inherit default value for bootdelay from distro_bootcmd on odroid-xu3.

Quoted 14 lines · Heinrich Schuchardt
Quoted 8 lines · Vagrant Cascadian

The default value with distro_bootcmd is 2 seconds, which is reasonably fast, and provides a consistent experience across platforms supporting distro_bootcmd.

The current bootdelay value of 0 seconds is a bit challenging to interrupt when desired.

We should not make console access unnecessarily difficult. The patch is applicable and building sets bootdelay=2 in the default environment.

Quoted 5 lines

@Tom:
As Jaehoon did not find time for reviewing since March, would you pick up the patch?

Signature · 2 lines
Best regards,
Marek Vasut
#3 lore raw

PATCH RESEND 1/1 Inherit default value for bootdelay from distro_bootcmd on odroid-xu3.

In reply to Heinrich Schuchardt
Quoted 14 lines · Heinrich Schuchardt
Quoted 8 lines · Vagrant Cascadian

The default value with distro_bootcmd is 2 seconds, which is reasonably fast, and provides a consistent experience across platforms supporting distro_bootcmd.

The current bootdelay value of 0 seconds is a bit challenging to interrupt when desired.

We should not make console access unnecessarily difficult. The patch is applicable and building sets bootdelay=2 in the default environment.

Quoted 5 lines

@Tom:
As Jaehoon did not find time for reviewing since March, would you pick up the patch?

OK, I'll pick it up, thanks guys!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180603/74006a7e/attachment.sig>
#4 lore raw

PATCH RESEND 1/1 Inherit default value for bootdelay from distro_bootcmd on odroid-xu3.

In reply to Vagrant Cascadian
Quoted 10 lines · Vagrant Cascadian

The default value with distro_bootcmd is 2 seconds, which is reasonably fast, and provides a consistent experience across platforms supporting distro_bootcmd.

The current bootdelay value of 0 seconds is a bit challenging to interrupt when desired.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180604/e98a3b6b/attachment.sig>