Skip to contentSkip to conversation

audit: do not remove file installed by netplug

PATCH New Carlos Santos 3 participants 4 messages Jun 5, 2018 – Jul 17, 2018

lore
Share & tools
lore

Carlos Santos

author
#0 lore raw

PATCH v2 1/1 audit: do not remove file installed by netplug

The package recipe uses a post-install hook to remove useless files from $(TARGET_DIR)/etc/rc.d/init.d and $(TARGET_DIR)/etc/sysconfig. This may damage packages that install useful files on those directories (such as netplug, which installs $(TARGET_DIR)/etc/rc.d/init.d/netplugd).

In the future[1] we will reorganize the init scripts and possibly get rid of /etc/rc.d and /etc/sysconfig but for the moment let's restrict the file removal to those installed by audit.

1. http://lists.busybox.net/pipermail/buildroot/2018-May/221549.html

Signed-off-by Carlos Santos <[email protected]>

---
Changes v1->v2
- Remove file from /etc/rc.d/init.d/, not /etc/rc.d/

---
 package/audit/audit.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/audit/audit.mk +2 -2
index f5aa00d2f0..2f6e6653b3 100644
@@ -51,8 +51,8 @@ define AUDIT_INSTALL_INIT_SYSTEMD
 endef
 
 define AUDIT_INSTALL_CLEANUP
-	$(RM) -rf $(TARGET_DIR)/etc/rc.d
-	$(RM) -rf $(TARGET_DIR)/etc/sysconfig
+	$(RM) $(TARGET_DIR)/etc/rc.d/init.d/auditd
+	$(RM) $(TARGET_DIR)/etc/sysconfig/auditd
 endef
 AUDIT_POST_INSTALL_TARGET_HOOKS += AUDIT_INSTALL_CLEANUP
Signature · 1 line
2.17.0
Applied
#1 lore raw

PATCH v2 1/1 audit: do not remove file installed by netplug

Hello,

Quoted 11 lines · Carlos Santos

The package recipe uses a post-install hook to remove useless files from $(TARGET_DIR)/etc/rc.d/init.d and $(TARGET_DIR)/etc/sysconfig. This may damage packages that install useful files on those directories (such as netplug, which installs $(TARGET_DIR)/etc/rc.d/init.d/netplugd).

In the future[1] we will reorganize the init scripts and possibly get rid of /etc/rc.d and /etc/sysconfig but for the moment let's restrict the file removal to those installed by audit.

1. http://lists.busybox.net/pipermail/buildroot/2018-May/221549.html

Quoted 7 lines
Signed-off-by Carlos Santos <[email protected]>

---
Changes v1->v2
- Remove file from /etc/rc.d/init.d/, not /etc/rc.d/

---
 package/audit/audit.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 audit: do not remove file installed by netplug

In reply to Carlos Santos
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Carlos" == Carlos Santos <[email protected]> writes:

The package recipe uses a post-install hook to remove useless files from $(TARGET_DIR)/etc/rc.d/init.d and $(TARGET_DIR)/etc/sysconfig. This may damage packages that install useful files on those directories (such as netplug, which installs $(TARGET_DIR)/etc/rc.d/init.d/netplugd).

In the future[1] we will reorganize the init scripts and possibly get rid of /etc/rc.d and /etc/sysconfig but for the moment let's restrict the file removal to those installed by audit.

Quoted 6 lines

1. http://lists.busybox.net/pipermail/buildroot/2018-May/221549.html

Signed-off-by Carlos Santos <[email protected]>

---
Changes v1->v2
- Remove file from /etc/rc.d/init.d/, not /etc/rc.d/

Committed to 2018.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v2 1/1 audit: do not remove file installed by netplug

In reply to Carlos Santos
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Carlos" == Carlos Santos <[email protected]> writes:

The package recipe uses a post-install hook to remove useless files from $(TARGET_DIR)/etc/rc.d/init.d and $(TARGET_DIR)/etc/sysconfig. This may damage packages that install useful files on those directories (such as netplug, which installs $(TARGET_DIR)/etc/rc.d/init.d/netplugd).

In the future[1] we will reorganize the init scripts and possibly get rid of /etc/rc.d and /etc/sysconfig but for the moment let's restrict the file removal to those installed by audit.

Quoted 6 lines

1. http://lists.busybox.net/pipermail/buildroot/2018-May/221549.html

Signed-off-by Carlos Santos <[email protected]>

---
Changes v1->v2
- Remove file from /etc/rc.d/init.d/, not /etc/rc.d/

Committed to 2018.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard