Skip to contentSkip to conversation

netplug: look for init script configurations at /etc/default/

PATCH New Carlos Santos 3 participants 4 messages Jun 5, 2018 – Jun 17, 2018

lore
Share & tools
lore

Carlos Santos

author
#0 lore raw

PATCH 1/1 netplug: look for init script configurations at /etc/default/

We are working to make all sysvinit scripts conformant to a pattern and /etc/default/ seems to be a good choice, since 34 packages already get optional configurations from files at that directory.

netplug still installs an init script at /etc/rc.d/init.d/. This will be fixed in a future patch that will refactor the init scripts.

Signed-off-by Carlos Santos <[email protected]>
---
 package/netplug/S29netplug | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
package/netplug/S29netplug +4 -4
index 03422499d6..04cac9f07c 100755
@@ -22,8 +22,8 @@ elif [ -f /etc/rc.d/init.d/functions ]; then
 fi
 
 # Source networking configuration.
-if [ -f /etc/sysconfig/network ]; then
-	. /etc/sysconfig/network
+if [ -f /etc/default/network ]; then
+	. /etc/default/network
 
 	# Check that networking is up.
 	[ ${NETWORKING} = "no" ] && exit 0

@@ -32,8 +32,8 @@ elif [ ! -f /etc/network/interfaces ]; then
 	exit 0
 fi
 
-if [ -f /etc/sysconfig/netplugd ]; then
-    . /etc/sysconfig/netplugd
+if [ -f /etc/default/netplugd ]; then
+    . /etc/default/netplugd
 fi
 
 # See how we were called.
Signature · 1 line
2.17.0
Applied
#1 lore raw

PATCH 1/1 netplug: look for init script configurations at /etc/default/

Hello,

Quoted 11 lines · Carlos Santos

We are working to make all sysvinit scripts conformant to a pattern and /etc/default/ seems to be a good choice, since 34 packages already get optional configurations from files at that directory.

netplug still installs an init script at /etc/rc.d/init.d/. This will be fixed in a future patch that will refactor the init scripts.

Signed-off-by Carlos Santos <[email protected]>
---
 package/netplug/S29netplug | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 netplug: look for init script configurations at /etc/default/

In reply to Carlos Santos

Hello,

Quoted 8 lines · Carlos Santos

We are working to make all sysvinit scripts conformant to a pattern and /etc/default/ seems to be a good choice, since 34 packages already get optional configurations from files at that directory.

netplug still installs an init script at /etc/rc.d/init.d/. This will be fixed in a future patch that will refactor the init scripts.

Signed-off-by Carlos Santos <[email protected]>

Since you're looking at netplug, perhaps you could look at
https://bugs.busybox.net/show_bug.cgi?id=10661 ?

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 netplug: look for init script configurations at /etc/default/

In reply to Carlos Santos
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Carlos" == Carlos Santos <[email protected]> writes:

We are working to make all sysvinit scripts conformant to a pattern and /etc/default/ seems to be a good choice, since 34 packages already get optional configurations from files at that directory.

netplug still installs an init script at /etc/rc.d/init.d/. This will be fixed in a future patch that will refactor the init scripts.

Signed-off-by Carlos Santos <[email protected]>

Committed to 2018.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard