Use one call to mkdir to create needed directories.
PATCH 1/1 Use one call to mkdir to create needed directories.
Reduce this to only call mkdir once to create the needed directories.
--- package/busybox/inittab | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
package/busybox/inittab +1 -2
@@ -16,8 +16,7 @@ # Startup the system ::sysinit:/bin/mount -t proc proc /proc ::sysinit:/bin/mount -o remount,rw / -::sysinit:/bin/mkdir -p /dev/pts -::sysinit:/bin/mkdir -p /dev/shm +::sysinit:/bin/mkdir -p /dev/pts /dev/shm ::sysinit:/bin/mount -a null::sysinit:/bin/ln -sf /proc/self/fd /dev/fd null::sysinit:/bin/ln -sf /proc/self/fd/0 /dev/stdin
Signature · 9 lines
2.17.0 Gesch?ftsf?hrung: Susanne Kunschert, Thomas Pilz Pilz GmbH & Co. KG, Sitz: Ostfildern, HRA 210 893, Amtsgericht Stuttgart Kompl. Ges. Peter Pilz GmbH, Sitz: Ostfildern, HRB 210 612, Amtsgericht Stuttgart Umsatzsteuer: ID-Nr. DE 145 355 773, WEEE-Reg.-Nr. DE 71636849 This email is intended solely for the use of the named address(es). Any unauthorised disclosure, copying or distribution of these confidential information contained therein, or the taking of any action based on it, is prohibited. The sender disclaims any liability for the integrity of this email. Legally binding declarations must be in written form. Umweltschutz liegt uns am Herzen! - Bitte denken Sie an unsere Umwelt, bevor Sie diese E-Mail drucken. We do care about the environment! - Please consider the environment before printing this e-mail.
PATCH 1/1 Use one call to mkdir to create needed directories.
Hello,
Quoted 4 lines · Florian La Roche
Reduce this to only call mkdir once to create the needed directories.
Signed-off-by Florian La Roche <[email protected]>
Thanks for all your patches. Generally they look good to me in terms of contents, but there are a few minor formatting issues that would make them better:
- The commit title should include a prefix of the package being impacted.
- The commit title should often be a bit shorter.
- The commit log should contain only one empty line before the SoB line, not two empty lines.
- A non empty commit log would be better, to give additional explanations when necessary.
For this patch, a better commit log would for example be:
busybox: reduce number of mkdir calls in inittab
The default Busybox inittab does two separate mkdir calls to create /dev/pts and /dev/shm, which is not necessary. Let's refactor those two calls into a single one.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com