ti-xdctools-common: Add XDC tools to -dev package

PATCH In review Joshua Watt 2 participants 4 messages Jun 5, 2018 – Jun 11, 2018

Share & tools

Joshua Watt

author

2018-06-05 14:45 UTC #0 lore raw

PATCH 1/1 ti-xdctools-common: Add XDC tools to -dev package

b42044aaf removed the XDC tools from the main package, but this broke the ability to include the XDC tools in an SDK. Add the tools back to the -dev package. Also fix up INSANE_SKIP.

Change-Id I902cc1a841e40c1a3bdc5286d03f999276119052

Signed-off-by Joshua Watt <[email protected]>

---
 recipes-ti/devtools/ti-xdctools-common.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

recipes-ti/devtools/ti-xdctools-common.inc +3 -1

index d2d0df45..a3949cad 100644
@@ -13,12 +13,14 @@ do_install() {
     cp ${CP_ARGS}  ${S}/* ${D}${XDC_INSTALL_DIR_RECIPE}
 }
 
+FILES_${PN}-dev = "${XDC_INSTALL_DIR_RECIPE}"
+
 BBCLASSEXTEND = "native nativesdk"
 
 INHIBIT_PACKAGE_STRIP = "1"
 INHIBIT_SYSROOT_STRIP = "1"
 INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
-INSANE_SKIP_${PN} = "installed-vs-shipped"
+INSANE_SKIP_${PN}-dev = "libdir dev-elf arch file-rdeps"
 
 # Prevent internal libs from getting picked up
 PRIVATE_LIBS = " \

Signature · 1 line

2.17.0

Denys Dmytriyenko

2018-06-05 18:40 UTC #1 lore raw

Do you still need this on morty?

Quoted 39 lines · Joshua Watt

b42044aaf removed the XDC tools from the main package, but this broke the ability to include the XDC tools in an SDK. Add the tools back to the -dev package. Also fix up INSANE_SKIP.

Change-Id I902cc1a841e40c1a3bdc5286d03f999276119052

Signed-off-by Joshua Watt <[email protected]>

---
 recipes-ti/devtools/ti-xdctools-common.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

recipes-ti/devtools/ti-xdctools-common.inc +3 -1

index d2d0df45..a3949cad 100644
@@ -13,12 +13,14 @@ do_install() {
     cp ${CP_ARGS}  ${S}/* ${D}${XDC_INSTALL_DIR_RECIPE}
 }
 
+FILES_${PN}-dev = "${XDC_INSTALL_DIR_RECIPE}"
+
 BBCLASSEXTEND = "native nativesdk"
 
 INHIBIT_PACKAGE_STRIP = "1"
 INHIBIT_SYSROOT_STRIP = "1"
 INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
-INSANE_SKIP_${PN} = "installed-vs-shipped"
+INSANE_SKIP_${PN}-dev = "libdir dev-elf arch file-rdeps"
 
 # Prevent internal libs from getting picked up
 PRIVATE_LIBS = " \

Signature · 7 lines

2.17.0

-- 
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

Joshua Watt

author

2018-06-05 21:27 UTC #2 lore raw

Quoted 1 line · Denys Dmytriyenko

Do you still need this on morty?

If possible. We are (unfortunately) still on morty.

Quoted 23 lines · Joshua Watt

Quoted 21 lines
b42044aaf removed the XDC tools from the main package, but this broke
the ability to include the XDC tools in an SDK. Add the tools back to
the -dev package. Also fix up INSANE_SKIP.
Change-Id I902cc1a841e40c1a3bdc5286d03f999276119052
Signed-off-by Joshua Watt <[email protected]>
---
 recipes-ti/devtools/ti-xdctools-common.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
recipes- renamed from recipes-ti/devtools/ti-xdctools-common.inc +0 -0
ti/devtools/ti-xdctools-common.inc
index d2d0df45..a3949cad 100644
recipes-ti/devtools/ti-xdctools-common.inc +0 -0
@@ -13,12 +13,14 @@ do_install() {
     cp ${CP_ARGS}  ${S}/* ${D}${XDC_INSTALL_DIR_RECIPE}
 }
 

Quoted 1 line

recipes-ti/devtools/ti-xdctools-common.inc do_install() { · line 16
Quoted 1 line
recipes-ti/devtools/ti-xdctools-common.inc +1 -0
+FILES_${PN}-dev = "${XDC_INSTALL_DIR_RECIPE}"

I was going to ask about this.... It seems counter to the mechanism used in some of the other (TI) recipes to put these files in the -dev package. It seems that most recipes that are intended to be native tools include their files in the "${PN}" package instead of the "${PN}- dev" package. For example, ti-cgt-pru, ti-cgt-arm-native, and ti-cgt6x- 7-native all do this. The recipes that are putting files in "-dev" appear to be on-target recipes. This layout makes more sense to me, and fits better with our use case. What we would like to do is add:

TOOLCHAIN_HOST_TASK += "nativesdk-ti-xdctools"

however, with this patch as currently written, we would have to do:

TOOLCHAIN_HOST_TASK += "nativesdk-ti-xdctools-dev"

I used -dev in this patch because the referenced commit removed the files from "${PN}", and I wasn't sure if there was a reason (that, and at the time I didn't fully comprehend the difference between native and target recipes that I described above). Do you know if there was a reason the FILE_${PN} was removed in b42044aaf?

Thanks,
Joshua Watt

Quoted 20 lines

recipes-ti/devtools/ti-xdctools-common.inc +2 -1

+
 BBCLASSEXTEND = "native nativesdk"
 
 INHIBIT_PACKAGE_STRIP = "1"
 INHIBIT_SYSROOT_STRIP = "1"
 INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
-INSANE_SKIP_${PN} = "installed-vs-shipped"
+INSANE_SKIP_${PN}-dev = "libdir dev-elf arch file-rdeps"
 
 # Prevent internal libs from getting picked up
 PRIVATE_LIBS = " \

Signature · 7 lines

2.17.0

-- 
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

Joshua Watt

author

2018-06-11 17:54 UTC #3 lore raw

Quoted 76 lines · Joshua Watt

Quoted 1 line · Denys Dmytriyenko
Do you still need this on morty?
If possible. We are (unfortunately) still on morty.
Quoted 25 lines · Joshua Watt
Quoted 23 lines
b42044aaf removed the XDC tools from the main package, but this broke
the ability to include the XDC tools in an SDK. Add the tools back
to
the -dev package. Also fix up INSANE_SKIP.
Change-Id I902cc1a841e40c1a3bdc5286d03f999276119052
Signed-off-by Joshua Watt <[email protected]>
---
 recipes-ti/devtools/ti-xdctools-common.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
recipes- renamed from recipes-ti/devtools/ti-xdctools-common.inc +0 -0
ti/devtools/ti-xdctools-common.inc
index d2d0df45..a3949cad 100644
recipes-ti/devtools/ti-xdctools-common.inc +0 -0
@@ -13,12 +13,14 @@ do_install() {
     cp ${CP_ARGS}  ${S}/* ${D}${XDC_INSTALL_DIR_RECIPE}
 }
 
Quoted 1 line
recipes-ti/devtools/ti-xdctools-common.inc do_install() { · line 16
Quoted 1 line
recipes-ti/devtools/ti-xdctools-common.inc +1 -0
+FILES_${PN}-dev = "${XDC_INSTALL_DIR_RECIPE}"
I was going to ask about this.... It seems counter to the mechanism used in some of the other (TI) recipes to put these files in the -dev package. It seems that most recipes that are intended to be native tools include their files in the "${PN}" package instead of the "${PN}-
dev" package. For example, ti-cgt-pru, ti-cgt-arm-native, and ti- cgt6x-
7-native all do this. The recipes that are putting files in "-dev" appear to be on-target recipes. This layout makes more sense to me, and
fits better with our use case. What we would like to do is add:
TOOLCHAIN_HOST_TASK += "nativesdk-ti-xdctools"
however, with this patch as currently written, we would have to do:
TOOLCHAIN_HOST_TASK += "nativesdk-ti-xdctools-dev"
I used -dev in this patch because the referenced commit removed the files from "${PN}", and I wasn't sure if there was a reason (that, and
at the time I didn't fully comprehend the difference between native and
target recipes that I described above). Do you know if there was a reason the FILE_${PN} was removed in b42044aaf?
Thanks,
Joshua Watt
Quoted 14 lines
Quoted 14 lines
recipes-ti/devtools/ti-xdctools-common.inc +2 -1
+
 BBCLASSEXTEND = "native nativesdk"
 
 INHIBIT_PACKAGE_STRIP = "1"
 INHIBIT_SYSROOT_STRIP = "1"
 INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
-INSANE_SKIP_${PN} = "installed-vs-shipped"
+INSANE_SKIP_${PN}-dev = "libdir dev-elf arch file-rdeps"
 
 # Prevent internal libs from getting picked up
 PRIVATE_LIBS = " \
Signature · 1 line
2.17.0

Quoted 6 lines

Signature · 4 lines

_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

Ping?