Skip to contentSkip to conversation

pwm: imx: Switch to SPDX identifier

PATCH In review Fabio Estevam 2 participants 3 messages May 20, 2018 – Jun 6, 2018

Subsystems (2)
Arm i.MX and Layerscape PWM
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 pwm: imx: Switch to SPDX identifier

From: Fabio Estevam <[email protected]>

Adopt the SPDX license identifier headers to ease license compliance management.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/pwm/pwm-imx.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)
drivers/pwm/pwm-imx.c +5 -9
index 08cbe81..6ddd6fd 100644
@@ -1,12 +1,8 @@
-/*
- * simple driver for PWM (Pulse Width Modulator) controller
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * Derived from pxa PWM driver by eric miao <[email protected]>
- */
+// SPDX-License-Identifier: GPL-2.0
+//
+// simple driver for PWM (Pulse Width Modulator) controller
+//
+// Derived from pxa PWM driver by eric miao <[email protected]>
 
 #include <linux/module.h>
 #include <linux/kernel.h>
Signature · 1 line
2.7.4
#1 lore raw
Quoted 19 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Adopt the SPDX license identifier headers to ease license compliance management.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/pwm/pwm-imx.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)
drivers/pwm/pwm-imx.c +0 -4
index 08cbe81..6ddd6fd 100644
@@ -1,12 +1,8 @@
-/*
- * simple driver for PWM (Pulse Width Modulator) controller
- *
- * This program is free software; you can redistribute it and/or modify

drivers/pwm/pwm-imx.c line 5

Quoted 10 lines
drivers/pwm/pwm-imx.c +5 -5
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * Derived from pxa PWM driver by eric miao <[email protected]>
- */
+// SPDX-License-Identifier: GPL-2.0
+//
+// simple driver for PWM (Pulse Width Modulator) controller
+//
+// Derived from pxa PWM driver by eric miao <[email protected]>

Why do you replace the complete comment by C++ style? I thought only the SPDX identifier was required to be in that style.

Thierry

author reviewer
#2 lore raw

Hi Thierry,

Quoted 2 lines · Thierry Reding

Why do you replace the complete comment by C++ style? I thought only the SPDX identifier was required to be in that style.

Putting everything as // is Linus Torvalds' preferred style:
https://lkml.org/lkml/2017/11/25/133

Regards,

Fabio Estevam