Skip to contentSkip to conversation

dm-integrity: change the variable suspending from bool to int

PATCH In review Mikulas Patocka 1 participant 1 message Jun 6, 2018

Subsystems (2)
Stable branch Device mapper
lore
Share & tools
lore

Mikulas Patocka

author maintainer
#0 lore raw

PATCH 1/9 dm-integrity: change the variable suspending from bool to int

The early alpha processors can't write a byte or short atomically - they read 8 bytes, modify the byte or two bytes in registers and write back 8 bytes. The modification of the variable "suspending" may race with modification of the variable "failed".

This patch changes suspending to an int.

Signed-off-by Mikulas Patocka <[email protected]>
Cc [email protected]
---
 drivers/md/dm-integrity.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/md/dm-integrity.c +3 -3
Index: linux-2.6/drivers/md/dm-integrity.c
===================================================================
@@ -178,7 +178,7 @@ struct dm_integrity_c {
 	__u8 sectors_per_block;
 
 	unsigned char mode;
-	bool suspending;
+	int suspending;
 
 	int failed;
 

@@ -2210,7 +2210,7 @@ static void dm_integrity_postsuspend(str
 
 	del_timer_sync(&ic->autocommit_timer);
 
-	ic->suspending = true;
+	WRITE_ONCE(ic->suspending, 1);
 
 	queue_work(ic->commit_wq, &ic->commit_work);
 	drain_workqueue(ic->commit_wq);

@@ -2220,7 +2220,7 @@ static void dm_integrity_postsuspend(str
 		dm_integrity_flush_buffers(ic);
 	}
 
-	ic->suspending = false;
+	WRITE_ONCE(ic->suspending, 0);
 
 	BUG_ON(!RB_EMPTY_ROOT(&ic->in_progress));