Skip to contentSkip to conversation

imx-usb-loader: propagate libusb dependency

PATCH New Baruch Siach 2 participants 2 messages Jun 6, 2018 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx-usb-loader: propagate libusb dependency

Avoid select of libusb when the toolchain does not support threads.

Fixes:
http://autobuild.buildroot.net/results/a21/a212ee3e5ec174f4e6e7d582f777325dac035bfd/

---
 package/imx-usb-loader/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/imx-usb-loader/Config.in +4 -0
index 6f083f34d12a..1cc0dd8c25e7 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_IMX_USB_LOADER
 	bool "imx-usb-loader"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
 	select BR2_PACKAGE_LIBUSB
 	help
 	  This package contains tools to download and execute code
@@ -7,3 +8,6 @@ config BR2_PACKAGE_IMX_USB_LOADER
 	  Serial Download Protocol.
 
 	  https://github.com/boundarydevices/imx_usb_loader
+
+comment "imx-usb-loader needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 imx-usb-loader: propagate libusb dependency

Hello,

Quoted 10 lines · Baruch Siach

Avoid select of libusb when the toolchain does not support threads.

Fixes:
http://autobuild.buildroot.net/results/a21/a212ee3e5ec174f4e6e7d582f777325dac035bfd/

---
 package/imx-usb-loader/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

I'm wondering how I could have missed that during the review. Thanks for pointing it out and proposing a patch to fix it! Applied!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com