Skip to contentSkip to conversation

block: always set partition number to '0' in blk_partition_remap()

PATCH In review Hannes Reinecke 5 participants 5 messages Jun 7, 2018

Subsystems (2)
Block layer NVMe
lore
Share & tools
lore

Hannes Reinecke

author
#0 lore raw

PATCH v2 1/1 block: always set partition number to '0' in blk_partition_remap()

blk_partition_remap() will only clear bi_partno if an actual remapping has happened. But flush request et al don't have an actual size, so the remapping doesn't happen and bi_partno is never cleared. So for stacked devices blk_partition_remap() will be called on each level. If (as is the case for native nvme multipathing) one of the lower-level devices do _not_support partitioning a spurious I/O error is generated.

Signed-off-by Hannes Reinecke <[email protected]>
---
 block/blk-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-core.c +1 -1
index 3f56be15f17e..cf0ee764b908 100644
@@ -2220,10 +2220,10 @@ static inline int blk_partition_remap(struct bio *bio)
 		if (bio_check_eod(bio, part_nr_sects_read(p)))
 			goto out;
 		bio->bi_iter.bi_sector += p->start_sect;
-		bio->bi_partno = 0;
 		trace_block_bio_remap(bio->bi_disk->queue, bio, part_devt(p),
 				      bio->bi_iter.bi_sector - p->start_sect);
 	}
+	bio->bi_partno = 0;
 	ret = 0;
 out:
 	rcu_read_unlock();
Signature · 1 line
2.12.3
Reviewed-by on v2 1/1
#1 lore raw

Looks good,

Reviewed-by Johannes Thumshirn <[email protected]>
Signature · 6 lines
Johannes Thumshirn                                          Storage
[email protected]                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
maintainer Reviewed-by on v2 1/1
#3 lore raw
In reply to Hannes Reinecke
Quoted 8 lines · Hannes Reinecke

blk_partition_remap() will only clear bi_partno if an actual remapping has happened. But flush request et al don't have an actual size, so the remapping doesn't happen and bi_partno is never cleared. So for stacked devices blk_partition_remap() will be called on each level. If (as is the case for native nvme multipathing) one of the lower-level devices do _not_support partitioning a spurious I/O error is generated.

Signed-off-by Hannes Reinecke <[email protected]>

Looks good,

Reviewed-by Christoph Hellwig <[email protected]>
maintainer
#4 lore raw
In reply to Hannes Reinecke
Quoted 6 lines · Hannes Reinecke

blk_partition_remap() will only clear bi_partno if an actual remapping has happened. But flush request et al don't have an actual size, so the remapping doesn't happen and bi_partno is never cleared. So for stacked devices blk_partition_remap() will be called on each level. If (as is the case for native nvme multipathing) one of the lower-level devices do _not_support partitioning a spurious I/O error is generated.

That's better, applied.

Signature · 1 line
Jens Axboe