syscalls/ipc: Rename some msgctl tests
RFC PATCH 1/1 syscalls/ipc: Rename some msgctl tests
The test from msgctl08 to msgctl11 are actually msg stress tests, these do not actually call msgctl() during the test but rather than that they fork large number of processes and send message around. Renaming them to msgstress seems to be more fitting.
---
runtest/ltplite | 4 +--
runtest/stress.part3 | 4 +--
runtest/syscalls | 8 +++---
runtest/syscalls-ipc | 8 +++---
testcases/kernel/syscalls/ipc/msgctl/.gitignore | 4 ---
testcases/kernel/syscalls/ipc/msgstress/.gitignore | 4 +++
testcases/kernel/syscalls/ipc/msgstress/Makefile | 29 ++++++++++++++++++++++
.../{msgctl/msgctl08.c => msgstress/msgstress01.c} | 0
.../{msgctl/msgctl09.c => msgstress/msgstress02.c} | 0
.../{msgctl/msgctl10.c => msgstress/msgstress03.c} | 0
.../{msgctl/msgctl11.c => msgstress/msgstress04.c} | 0
11 files changed, 45 insertions(+), 16 deletions(-)
create mode 100644 testcases/kernel/syscalls/ipc/msgstress/.gitignore
create mode 100644 testcases/kernel/syscalls/ipc/msgstress/Makefile
rename testcases/kernel/syscalls/ipc/{msgctl/msgctl08.c => msgstress/msgstress01.c} (100%)
rename testcases/kernel/syscalls/ipc/{msgctl/msgctl09.c => msgstress/msgstress02.c} (100%)
rename testcases/kernel/syscalls/ipc/{msgctl/msgctl10.c => msgstress/msgstress03.c} (100%)
rename testcases/kernel/syscalls/ipc/{msgctl/msgctl11.c => msgstress/msgstress04.c} (100%)runtest/ltplite +2 -2
@@ -487,8 +487,8 @@ msgctl04 msgctl04 msgctl05 msgctl05 msgctl06 msgctl06 msgctl07 msgctl07 -msgctl08 msgctl08 -msgctl09 msgctl09 +msgstress01 msgstress01 +msgstress02 msgstress02 msgget01 msgget01 msgget02 msgget02
runtest/stress.part3 +2 -2
@@ -403,8 +403,8 @@ msgctl04 msgctl04 msgctl05 msgctl05 msgctl06 msgctl06 msgctl07 msgctl07 -msgctl08 msgctl08 -msgctl09 msgctl09 +msgstress01 msgstress01 +msgstress02 msgstress02 msgget01 msgget01 msgget02 msgget02
runtest/syscalls +4 -4
@@ -693,10 +693,10 @@ msgctl04 msgctl04 msgctl05 msgctl05 msgctl06 msgctl06 msgctl07 msgctl07 -msgctl08 msgctl08 -msgctl09 msgctl09 -msgctl10 msgctl10 -msgctl11 msgctl11 +msgstress01 msgstress01 +msgstress02 msgstress02 +msgstress03 msgstress03 +msgstress04 msgstress04 msgctl12 msgctl12 msgctl13 msgctl13
runtest/syscalls-ipc +4 -4
@@ -5,10 +5,10 @@ msgctl04 msgctl04 msgctl05 msgctl05 msgctl06 msgctl06 msgctl07 msgctl07 -msgctl08 msgctl08 -msgctl09 msgctl09 -msgctl10 msgctl10 -msgctl11 msgctl11 +msgstress01 msgstress01 +msgstress02 msgstress02 +msgstress03 msgstress03 +msgstress04 msgstress04 msgctl12 msgctl12 msgctl13 msgctl13
testcases/kernel/syscalls/ipc/msgctl/.gitignore +0 -4
@@ -5,9 +5,5 @@ /msgctl05 /msgctl06 /msgctl07 -/msgctl08 -/msgctl09 -/msgctl10 -/msgctl11 /msgctl12 /msgctl13
testcases/kernel/syscalls/ipc/msgstress/.gitignore new file +4 -0
@@ -0,0 +1,4 @@ +/msgstress01 +/msgstress02 +/msgstress03 +/msgstress04
testcases/kernel/syscalls/ipc/msgstress/Makefile new file +29 -0
@@ -0,0 +1,29 @@ +# +# Copyright (c) International Business Machines Corp., 2001 +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See +# the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# + +top_srcdir ?= ../../../../.. + +include $(top_srcdir)/include/mk/testcases.mk + +LIBMSGCTL := $(LIBDIR)/libmsgctl.a +LDLIBS += -lmsgctl + +MAKE_DEPS := $(LIBMSGCTL) + +include $(abs_srcdir)/../Makefile.inc +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/ipc/msgstress/msgstress01.c renamed from testcases/kernel/syscalls/ipc/msgctl/msgctl08.c +0 -0
testcases/kernel/syscalls/ipc/msgstress/msgstress02.c renamed from testcases/kernel/syscalls/ipc/msgctl/msgctl09.c +0 -0
testcases/kernel/syscalls/ipc/msgstress/msgstress03.c renamed from testcases/kernel/syscalls/ipc/msgctl/msgctl10.c +0 -0
testcases/kernel/syscalls/ipc/msgstress/msgstress04.c renamed from testcases/kernel/syscalls/ipc/msgctl/msgctl11.c +0 -0
Signature · 1 line
2.13.6
RFC PATCH 1/1 syscalls/ipc: Rename some msgctl tests
Quoted 5 lines · Cyril Hrubis
The test from msgctl08 to msgctl11 are actually msg stress tests, these do not actually call
msgctl()during the test but rather than that they fork large number of processes and send message around. Renaming them to msgstress seems to be more fitting.
Agreed. These tests fork too many times, and they often trigger OOM at runtime. So I think this patch make sense.
​
Another thought of mine is that to remove them from the ltplite and syscalls runtest file. what about just putting them in stress.part3?
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20180607/a6cefd8d/attachment.html>
RFC PATCH 1/1 syscalls/ipc: Rename some msgctl tests
Hi!
Quoted 5 lines
Agreed. These tests fork too many times, and they often trigger OOM at runtime. So I think this patch make sense.
???
Another thought of mine is that to remove them from the ltplite and syscalls runtest file. what about just putting them in stress.part3?
These shouldn't be part of ltplite for sure, I will remove them in a follow up patch. I would like to keep them in the syscalls runtest file though and make sure that they scale better accordingly to system RAM/CPUs later on.
Signature · 2 lines
Cyril Hrubis [email protected]
RFC PATCH 1/1 syscalls/ipc: Rename some msgctl tests
Quoted 7 lines · Cyril Hrubis
Hi!
Quoted 5 lines
Agreed. These tests fork too many times, and they often trigger OOM at runtime. So I think this patch make sense.
???
Another thought of mine is that to remove them from the ltplite and syscalls runtest file. what about just putting them in stress.part3?
Quoted 5 lines
These shouldn't be part of ltplite for sure, I will remove them in a follow up patch. I would like to keep them in the syscalls runtest file though and make sure that they scale better accordingly to system RAM/CPUs later on.
Great. It sounds good to adjust their fork numbers according to the system config.
Quoted 4 lines
--
Cyril Hrubis
[email protected]
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20180607/faff90da/attachment.html>
RFC PATCH 1/1 syscalls/ipc: Rename some msgctl tests
In reply to Li WangHi!
Pushed the patch with your ackq, as well as removal from the ltplite runtest file, thanks.
Signature · 2 lines
Cyril Hrubis [email protected]