Skip to contentSkip to conversation

blktrace: display failfast and driver-specific flags

PATCH In review Hannes Reinecke 2 participants 3 messages Jun 7, 2018 – Jun 8, 2018

Subsystems (3)
Block layer Tracing NVMe
lore
Share & tools
lore

Hannes Reinecke

author
#0 lore raw

PATCH 1/1 blktrace: display failfast and driver-specific flags

Signed-off-by Hannes Reinecke <[email protected]>
---
 kernel/trace/blktrace.c | 8 ++++++++
 1 file changed, 8 insertions(+)
kernel/trace/blktrace.c +8 -0
index 987d9a9ae283..238e16211a5c 100644
@@ -1922,6 +1922,14 @@ void blk_fill_rwbs(char *rwbs, unsigned int op, int bytes)
 		rwbs[i++] = 'S';
 	if (op & REQ_META)
 		rwbs[i++] = 'M';
+	if (op & REQ_FAILFAST_DEV)
+		rwbs[i++] = 'd';
+	if (op & REQ_FAILFAST_TRANSPORT)
+		rwbs[i++] = 't';
+	if (op & REQ_FAILFAST_DRIVER)
+		rwbs[i++] = 'v';
+	if (op & REQ_DRV)
+		rwbs[i++] = 'V';
 
 	rwbs[i] = '\0';
 }
Signature · 1 line
2.12.3
maintainer
#1 lore raw

Good idea to display the flags, but the characters aren't really very self-describing. Should we prefix each with an f maybe?

author
#2 lore raw
Quoted 2 lines · On Thu, 7 Jun 2018 13:24:23 +0200 Christoph Hellwig <[email protected]> wrote:

Good idea to display the flags, but the characters aren't really very self-describing. Should we prefix each with an f maybe?

Honestly, I don't care.
Just wanted to stick with the one-letter acronym like all the others did.
But in the end having the failfast ones prefixed with an 'f' sounds reasonable.

Cheers,

Hannes