Skip to contentSkip to conversation

sna/video/sprite: Remove the XV_ALWAYS_ON_TOP restriction for SKL+ scaling

PATCH In review Ville Syrjala 2 participants 2 messages Jun 8, 2018 – Jun 9, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sna/video/sprite: Remove the XV_ALWAYS_ON_TOP restriction for SKL+ scaling

From: Ville Syrjälä <[email protected]>

On SKL+ the dst colorkey is enabled on the primary plane instead of the sprite plane. That means the restriction of scaling vs. keying doesn't actually apply here as we never scale the primary. So let's remove the requirement of having XV_ALWAYS_ON_TOP enabled to get hw scaling.

---
 src/sna/sna_video_sprite.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/sna/sna_video_sprite.c +1 -1
index f713abcb9151..8b7ae8ae9e75 100644
@@ -49,7 +49,7 @@
 #define DRM_FORMAT_NV12         fourcc_code('N', 'V', '1', '2') /* 2x2 subsampled Cr:Cb plane */
 
 #define has_hw_scaling(sna, video) ((sna)->kgem.gen < 071 || \
-				    ((sna)->kgem.gen >= 0110 && (video)->AlwaysOnTop))
+				    (sna)->kgem.gen >= 0110)
 
 
 #define LOCAL_IOCTL_MODE_SETPLANE	DRM_IOWR(0xB7, struct local_mode_set_plane)
Signature · 6 lines
2.16.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Quoting Ville Syrjala (2018-06-08 20:28:35)

Quoted 8 lines

From: Ville Syrjälä <[email protected]>

On SKL+ the dst colorkey is enabled on the primary plane instead of the sprite plane. That means the restriction of scaling vs. keying doesn't actually apply here as we never scale the primary. So let's remove the requirement of having XV_ALWAYS_ON_TOP enabled to get hw scaling.

Ok :) Pushed,
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx