Qualcomm SMEM driver

This is a simple uclass for SOC drivers.
It is intend to serve as uclass for SOC specific drivers that don't fall into any other uclass catagories. Currently, it doesn't define any special ops.

Signed-off-by Ramon Fried <[email protected]>

This is a simple uclass for SOC drivers.
It is intend to serve as uclass for SOC specific drivers that don't fall into any other uclass catagories. Currently, it doesn't define any special ops.

Signed-off-by Ramon Fried <[email protected]>

---

 drivers/soc/Makefile     | 1 +
 drivers/soc/soc-uclass.c | 8 ++++++++
 include/dm/uclass-id.h   | 1 +
 3 files changed, 10 insertions(+)
 create mode 100644 drivers/soc/soc-uclass.c

The Shared Memory Manager driver implements an interface for allocating and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Quoted 5 lines · Ramon Fried

The Shared Memory Manager driver implements an interface for allocating and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Please, run scripts/checkpatch on this patch an fix all errors and warnings, e.g.

WARNING: line over 80 characters
#1064: FILE: drivers/soc/qualcomm/smem.c:846:
+ smem->regions[i].virt_base = devm_ioremap(dev, r.start,
fdt_resource_size(&r));

CHECK: Alignment should match open parenthesis
#1098: FILE: drivers/soc/qualcomm/smem.c:880:

drivers/soc/qualcomm/smem.c new file +2 -0

+       if (num_regions > 1 && (ret = qcom_smem_map_memory(smem, dev,
+                                       "qcom,rpm-msg-ram", 1)))

Do not use DOS line endings.

Best regards

Heinrich Schuchardt

Quoted 7 lines · Heinrich Schuchardt

Quoted 5 lines · Ramon Fried

The Shared Memory Manager driver implements an interface for allocating and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Quoted 2 lines

Please, run scripts/checkpatch on this patch an fix all errors and warnings, e.g.

Hi Heinrich,
Actually I did run it, and I also run it in Linux and got the same results. I thought it will be better to keep the driver aligned to Linux than to fix these warnings.
But if can surely fix it, what do you suggest ?

Quoted 1 line · Ramon Fried

On Sat, Jun 9, 2018 at 1:12 PM, Heinrich Schuchardt

Quoted 2 lines · <[email protected]> wrote:

Quoted 2 lines · Ramon Fried

Quoted 1 line

The Shared Memory Manager driver implements an interface for

allocating

Quoted 9 lines

Quoted 7 lines

Quoted 4 lines

and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Please, run scripts/checkpatch on this patch an fix all errors and warnings, e.g.

Hi Heinrich,
Actually I did run it, and I also run it in Linux and got the same

results.

Quoted 3 lines

I thought it will be better to keep the driver aligned to Linux than to fix these warnings.
But if can surely fix it, what do you suggest ?

At least add a comment in the commit message why you diverge from our coding standard.

As Mateusz will be the maintainer he should decide.

Best regards

Heinrich

The Shared Memory Manager driver implements an interface for allocating and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Changes from the original Linux driver:
* Removed HW spinlock mechanism, which is irrelevant
in U-boot particualar use case, which is just reading from the smem.
* adaptaion from Linux driver model to U-boot's.

Cc Bjorn Andersson <[email protected]>

Signed-off-by Ramon Fried <[email protected]>

---

Quoted 6 lines · Ramon Fried

The Shared Memory Manager driver implements an interface for allocating and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Quoted 9 lines

Changes from the original Linux driver:
* Removed HW spinlock mechanism, which is irrelevant
in U-boot particualar use case, which is just reading from the smem.
* adaptaion from Linux driver model to U-boot's.

Cc Bjorn Andersson <[email protected]>

Signed-off-by Ramon Fried <[email protected]>

---

<snip />

drivers/soc/qualcomm/smem.c line 349

Quoted 8 lines

drivers/soc/qualcomm/smem.c new file +8 -0

+/* Pointer to the one and only smem handle */
+static struct qcom_smem *__smem;
+
+static int qcom_smem_alloc_private(struct qcom_smem *smem,
+                                struct smem_partition_header *phdr,
+                                unsigned item,
+                                size_t size)
+{

<snip />

drivers/soc/qualcomm/smem.c line 391

Quoted 3 lines

drivers/soc/qualcomm/smem.c new file +3 -0

+      */
+     dmb();
+     le32_add_cpu(&phdr->offset_free_uncached, alloc_size);

drivers/soc/qualcomm/smem.c: In function ‘qcom_smem_alloc_private’:
drivers/soc/qualcomm/smem.c:391:2: warning: implicit declaration of function ‘le32_add_cpu’ [-Wimplicit-function-declaration]
le32_add_cpu(&phdr->offset_free_uncached, alloc_size);

Please, add the missing definition to ./include/linux/byteorder/generic.h
or reference the prerequisite patch in the commit message.

Best regards

Heinrich

The Shared Memory Manager driver implements an interface for allocating and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Changes from the original Linux driver:
* Removed HW spinlock mechanism, which is irrelevant
in U-boot particualar use case, which is just reading from the smem.
* adaptaion from Linux driver model to U-boot's.

Cc Bjorn Andersson <[email protected]>

Signed-off-by Ramon Fried <[email protected]>

---

 MAINTAINERS                   |   1 +
 arch/arm/Kconfig              |   1 +
 drivers/Kconfig               |   2 +
 drivers/soc/Kconfig           |   5 +
 drivers/soc/Makefile          |   1 +
 drivers/soc/qualcomm/Kconfig  |  11 +
 drivers/soc/qualcomm/Makefile |   3 +
 drivers/soc/qualcomm/smem.c   | 934 ++++++++++++++++++++++++++++++++++
 8 files changed, 958 insertions(+)
 create mode 100644 drivers/soc/Kconfig
 create mode 100644 drivers/soc/qualcomm/Kconfig
 create mode 100644 drivers/soc/qualcomm/Makefile
 create mode 100644 drivers/soc/qualcomm/smem.c

Hi Ramon,

Quoted 15 lines · Ramon Fried

The Shared Memory Manager driver implements an interface for allocating and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Changes from the original Linux driver:
* Removed HW spinlock mechanism, which is irrelevant
in U-boot particualar use case, which is just reading from the smem.
* adaptaion from Linux driver model to U-boot's.

Cc Bjorn Andersson <[email protected]>

Signed-off-by Ramon Fried <[email protected]>

---

Quoted 13 lines

 MAINTAINERS                   |   1 +
 arch/arm/Kconfig              |   1 +
 drivers/Kconfig               |   2 +
 drivers/soc/Kconfig           |   5 +
 drivers/soc/Makefile          |   1 +
 drivers/soc/qualcomm/Kconfig  |  11 +
 drivers/soc/qualcomm/Makefile |   3 +
 drivers/soc/qualcomm/smem.c   | 934 ++++++++++++++++++++++++++++++++++
 8 files changed, 958 insertions(+)
 create mode 100644 drivers/soc/Kconfig
 create mode 100644 drivers/soc/qualcomm/Kconfig
 create mode 100644 drivers/soc/qualcomm/Makefile
 create mode 100644 drivers/soc/qualcomm/smem.c

Sorry, but NAK on this.

This patch supports direct calls into a driver which is not allowed. This should be done through the driver's uclass API, not through direct calls.

Hi Simon,

Regards,
Simon

Quoted 33 lines · Simon Glass

Hi Ramon,

Quoted 15 lines · Ramon Fried

The Shared Memory Manager driver implements an interface for allocating and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Changes from the original Linux driver:
* Removed HW spinlock mechanism, which is irrelevant
in U-boot particualar use case, which is just reading from the smem.
* adaptaion from Linux driver model to U-boot's.

Cc Bjorn Andersson <[email protected]>

Signed-off-by Ramon Fried <[email protected]>

---

Quoted 13 lines

 MAINTAINERS                   |   1 +
 arch/arm/Kconfig              |   1 +
 drivers/Kconfig               |   2 +
 drivers/soc/Kconfig           |   5 +
 drivers/soc/Makefile          |   1 +
 drivers/soc/qualcomm/Kconfig  |  11 +
 drivers/soc/qualcomm/Makefile |   3 +
 drivers/soc/qualcomm/smem.c   | 934 ++++++++++++++++++++++++++++++++++
 8 files changed, 958 insertions(+)
 create mode 100644 drivers/soc/Kconfig
 create mode 100644 drivers/soc/qualcomm/Kconfig
 create mode 100644 drivers/soc/qualcomm/Makefile
 create mode 100644 drivers/soc/qualcomm/smem.c

Quoted 6 lines

Sorry, but NAK on this.

This patch supports direct calls into a driver which is not allowed. This should be done through the driver's uclass API, not through direct calls.

Hi Simon,
I see your point.
As you probably see, I was looking at the DM framework for the convenience it
gives with binding device-tree nodes and drivers.
If it's not an option I'll rewrite it as as arch-code under mach-snapdragon. Thanks,
Ramon.

Hi Ramon,

Quoted 3 lines · Ramon Fried

On Mon, Jun 11, 2018 at 5:53 PM, Simon Glass <[email protected]>

Quoted 5 lines · wrote:

Quoted 5 lines

Hi Ramon,

Quoted 1 line · Ramon Fried

The Shared Memory Manager driver implements an interface for

allocating

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Changes from the original Linux driver:
* Removed HW spinlock mechanism, which is irrelevant in U-boot particualar use case, which is just reading from the

smem.

Quoted 6 lines

Quoted 6 lines

Quoted 6 lines

* adaptaion from Linux driver model to U-boot's.

Cc Bjorn Andersson <[email protected]>

Signed-off-by Ramon Fried <[email protected]>

---

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

 MAINTAINERS                   |   1 +
 arch/arm/Kconfig              |   1 +
 drivers/Kconfig               |   2 +
 drivers/soc/Kconfig           |   5 +
 drivers/soc/Makefile          |   1 +
 drivers/soc/qualcomm/Kconfig  |  11 +
 drivers/soc/qualcomm/Makefile |   3 +
 drivers/soc/qualcomm/smem.c   | 934

++++++++++++++++++++++++++++++++++

Quoted 8 lines

Quoted 8 lines

Quoted 5 lines

 8 files changed, 958 insertions(+)
 create mode 100644 drivers/soc/Kconfig
 create mode 100644 drivers/soc/qualcomm/Kconfig
 create mode 100644 drivers/soc/qualcomm/Makefile
 create mode 100644 drivers/soc/qualcomm/smem.c

Sorry, but NAK on this.

Quoted 7 lines

Quoted 4 lines

This patch supports direct calls into a driver which is not allowed. This should be done through the driver's uclass API, not through direct calls.

Hi Simon,
I see your point.
As you probably see, I was looking at the DM framework for the

convenience

Quoted 3 lines

it
gives with binding device-tree nodes and drivers. If it's not an option I'll rewrite it as as arch-code under

mach-snapdragon.

Quoted 2 lines

Thanks,
Ramon.

You are correct that you should be using driver model. It's that you need to do it fully, with a proper API. There are lots of examples.

Regards,
Simon

Quoted 56 lines · Simon Glass

Hi Ramon,

Quoted 3 lines · Ramon Fried

On Mon, Jun 11, 2018 at 5:53 PM, Simon Glass <[email protected]>

Quoted 5 lines · wrote:

Quoted 5 lines

Hi Ramon,

Quoted 1 line · Ramon Fried

The Shared Memory Manager driver implements an interface for

allocating

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Changes from the original Linux driver:
* Removed HW spinlock mechanism, which is irrelevant in U-boot particualar use case, which is just reading from the

smem.

Quoted 6 lines

Quoted 6 lines

Quoted 6 lines

* adaptaion from Linux driver model to U-boot's.

Cc Bjorn Andersson <[email protected]>

Signed-off-by Ramon Fried <[email protected]>

---

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

 MAINTAINERS                   |   1 +
 arch/arm/Kconfig              |   1 +
 drivers/Kconfig               |   2 +
 drivers/soc/Kconfig           |   5 +
 drivers/soc/Makefile          |   1 +
 drivers/soc/qualcomm/Kconfig  |  11 +
 drivers/soc/qualcomm/Makefile |   3 +
 drivers/soc/qualcomm/smem.c   | 934

++++++++++++++++++++++++++++++++++

Quoted 8 lines

Quoted 8 lines

Quoted 5 lines

 8 files changed, 958 insertions(+)
 create mode 100644 drivers/soc/Kconfig
 create mode 100644 drivers/soc/qualcomm/Kconfig
 create mode 100644 drivers/soc/qualcomm/Makefile
 create mode 100644 drivers/soc/qualcomm/smem.c

Sorry, but NAK on this.

Quoted 7 lines

Quoted 4 lines

This patch supports direct calls into a driver which is not allowed. This should be done through the driver's uclass API, not through direct calls.

Hi Simon,
I see your point.
As you probably see, I was looking at the DM framework for the

convenience

Quoted 3 lines

it
gives with binding device-tree nodes and drivers. If it's not an option I'll rewrite it as as arch-code under

Quoted 7 lines

mach-snapdragon.

Quoted 2 lines

Thanks,
Ramon.

You are correct that you should be using driver model. It's that you need to do it fully, with a proper API. There are lots of examples.

Doesn't it make sense to add some facility for drivers that don't export common functionalities. Like Linux platform drivers?

Hi Ramon,

Quoted 1 line · Ramon Fried

On June 11, 2018 10:38:45 PM GMT+03:00, Simon Glass

Quoted 11 lines · <[email protected]> wrote:

Quoted 11 lines

Hi Ramon,

Quoted 3 lines · Ramon Fried

On Mon, Jun 11, 2018 at 5:53 PM, Simon Glass <[email protected]>

Quoted 4 lines · wrote:

Quoted 4 lines

Hi Ramon,

On 9 June 2018 at 03:06, Ramon Fried <[email protected]>

Quoted 32 lines · wrote:

Quoted 32 lines

Quoted 1 line

Quoted 1 line

Quoted 1 line

The Shared Memory Manager driver implements an interface for

allocating

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

and accessing items in the memory area shared among all of the processors in a Qualcomm platform.

Adapted from the Linux driver (4.17)

Changes from the original Linux driver:
* Removed HW spinlock mechanism, which is irrelevant in U-boot particualar use case, which is just reading from the

smem.

Quoted 6 lines

Quoted 6 lines

Quoted 6 lines

* adaptaion from Linux driver model to U-boot's.

Cc Bjorn Andersson <[email protected]>

Signed-off-by Ramon Fried <[email protected]>

---

Quoted 8 lines

Quoted 8 lines

Quoted 8 lines

 MAINTAINERS                   |   1 +
 arch/arm/Kconfig              |   1 +
 drivers/Kconfig               |   2 +
 drivers/soc/Kconfig           |   5 +
 drivers/soc/Makefile          |   1 +
 drivers/soc/qualcomm/Kconfig  |  11 +
 drivers/soc/qualcomm/Makefile |   3 +
 drivers/soc/qualcomm/smem.c   | 934

++++++++++++++++++++++++++++++++++

Quoted 6 lines

Quoted 6 lines

Quoted 5 lines

 8 files changed, 958 insertions(+)
 create mode 100644 drivers/soc/Kconfig
 create mode 100644 drivers/soc/qualcomm/Kconfig
 create mode 100644 drivers/soc/qualcomm/Makefile
 create mode 100644 drivers/soc/qualcomm/smem.c

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

Quoted 3 lines

Sorry, but NAK on this.

This patch supports direct calls into a driver which is not

allowed.

Quoted 10 lines

Quoted 10 lines

Quoted 6 lines

Quoted 3 lines

This should be done through the driver's uclass API, not through direct calls.

Hi Simon,
I see your point.
As you probably see, I was looking at the DM framework for the

convenience

Quoted 3 lines

it
gives with binding device-tree nodes and drivers. If it's not an option I'll rewrite it as as arch-code under

Quoted 8 lines

Quoted 7 lines

mach-snapdragon.

Quoted 2 lines

Thanks,
Ramon.

You are correct that you should be using driver model. It's that you need to do it fully, with a proper API. There are lots of examples.

Doesn't it make sense to add some facility for drivers that don't

export common functionalities. Like Linux platform drivers?

Well this is how things used to work in U-Boot before driver model.

Now we are trying to move things to driver model.

It does not look like you have many calls, so it should be easy enough to move it to a uclass.

You can also add a command to access the device. People can see the tree of devices with 'dm tree', etc.

Regards,
Simon