Skip to contentSkip to conversation

adding-packages-cargo.txt: remove host-cargo select

PATCH New Fabrice Fontaine 2 participants 3 messages Jun 7, 2018 – Jun 10, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 adding-packages-cargo.txt: remove host-cargo select

Remove select BR2_PACKAGE_HOST_CARGO from Config.in

---
 docs/manual/adding-packages-cargo.txt | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
docs/manual/adding-packages-cargo.txt +4 -5
index b7fc09acfe..8ef8fc08f4 100644
@@ -18,11 +18,10 @@ The +Config.in+ file of Cargo-based package 'foo' should contain:
 01: config BR2_PACKAGE_FOO
 02: 	bool "foo"
 03: 	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
-04: 	select BR2_PACKAGE_HOST_CARGO
-05: 	help
-06: 	  This is a comment that explains what foo is.
-07:
-08: 	  http://foosoftware.org/foo/
+04: 	help
+05: 	  This is a comment that explains what foo is.
+06:
+07: 	  http://foosoftware.org/foo/
 ---------------------------
 
 ==== Cargo-based package's +.mk+ file
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 adding-packages-cargo.txt: remove host-cargo select

Hello,

Quoted 3 lines · Fabrice Fontaine

Remove select BR2_PACKAGE_HOST_CARGO from Config.in

In fact, I don't agree with this change. Cargo packages are going to use host-cargo, so it makes sense for them to select.

Today, it is not mandatory for a host package to be selected at the Config.in level to have it built, and we don't enforce this. But it is actually more logical to do it, and in line with our long-term idea of having Config.in options for all host packages.

So, in fact I prefer your original patch, and I disagree with Baruch statement that we shouldn't do the select. Yes, it is not /needed/, but it is more correct with the select.

Best regards,

Thoms

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 adding-packages-cargo.txt: remove host-cargo select

Dear Thomas,

2018-06-10 15:01 GMT+02:00 Thomas Petazzoni <[email protected]>:

Quoted 10 lines

Hello,

Quoted 3 lines · Fabrice Fontaine

Remove select BR2_PACKAGE_HOST_CARGO from Config.in

In fact, I don't agree with this change. Cargo packages are going to use host-cargo, so it makes sense for them to select.

Quoted 9 lines

Today, it is not mandatory for a host package to be selected at the Config.in level to have it built, and we don't enforce this. But it is actually more logical to do it, and in line with our long-term idea of having Config.in options for all host packages.

So, in fact I prefer your original patch, and I disagree with Baruch statement that we shouldn't do the select. Yes, it is not /needed/, but it is more correct with the select.

OK, so I will send a v3 of my patch's serie.

Quoted 9 lines

Best regards,

Thoms
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180610/daa33b6c/attachment.html>