Skip to contentSkip to conversation

gpio: omap_gpio: Name GPIO's by bank and index with DM_GPIO

PATCH In review Adam Ford 2 participants 2 messages Jun 12, 2018 – Jun 19, 2018 GPIO

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 gpio: omap_gpio: Name GPIO's by bank and index with DM_GPIO

There are multiple GPIO banks with up to 32 pins / bank. When using 'gpio status -a' to read the pins, this patch displays both GPIO<bank>_<index> similar to how the device trees display in addition to displaying gpio_#

drivers/gpio/omap_gpio.c +8 -2
index 4d54df284d..651f6994e4 100644
@@ -288,11 +288,17 @@ static int omap_gpio_probe(struct udevice *dev)
 	struct gpio_bank *bank = dev_get_priv(dev);
 	struct omap_gpio_platdata *plat = dev_get_platdata(dev);
 	struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
+	int banknum;
+	char name[18], *str;
 
-	uc_priv->bank_name = plat->port_name;
+	banknum = plat->bank_index;
+	sprintf(name, "GPIO%d_", banknum + 1);
+	str = strdup(name);
+	if (!str)
+		return -ENOMEM;
+	uc_priv->bank_name = str;
 	uc_priv->gpio_count = GPIO_PER_BANK;
 	bank->base = (void *)plat->base;
-
 	return 0;
 }
 
Signature · 1 line
2.17.1
#1 lore raw

drivers/gpio/omap_gpio.c

Quoted 9 lines · Adam Ford

There are multiple GPIO banks with up to 32 pins / bank. When using 'gpio status -a' to read the pins, this patch displays both GPIO<bank>_<index> similar to how the device trees display in addition to displaying gpio_#

drivers/gpio/omap_gpio.c +0 -0
index 4d54df284d..651f6994e4 100644

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180619/571d28bf/attachment.sig>