resource: Use list_head to link sibling resource
Subsystems (19)
v5 cover resource: Use list_head to link sibling resource
This patchset is doing:
1) Replace struct resource's sibling list from singly linked list to list_head. Clearing out those pointer operation within singly linked list for better code readability.
2) Based on list_head replacement, add a new function walk_system_ram_res_rev() which can does reversed iteration on iomem_resource's siblings.
3) Change kexec_file loading to search system RAM top down for kernel loadin, using walk_system_ram_res_rev().
Note:
This patchset passed testing on my kvm guest, x86_64 arch with network enabling. The thing we need pay attetion to is that a root resource's child member need be initialized specifically with LIST_HEAD_INIT() if statically defined or INIT_LIST_HEAD() for dynamically definition. Here Just like we do for iomem_resource/ioport_resource, or the change in get_pci_domain_busn_res().
Links of the old post (Boris pointed out that we should use
https://lkml.kernel.org/r/Message-ID, while it can't be opened from my side, so paste all of them here.):
v4:
https://lkml.kernel.org/r/20180507063224.24229-1-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
https://lkml.org/lkml/2018/5/7/36
v3:
https://lkml.kernel.org/r/20180419001848.3041-1-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
https://lkml.org/lkml/2018/4/18/767
v2:
https://lkml.kernel.org/r/20180408024724.16812-1-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
https://lkml.org/lkml/2018/4/7/169
v1:
https://lkml.kernel.org/r/20180322033722.9279-1-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
https://lkml.org/lkml/2018/3/21/952
Changelog:v4->v5:
Add new patch 0001 to move duplicated reparent_resources() to kernel/resource.c to make it be shared by different ARCH-es.
Fix several code bugs reported by test robot on ARCH powerpc and microblaze.v3->v4:
Fix several bugs test robot reported. Rewrite cover letter and patch log according to reviewer's comment.
v2->v3:
Rename resource functions first_child() and sibling() to resource_first_chils() and resource_sibling(). Dan suggested this.
Move resource_first_chils() and resource_sibling() to linux/ioport.h and make them as inline function. Rob suggested this. Accordingly add linux/list.h including in linux/ioport.h, please help review if this bring efficiency degradation or code redundancy.
The change on struct resource {} bring two pointers of size increase, mention this in git log to make it more specifically, Rob suggested this.
v1->v2:
Use list_head instead to link resource siblings. This is suggested by Andrew.
Rewrite walk_system_ram_res_rev() after list_head is taken to link resouce siblings.
Baoquan He (4):
resource: Move reparent_resources() to kernel/resource.c and make it
public
resource: Use list_head to link sibling resource
resource: add walk_system_ram_res_rev()
kexec_file: Load kernel at top of system RAM if required
arch/arm/plat-samsung/pm-check.c | 6 +- arch/microblaze/pci/pci-common.c | 41 +---- arch/powerpc/kernel/pci-common.c | 39 +---- arch/sparc/kernel/ioport.c | 2 +- arch/xtensa/include/asm/pci-bridge.h | 4 +- drivers/eisa/eisa-bus.c | 2 + drivers/gpu/drm/drm_memory.c | 3 +- drivers/gpu/drm/gma500/gtt.c | 5 +- drivers/hv/vmbus_drv.c | 52 +++--- drivers/input/joystick/iforce/iforce-main.c | 4 +- drivers/nvdimm/namespace_devs.c | 6 +- drivers/nvdimm/nd.h | 5 +- drivers/of/address.c | 4 +- drivers/parisc/lba_pci.c | 4 +- drivers/pci/host/vmd.c | 8 +- drivers/pci/probe.c | 2 + drivers/pci/setup-bus.c | 2 +- include/linux/ioport.h | 21 ++- kernel/kexec_file.c | 2 + kernel/resource.c | 259 ++++++++++++++++++---------- 20 files changed, 244 insertions(+), 227 deletions(-)
Signature · 1 line
2.13.6
PATCH v5 1/4 resource: Move reparent_resources() to kernel/resource.c and make it public
reparent_resources() is duplicated in arch/microblaze/pci/pci-common.c and arch/powerpc/kernel/pci-common.c, so move it to kernel/resource.c so that it's shared. Later its code also need be updated using list_head to replace singly linked list.
---v4->v5:
Fix several code bugs reported by test robot on ARCH powerpc and microblaze.
v3->v4:
Fix several bugs test robot reported. And change patch log.
v2->v3:
Rename resource functions first_child() and sibling() to resource_first_chils() and resource_sibling(). Dan suggested this.
Move resource_first_chils() and resource_sibling() to linux/ioport.h and make them as inline function. Rob suggested this. Accordingly add linux/list.h including in linux/ioport.h, please help review if this bring efficiency degradation or code redundancy.
The change on struct resource {} bring two pointers of size increase, mention this in git log to make it more specifically, Rob suggested this.
arch/microblaze/pci/pci-common.c | 37 ------------------------------------- arch/powerpc/kernel/pci-common.c | 35 ----------------------------------- include/linux/ioport.h | 1 + kernel/resource.c | 36 ++++++++++++++++++++++++++++++++++++ 4 files changed, 37 insertions(+), 72 deletions(-)
arch/microblaze/pci/pci-common.c +0 -37
@@ -619,43 +619,6 @@ int pcibios_add_device(struct pci_dev *dev)EXPORT_SYMBOL (pcibios_add_device);/* -* Reparent resource children of pr that conflict with res -* under res, and make res replace those children. -*/ -static int __init reparent_resources (struct resource *parent, -struct resource *res) -{ -struct resource *p, **pp; -struct resource **firstpp =NULL ; - -for (pp = &parent->child; (p = *pp) !=NULL ; pp = &p->sibling) { -if (p->end < res->start) -continue ; -if (res->end < p->start) -break ; -if (p->start < res->start || p->end > res->end) -return -1 ;/* not completely contained */ -if (firstpp ==NULL ) - firstpp = pp; - } -if (firstpp ==NULL ) -return -1 ;/* didn't find any conflicting entries? */ - res->parent = parent; - res->child = *firstpp; - res->sibling = *pp; - *firstpp = res; - *pp =NULL ; -for (p = res->child; p !=NULL ; p = p->sibling) { - p->parent = res; -pr_debug ("PCI: Reparented %s [%llx..%llx] under %s\n" , - p->name, - (unsigned long long )p->start, - (unsigned long long )p->end, res->name); - } -return 0 ; -} - -/* * Handle resources of PCI devices. If the world were perfect, we could * just allocate all the resource regions and do nothing more. It isn't. * On the other hand, we cannot just re-allocate all devices, as it would
arch/powerpc/kernel/pci-common.c +0 -35
@@ -1088,41 +1088,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,EXPORT_SYMBOL (pcibios_align_resource);/* -* Reparent resource children of pr that conflict with res -* under res, and make res replace those children. -*/ -static int reparent_resources (struct resource *parent, -struct resource *res) -{ -struct resource *p, **pp; -struct resource **firstpp =NULL ; - -for (pp = &parent->child; (p = *pp) !=NULL ; pp = &p->sibling) { -if (p->end < res->start) -continue ; -if (res->end < p->start) -break ; -if (p->start < res->start || p->end > res->end) -return -1 ;/* not completely contained */ -if (firstpp ==NULL ) - firstpp = pp; - } -if (firstpp ==NULL ) -return -1 ;/* didn't find any conflicting entries? */ - res->parent = parent; - res->child = *firstpp; - res->sibling = *pp; - *firstpp = res; - *pp =NULL ; -for (p = res->child; p !=NULL ; p = p->sibling) { - p->parent = res; -pr_debug ("PCI: Reparented %s %pR under %s\n" , - p->name, p, res->name); - } -return 0 ; -} - -/* * Handle resources of PCI devices. If the world were perfect, we could * just allocate all the resource regions and do nothing more. It isn't. * On the other hand, we cannot just re-allocate all devices, as it would
include/linux/ioport.h +1 -0
@@ -192,6 +192,7 @@ extern int allocate_resource(struct resource *root, struct resource *new,struct resource *lookup_resource (struct resource *root,resource_size_t start);int adjust_resource (struct resource *res,resource_size_t start,resource_size_t size); +int reparent_resources (struct resource *parent,struct resource *res);resource_size_t resource_alignment (struct resource *res);static inline resource_size_t resource_size (const struct resource *res) {
kernel/resource.c +36 -0
@@ -983,6 +983,42 @@ int adjust_resource(struct resource *res, resource_size_t start, }EXPORT_SYMBOL (adjust_resource); +/* +* Reparent resource children of pr that conflict with res +* under res, and make res replace those children. +*/ +static int reparent_resources (struct resource *parent, +struct resource *res) +{ +struct resource *p, **pp; +struct resource **firstpp =NULL ; + +for (pp = &parent->child; (p = *pp) !=NULL ; pp = &p->sibling) { +if (p->end < res->start) +continue ; +if (res->end < p->start) +break ; +if (p->start < res->start || p->end > res->end) +return -1 ;/* not completely contained */ +if (firstpp ==NULL ) + firstpp = pp; + } +if (firstpp ==NULL ) +return -1 ;/* didn't find any conflicting entries? */ + res->parent = parent; + res->child = *firstpp; + res->sibling = *pp; + *firstpp = res; + *pp =NULL ; +for (p = res->child; p !=NULL ; p = p->sibling) { + p->parent = res; +pr_debug ("PCI: Reparented %s %pR under %s\n" , + p->name, p, res->name); + } +return 0 ; +} +EXPORT_SYMBOL (reparent_resources); +static void __init __reserve_region_with_split (struct resource *root,resource_size_t start,resource_size_t end,const char *name)
Signature · 1 line
2.13.6
Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Quoted 10 lines · Baoquan He
reparent_resources()is duplicated inarch/microblaze/pci/pci-common.candarch/powerpc/kernel/pci-common.c, so move it tokernel/resource.cso that it's shared. Later its code also need be updated usinglist_headto replace singly linked list.Signed-off-by Baoquan He <[email protected]>Cc Michal Simek <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>Cc Paul Mackerras <[email protected]>Cc Michael Ellerman <mpe-Gsx/[email protected]>
Quoted 4 lines
---
v4->v5:
Fix several code bugs reported by test robot on ARCH powerpc and microblaze.
Oops, I mistakenly added the patch change log of the current patch 0002 here. This patch is a newly added one.
Quoted 179 lines
v3->v4:
Fix several bugs test robot reported. And change patch log.
v2->v3:
Rename resource functionsfirst_child()andsibling()toresource_first_chils()andresource_sibling(). Dan suggested this.Move
resource_first_chils()andresource_sibling()tolinux/ioport.hand make them as inline function. Rob suggested this. Accordingly addlinux/list.hincluding inlinux/ioport.h, please help review if this bring efficiency degradation or code redundancy.The change on struct resource {} bring two pointers of size increase, mention this in git log to make it more specifically, Rob suggested this.
arch/microblaze/pci/pci-common.c | 37 ------------------------------------- arch/powerpc/kernel/pci-common.c | 35 ----------------------------------- include/linux/ioport.h | 1 + kernel/resource.c | 36 ++++++++++++++++++++++++++++++++++++ 4 files changed, 37 insertions(+), 72 deletions(-)arch/microblaze/pci/pci-common.c +0
-37@@ -619,43 +619,6 @@ int pcibios_add_device(struct pci_dev *dev)EXPORT_SYMBOL (pcibios_add_device);/* -* Reparent resource children of pr that conflict with res -* under res, and make res replace those children. -*/ -static int __init reparent_resources (struct resource *parent, -struct resource *res) -{ -struct resource *p, **pp; -struct resource **firstpp =NULL ; - -for (pp = &parent->child; (p = *pp) !=NULL ; pp = &p->sibling) { -if (p->end < res->start) -continue ; -if (res->end < p->start) -break ; -if (p->start < res->start || p->end > res->end) -return -1 ;/* not completely contained */ -if (firstpp ==NULL ) - firstpp = pp; - } -if (firstpp ==NULL ) -return -1 ;/* didn't find any conflicting entries? */ - res->parent = parent; - res->child = *firstpp; - res->sibling = *pp; - *firstpp = res; - *pp =NULL ; -for (p = res->child; p !=NULL ; p = p->sibling) { - p->parent = res; -pr_debug ("PCI: Reparented %s [%llx..%llx] under %s\n" , - p->name, - (unsigned long long )p->start, - (unsigned long long )p->end, res->name); - } -return 0 ; -} - -/* * Handle resources of PCI devices. If the world were perfect, we could * just allocate all the resource regions and do nothing more. It isn't. * On the other hand, we cannot just re-allocate all devices, as it would arch/powerpc/kernel/pci-common.c +0
-35@@ -1088,41 +1088,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,EXPORT_SYMBOL (pcibios_align_resource);/* -* Reparent resource children of pr that conflict with res -* under res, and make res replace those children. -*/ -static int reparent_resources (struct resource *parent, -struct resource *res) -{ -struct resource *p, **pp; -struct resource **firstpp =NULL ; - -for (pp = &parent->child; (p = *pp) !=NULL ; pp = &p->sibling) { -if (p->end < res->start) -continue ; -if (res->end < p->start) -break ; -if (p->start < res->start || p->end > res->end) -return -1 ;/* not completely contained */ -if (firstpp ==NULL ) - firstpp = pp; - } -if (firstpp ==NULL ) -return -1 ;/* didn't find any conflicting entries? */ - res->parent = parent; - res->child = *firstpp; - res->sibling = *pp; - *firstpp = res; - *pp =NULL ; -for (p = res->child; p !=NULL ; p = p->sibling) { - p->parent = res; -pr_debug ("PCI: Reparented %s %pR under %s\n" , - p->name, p, res->name); - } -return 0 ; -} - -/* * Handle resources of PCI devices. If the world were perfect, we could * just allocate all the resource regions and do nothing more. It isn't. * On the other hand, we cannot just re-allocate all devices, as it would include/linux/ioport.h +1
-0@@ -192,6 +192,7 @@ extern int allocate_resource(struct resource *root, struct resource *new,struct resource *lookup_resource (struct resource *root,resource_size_t start);int adjust_resource (struct resource *res,resource_size_t start,resource_size_t size); +int reparent_resources (struct resource *parent,struct resource *res);resource_size_t resource_alignment (struct resource *res);static inline resource_size_t resource_size (const struct resource *res) {kernel/resource.c +36
-0@@ -983,6 +983,42 @@ int adjust_resource(struct resource *res, resource_size_t start, }EXPORT_SYMBOL (adjust_resource); +/* +* Reparent resource children of pr that conflict with res +* under res, and make res replace those children. +*/ +static int reparent_resources (struct resource *parent, +struct resource *res) +{ +struct resource *p, **pp; +struct resource **firstpp =NULL ; + +for (pp = &parent->child; (p = *pp) !=NULL ; pp = &p->sibling) { +if (p->end < res->start) +continue ; +if (res->end < p->start) +break ; +if (p->start < res->start || p->end > res->end) +return -1 ;/* not completely contained */ +if (firstpp ==NULL ) + firstpp = pp; + } +if (firstpp ==NULL ) +return -1 ;/* didn't find any conflicting entries? */ + res->parent = parent; + res->child = *firstpp; + res->sibling = *pp; + *firstpp = res; + *pp =NULL ; +for (p = res->child; p !=NULL ; p = p->sibling) { + p->parent = res; +pr_debug ("PCI: Reparented %s %pR under %s\n" , + p->name, p, res->name); + } +return 0 ; +} +EXPORT_SYMBOL (reparent_resources); +static void __init __reserve_region_with_split (struct resource *root,resource_size_t start,resource_size_t end,const char *name)Signature · 1 line
2.13.6
kbuild test robot
build botRe: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
In reply to Baoquan HeI love your patch! Yet something to improve:
Hi Baoquan,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Baoquan-He/resource-Use-list_head-to-link-sibling-resource/20180612-113600
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce:
# save the attached .config to linux build tree
make ARCH=i386 Note: the linux-review/Baoquan-He/resource-Use-list_head-to-link-sibling-resource/20180612-113600 HEAD 5545e79eef6387857faf41cdffa7be6b1f5d4efe builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
>> kernel/resource.c:990:12: error: static declaration of 'reparent_resources' follows non-static declaration
static int reparent_resources(struct resource *parent,
^~~~~~~~~~~~~~~~~~
In file included from kernel/resource.c:14:0:
include/linux/ioport.h:195:5: note: previous declaration of 'reparent_resources' was here
int reparent_resources(struct resource *parent, struct resource *res);
^~~~~~~~~~~~~~~~~~ kernel/resource.c:990:12: warning: 'reparent_resources' defined but not used [-Wunused-function]
static int reparent_resources(struct resource *parent,
^~~~~~~~~~~~~~~~~~
vim +/reparent_resources +990 kernel/resource.c
985
986 /*
987 * Reparent resource children of pr that conflict with res
988 * under res, and make res replace those children.
989 */
> 990 static int reparent_resources(struct resource *parent,
991 struct resource *res)
992 {
993 struct resource *p, **pp;
994 struct resource **firstpp = NULL;
995
996 for (pp = &parent->child; (p = *pp) != NULL; pp = &p->sibling) {
997 if (p->end < res->start)
998 continue;
999 if (res->end < p->start)
1000 break;
1001 if (p->start < res->start || p->end > res->end)
1002 return -1; /* not completely contained */
1003 if (firstpp == NULL)
1004 firstpp = pp;
1005 }
1006 if (firstpp == NULL)
1007 return -1; /* didn't find any conflicting entries? */
1008 res->parent = parent;
1009 res->child = *firstpp;
1010 res->sibling = *pp;
1011 *firstpp = res;
1012 *pp = NULL;
1013 for (p = res->child; p != NULL; p = p->sibling) {
1014 p->parent = res;
1015 pr_debug("PCI: Reparented %s %pR under %s\n",
1016 p->name, p, res->name);
1017 }
1018 return 0;
1019 }
1020 EXPORT_SYMBOL(reparent_resources);
1021
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
In reply to Baoquan HeQuoted 4 lines · Baoquan He
reparent_resources()is duplicated inarch/microblaze/pci/pci-common.candarch/powerpc/kernel/pci-common.c, so move it tokernel/resource.cso that it's shared. Later its code also need be updated usinglist_headto replace singly linked list.
While this is a good deduplication of the code, some requirements for public functions would be good to satisfy.
Quoted 4 lines
+/*
+ * Reparent resource children of pr that conflict with res
+ * under res, and make res replace those children.
+ */
kernel doc format, though...
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 991
Quoted 2 lines
kernel/resource.c +2
-0+static int reparent_resources (struct resource *parent, +struct resource *res)
...is it really public with static keyword?!
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 1002
Quoted 10 lines
kernel/resource.c +8
-0+{ +for (pp = &parent->child; (p = *pp) !=NULL ; pp = &p->sibling) { +if (p->end < res->start) +continue ; +if (res->end < p->start) +break ; +if (p->start < res->start || p->end > res->end) +return -1 ;/* not completely contained */
Usually we are expecting real eeror codes.
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 1007
Quoted 6 lines
kernel/resource.c +5
-0+if (firstpp ==NULL ) + firstpp = pp; + } +if (firstpp ==NULL ) +return -1 ;/* didn't find any conflicting entries? */
Ditto.
Quoted 2 lines
(quoted diff) +2
-0+} +EXPORT_SYMBOL(reparent_resources);
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Quoted 14 lines · Andy Shevchenko
Quoted 4 lines · Baoquan He
reparent_resources()is duplicated inarch/microblaze/pci/pci-common.candarch/powerpc/kernel/pci-common.c, so move it tokernel/resource.cso that it's shared. Later its code also need be updated usinglist_headto replace singly linked list.While this is a good deduplication of the code, some requirements for public functions would be good to satisfy.
Quoted 4 lines
+/*
+ * Reparent resource children of pr that conflict with res
+ * under res, and make res replace those children.
+ */
Quoted 7 lines
kernel doc format, though...
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 991
Quoted 2 lines
kernel/resource.c +2
-0+static int reparent_resources (struct resource *parent, +struct resource *res)...is it really public with static keyword?!
Thanks for looking into this. This is a code bug, I copied and changed, but forgot merging the changing to local commit. And the error reported by test robot in patch 2 was changed too locally, forgot merging it to patch. Will repost to address this.
Quoted 11 lines
Quoted 10 lines
kernel/resource.c +6
-0+{ +for (pp = &parent->child; (p = *pp) !=NULL ; pp = &p->sibling) { +if (p->end < res->start) +continue ; +if (res->end < p->start) +break ;
Quoted 4 lines
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 1002
Quoted 2 lines
kernel/resource.c +2
-0+if (p->start < res->start || p->end > res->end) +return -1 ;/* not completely contained */ Usually we are expecting real eeror codes.
Hmm, I just copied it from arch/powerpc/kernel/pci-common.c. The function interface expects an integer returned value, not sure what a real error codes look like, could you give more hints? Will change accordingly.
Quoted 16 lines
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 1007
Quoted 7 lines
kernel/resource.c +5
-0+if (firstpp ==NULL ) + firstpp = pp; + } +if (firstpp ==NULL ) +return -1 ;/* didn't find any conflicting entries? */ Ditto.
Quoted 2 lines
(quoted diff) +2
-0+} +EXPORT_SYMBOL(reparent_resources);Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Quoted 14 lines · Baoquan He
Quoted 13 lines · Andy Shevchenko
Quoted 10 lines · Baoquan He
kernel/resource.c +8
-0+{ +for (pp = &parent->child; (p = *pp) !=NULL ; pp = &p->sibling) { +if (p->end < res->start) +continue ; +if (res->end < p->start) +break ; +if (p->start < res->start || p->end > res->end) +return -1 ;/* not completely contained */
Quoted 6 lines
Quoted 1 line
Usually we are expecting real eeror codes.
Hmm, I just copied it from
arch/powerpc/kernel/pci-common.c. The function interface expects an integer returned value, not sure what a real error codes look like, could you give more hints? Will change accordingly.
I briefly looked at the code and error codes we have, so, my proposal is one of the following
- use -ECANCELED (not the best choice for first occurrence here,
though I can't find better)
- use positive integers (or enum), like
#define RES_REPARENTED 0
#define RES_OVERLAPPED 1
#define RES_NOCONFLICT 2
Quoted 8 lines
Quoted 8 lines
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 1007
Quoted 6 lines
kernel/resource.c +5
-0+if (firstpp ==NULL ) + firstpp = pp; + } +if (firstpp ==NULL ) +return -1 ;/* didn't find any conflicting entries? */ Ditto.
Ditto.
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
(quoted diff) +2
-0+} +EXPORT_SYMBOL(reparent_resources);
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Quoted 22 lines · Andy Shevchenko
Quoted 14 lines · Baoquan He
Quoted 13 lines · Andy Shevchenko
Quoted 10 lines · Baoquan He
kernel/resource.c +8
-0+{ +for (pp = &parent->child; (p = *pp) !=NULL ; pp = &p->sibling) { +if (p->end < res->start) +continue ; +if (res->end < p->start) +break ; +if (p->start < res->start || p->end > res->end) +return -1 ;/* not completely contained */ Quoted 6 lines
Quoted 1 line
Usually we are expecting real eeror codes.
Hmm, I just copied it from
arch/powerpc/kernel/pci-common.c. The function interface expects an integer returned value, not sure what a real error codes look like, could you give more hints? Will change accordingly.
Quoted 5 lines
I briefly looked at the code and error codes we have, so, my proposal is one of the following
- use
-ECANCELED(not the best choice for first occurrence here,
though I can't find better)
Actually -ENOTSUPP might suit the first case (although the actual would be something like -EOVERLAP, which we don't have)
Quoted 24 lines
- use positive integers (or enum), like
#defineRES_REPARENTED0
#defineRES_OVERLAPPED1
#defineRES_NOCONFLICT2Quoted 8 lines
Quoted 8 lines
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 1007
Quoted 6 lines
kernel/resource.c +5
-0+if (firstpp ==NULL ) + firstpp = pp; + } +if (firstpp ==NULL ) +return -1 ;/* didn't find any conflicting entries? */ Ditto.
Ditto.
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+} +EXPORT_SYMBOL(reparent_resources);--
With Best Regards,
Andy Shevchenko
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Hi Andy,
Quoted 7 lines · Andy Shevchenko
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines
Hmm, I just copied it from
arch/powerpc/kernel/pci-common.c. The function interface expects an integer returned value, not sure what a real error codes look like, could you give more hints? Will change accordingly.
Quoted 8 lines
Quoted 5 lines
I briefly looked at the code and error codes we have, so, my proposal is one of the following
- use
-ECANCELED(not the best choice for first occurrence here,
though I can't find better)Actually
-ENOTSUPPmight suit the first case (although the actual would be something like-EOVERLAP, which we don't have)
Sorry for late reply, and many thanks for your great suggestion.
I am fine to use -ENOTSUPP as the first returned value, and -ECANCELED for the 2nd one. Or define an enum as you suggested inside the function or in header file.
Or use -EBUSY for the first case because existing resource is overlapping but not fully contained by 'res'; and -EINVAL for the 2nd case since didn't find any one resources which is contained by 'res', means we passed in a invalid resource.
All is fine to me, I can repost with each of them.
Thanks
Baoquan
Quoted 31 lines
Quoted 25 lines
- use positive integers (or enum), like
#defineRES_REPARENTED0
#defineRES_OVERLAPPED1
#defineRES_NOCONFLICT2Quoted 8 lines
Quoted 8 lines
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 1007
Quoted 6 lines
kernel/resource.c +5
-0+if (firstpp ==NULL ) + firstpp = pp; + } +if (firstpp ==NULL ) +return -1 ;/* didn't find any conflicting entries? */ Ditto.
Ditto.
Quoted 3 lines
Quoted 3 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+} +EXPORT_SYMBOL(reparent_resources);--
With Best Regards,
Andy ShevchenkoSignature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Quoted 10 lines · Baoquan He
Quoted 9 lines · Andy Shevchenko
Quoted 5 lines · Andy Shevchenko
I briefly looked at the code and error codes we have, so, my proposal is one of the following
- use
-ECANCELED(not the best choice for first occurrence here,
though I can't find better)
Quoted 8 lines
Quoted 2 lines
Actually
-ENOTSUPPmight suit the first case (although the actual would be something like-EOVERLAP, which we don't have)Sorry for late reply, and many thanks for your great suggestion.
I am fine to use
-ENOTSUPPas the first returned value, and-ECANCELEDfor the 2nd one.
I have no strong opinion, but I like (slightly better) this approach ^^^
Quoted 15 lines
Or define an enum as you suggested inside the function or in header file.
Or use
-EBUSYfor the first case because existing resource is overlapping but not fully contained by 'res'; and-EINVALfor the 2nd case since didn't find any one resources which is contained by 'res', means we passed in a invalid resource.All is fine to me, I can repost with each of them.
Quoted 4 lines
Quoted 4 lines
- use positive integers (or enum), like
#defineRES_REPARENTED0
#defineRES_OVERLAPPED1
#defineRES_NOCONFLICT2
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Quoted 14 lines · Andy Shevchenko
Quoted 13 lines · Baoquan He
Quoted 11 lines · Andy Shevchenko
Quoted 5 lines · Andy Shevchenko
I briefly looked at the code and error codes we have, so, my proposal is one of the following
- use
-ECANCELED(not the best choice for first occurrence here,
though I can't find better)Actually
-ENOTSUPPmight suit the first case (although the actual would be something like-EOVERLAP, which we don't have)
Quoted 7 lines
Quoted 5 lines
Sorry for late reply, and many thanks for your great suggestion.
I am fine to use
-ENOTSUPPas the first returned value, and-ECANCELEDfor the 2nd one.I have no strong opinion, but I like (slightly better) this approach ^^^
Done, post v6 in this way, many thanks.
Quoted 20 lines
Quoted 16 lines
Or define an enum as you suggested inside the function or in header file.
Or use
-EBUSYfor the first case because existing resource is overlapping but not fully contained by 'res'; and-EINVALfor the 2nd case since didn't find any one resources which is contained by 'res', means we passed in a invalid resource.All is fine to me, I can repost with each of them.
Quoted 4 lines
Quoted 4 lines
- use positive integers (or enum), like
#defineRES_REPARENTED0
#defineRES_OVERLAPPED1
#defineRES_NOCONFLICT2Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
In reply to Andy ShevchenkoQuoted 9 lines · Andy Shevchenko
Quoted 4 lines · Baoquan He
reparent_resources()is duplicated inarch/microblaze/pci/pci-common.candarch/powerpc/kernel/pci-common.c, so move it tokernel/resource.cso that it's shared. Later its code also need be updated usinglist_headto replace singly linked list.While this is a good deduplication of the code, some requirements for public functions would be good to satisfy.
Quoted 6 lines
Quoted 4 lines
+/*
+ * Reparent resource children of pr that conflict with res
+ * under res, and make res replace those children.
+ */kernel doc format, though...
Will rewrite it, thanks.
Quoted 36 lines
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 991
Quoted 3 lines
kernel/resource.c +2
-0+static int reparent_resources (struct resource *parent, +struct resource *res)...is it really public with static keyword?!
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 1002
Quoted 10 lines
kernel/resource.c +8
-0+{ +for (pp = &parent->child; (p = *pp) !=NULL ; pp = &p->sibling) { +if (p->end < res->start) +continue ; +if (res->end < p->start) +break ; +if (p->start < res->start || p->end > res->end) +return -1 ;/* not completely contained */ Usually we are expecting real eeror codes.
kernel/resource.c int adjust_resource(struct resource *res, resource_size_t start, · line 1007
Quoted 6 lines
kernel/resource.c +5
-0+if (firstpp ==NULL ) + firstpp = pp; + } +if (firstpp ==NULL ) +return -1 ;/* didn't find any conflicting entries? */ Ditto.
Quoted 2 lines
(quoted diff) +2
-0+} +EXPORT_SYMBOL(reparent_resources);Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v5 2/4 resource: Use list_head to link sibling resource
In reply to Baoquan HeThe struct resource uses singly linked list to link siblings, implemented by pointer operation. Replace it with list_head for better code readability.
Based on this list_head replacement, it will be very easy to do reverse iteration on iomem_resource's sibling list in later patch.
Besides, type of member variables of struct resource, sibling and child, are changed from 'struct resource *' to 'struct list_head'. This brings two pointers of size increase.
--- arch/arm/plat-samsung/pm-check.c | 6 +- arch/microblaze/pci/pci-common.c | 4 +- arch/powerpc/kernel/pci-common.c | 4 +- arch/sparc/kernel/ioport.c | 2 +- arch/xtensa/include/asm/pci-bridge.h | 4 +- drivers/eisa/eisa-bus.c | 2 + drivers/gpu/drm/drm_memory.c | 3 +- drivers/gpu/drm/gma500/gtt.c | 5 +- drivers/hv/vmbus_drv.c | 52 +++---- drivers/input/joystick/iforce/iforce-main.c | 4 +- drivers/nvdimm/namespace_devs.c | 6 +- drivers/nvdimm/nd.h | 5 +- drivers/of/address.c | 4 +- drivers/parisc/lba_pci.c | 4 +- drivers/pci/host/vmd.c | 8 +- drivers/pci/probe.c | 2 + drivers/pci/setup-bus.c | 2 +- include/linux/ioport.h | 17 ++- kernel/resource.c | 211 ++++++++++++++-------------- 19 files changed, 176 insertions(+), 169 deletions(-)
arch/arm/plat-samsung/pm-check.c +3 -3
@@ -46,8 +46,8 @@ typedef u32 *(run_fn_t)(struct resource *ptr, u32 *arg);static void s3c_pm_run_res (struct resource *ptr,run_fn_t fn,u32 *arg) {while (ptr !=NULL ) { -if (ptr->child !=NULL ) -s3c_pm_run_res (ptr->child, fn, arg); +if (!list_empty (&ptr->child)) +s3c_pm_run_res (resource_first_child (&ptr->child), fn, arg);if ((ptr->flags &IORESOURCE_SYSTEM_RAM ) ==IORESOURCE_SYSTEM_RAM ) {
@@ -57,7 +57,7 @@ static void s3c_pm_run_res(struct resource *ptr, run_fn_t fn, u32 *arg) arg = (fn)(ptr, arg); } - ptr = ptr->sibling; + ptr =resource_sibling (ptr); } }
arch/microblaze/pci/pci-common.c +3 -1
@@ -533,7 +533,9 @@ void pci_process_bridge_OF_ranges(struct pci_controller *hose, res->flags = range.flags; res->start = range.cpu_addr; res->end = range.cpu_addr + range.size -1 ; - res->parent = res->child = res->sibling =NULL ; + res->parent =NULL ; +INIT_LIST_HEAD (&res->child); +INIT_LIST_HEAD (&res->sibling); } }
arch/powerpc/kernel/pci-common.c +3 -1
@@ -761,7 +761,9 @@ void pci_process_bridge_OF_ranges(struct pci_controller *hose, res->flags = range.flags; res->start = range.cpu_addr; res->end = range.cpu_addr + range.size -1 ; - res->parent = res->child = res->sibling =NULL ; + res->parent =NULL ; +INIT_LIST_HEAD (&res->child); +INIT_LIST_HEAD (&res->sibling); } } }
arch/sparc/kernel/ioport.c +1 -1
@@ -669,7 +669,7 @@ static int sparc_io_proc_show(struct seq_file *m, void *v)struct resource *root = m->private, *r;const char *nm; -for (r = root->child; r !=NULL ; r = r->sibling) { +list_for_each_entry (r, &root->child, sibling) {if ((nm = r->name) ==NULL ) nm ="???" ; seq_printf(m, "%016llx-%016llx: %s\n", (unsigned long long)r->start,
arch/xtensa/include/asm/pci-bridge.h +2 -2
@@ -71,8 +71,8 @@ static inline void pcibios_init_resource(struct resource *res, res->flags = flags; res->name = name; res->parent =NULL ; - res->sibling =NULL ; - res->child =NULL ; +INIT_LIST_HEAD (&res->child); +INIT_LIST_HEAD (&res->sibling); }
drivers/eisa/eisa-bus.c +2 -0
@@ -408,6 +408,8 @@ static struct resource eisa_root_res = { .start = 0, .end = 0xffffffff, .flags = IORESOURCE_IO, + .sibling = LIST_HEAD_INIT(eisa_root_res.sibling), + .child = LIST_HEAD_INIT(eisa_root_res.child), };static int eisa_bus_count;
drivers/gpu/drm/drm_memory.c +1 -2
@@ -155,9 +155,8 @@ u64 drm_get_max_iomem(void)struct resource *tmp;resource_size_t max_iomem =0 ; -for (tmp = iomem_resource.child; tmp; tmp = tmp->sibling) { +list_for_each_entry (tmp, &iomem_resource.child, sibling) max_iomem =max (max_iomem, tmp->end); - }return max_iomem; }
drivers/gpu/drm/gma500/gtt.c +2 -3
@@ -565,7 +565,7 @@ int psb_gtt_init(struct drm_device *dev, int resume)int psb_gtt_restore (struct drm_device *dev) {struct drm_psb_private *dev_priv = dev->dev_private; -struct resource *r = dev_priv->gtt_mem->child; +struct resource *r;struct gtt_range *range;unsigned int restored =0 , total =0 , size =0 ;
@@ -573,14 +573,13 @@ int psb_gtt_restore(struct drm_device *dev)mutex_lock (&dev_priv->gtt_mutex);psb_gtt_init (dev,1 ); -while (r !=NULL ) { +list_for_each_entry (r, &dev_priv->gtt_mem->child, sibling) { range = container_of(r, struct gtt_range, resource);if (range->pages) {psb_gtt_insert (dev, range,1 ); size += range->resource.end - range->resource.start; restored++; } - r = r->sibling; total++; }mutex_unlock (&dev_priv->gtt_mutex);
drivers/hv/vmbus_drv.c +22 -30
99 lines not on this page · raw message
drivers/input/joystick/iforce/iforce-main.c +2 -2
@@ -305,8 +305,8 @@ int iforce_init_device(struct iforce *iforce) iforce->device_memory.end =200 ; iforce->device_memory.flags =IORESOURCE_MEM ; iforce->device_memory.parent =NULL ; - iforce->device_memory.child =NULL ; - iforce->device_memory.sibling =NULL ; +INIT_LIST_HEAD (&iforce->device_memory.child); +INIT_LIST_HEAD (&iforce->device_memory.sibling);/* * Wait until device ready - until it sends its first response.
drivers/nvdimm/namespace_devs.c +3 -3
@@ -637,7 +637,7 @@ static resource_size_t scan_allocate(struct nd_region *nd_region, retry: first =0 ;for_each_dpa_resource (ndd, res) { -struct resource *next = res->sibling, *new_res =NULL ; +struct resource *next =resource_sibling (res), *new_res =NULL ;resource_size_t allocate, available =0 ;enum alloc_loc loc =ALLOC_ERR ;const char *action;
@@ -763,7 +763,7 @@ static resource_size_t scan_allocate(struct nd_region *nd_region,* an initial "pmem-reserve pass". Only do an initial BLK allocation * when none of the DPA space is reserved. */ -if ((is_pmem || !ndd->dpa.child) && n == to_allocate) +if ((is_pmem ||list_empty (&ndd->dpa.child)) && n == to_allocate)return init_dpa_allocation (label_id, nd_region, nd_mapping, n);return n; }
@@ -779,7 +779,7 @@ static int merge_dpa(struct nd_region *nd_region, retry:for_each_dpa_resource (ndd, res) {int rc; -struct resource *next = res->sibling; +struct resource *next =resource_sibling (res);resource_size_t end = res->start +resource_size (res); if (!next || strcmp(res->name, label_id->id) != 0
drivers/nvdimm/nd.h +2 -3
@@ -102,11 +102,10 @@ unsigned sizeof_namespace_label(struct nvdimm_drvdata *ndd); (unsigned long long) (res ? res->start : 0), ##arg)#define for_each_dpa_resource (ndd, res) \ - for (res = (ndd)->dpa.child; res; res = res->sibling) + list_for_each_entry(res, &(ndd)->dpa.child, sibling)#define for_each_dpa_resource_safe (ndd, res, next) \ - for (res = (ndd)->dpa.child, next = res ? res->sibling : NULL; \ - res; res = next, next = next ? next->sibling : NULL) + list_for_each_entry_safe(res, next, &(ndd)->dpa.child, sibling)struct nd_percpu_lane {int count;
drivers/of/address.c +3 -1
@@ -330,7 +330,9 @@ int of_pci_range_to_resource(struct of_pci_range *range, {int err; res->flags = range->flags; - res->parent = res->child = res->sibling =NULL ; + res->parent =NULL ; +INIT_LIST_HEAD (&res->child); +INIT_LIST_HEAD (&res->sibling); res->name = np->full_name;if (res->flags &IORESOURCE_IO ) {
drivers/parisc/lba_pci.c +2 -2
@@ -170,8 +170,8 @@ lba_dump_res(struct resource *r, int d)for (i = d; i ; --i)printk (" " );printk (KERN_DEBUG "%p [%lx,%lx]/%lx\n" , r, (long )r->start, (long )r->end, r->flags); -lba_dump_res (r->child, d+2 ); -lba_dump_res (r->sibling, d); +lba_dump_res (resource_first_child (&r->child), d+2 ); +lba_dump_res (resource_sibling (r), d); }
drivers/pci/host/vmd.c +4 -4
@@ -542,14 +542,14 @@ static struct pci_ops vmd_ops = {static void vmd_attach_resources (struct vmd_dev *vmd) { - vmd->dev->resource[VMD_MEMBAR1 ].child = &vmd->resources[1 ]; - vmd->dev->resource[VMD_MEMBAR2 ].child = &vmd->resources[2 ]; +list_add (&vmd->resources[1 ].sibling, &vmd->dev->resource[VMD_MEMBAR1 ].child); +list_add (&vmd->resources[2 ].sibling, &vmd->dev->resource[VMD_MEMBAR2 ].child); }static void vmd_detach_resources (struct vmd_dev *vmd) { - vmd->dev->resource[VMD_MEMBAR1 ].child =NULL ; - vmd->dev->resource[VMD_MEMBAR2 ].child =NULL ; +INIT_LIST_HEAD (&vmd->dev->resource[VMD_MEMBAR1 ].child); +INIT_LIST_HEAD (&vmd->dev->resource[VMD_MEMBAR2 ].child); }/*
drivers/pci/probe.c +2 -0
@@ -59,6 +59,8 @@ static struct resource *get_pci_domain_busn_res(int domain_nr) r->res.start =0 ; r->res.end =0xff ; r->res.flags =IORESOURCE_BUS |IORESOURCE_PCI_FIXED ; +INIT_LIST_HEAD (&r->res.child); +INIT_LIST_HEAD (&r->res.sibling);list_add_tail (&r->list, &pci_domain_busn_res_list);
drivers/pci/setup-bus.c +1 -1
@@ -2107,7 +2107,7 @@ int pci_reassign_bridge_resources(struct pci_dev *bridge, unsigned long type)continue ;/* Ignore BARs which are still in use */ -if (res->child) +if (!list_empty (&res->child))continue ; ret =add_to_list (&saved, bridge, res,0 ,0 );
include/linux/ioport.h +15 -2
@@ -12,6 +12,7 @@#ifndef __ASSEMBLY__#include <linux/compiler.h> #include <linux/types.h> +#include <linux/list.h> /* * Resources are tree-like, allowing * nesting etc..
@@ -22,7 +23,8 @@ struct resource {const char *name;unsigned long flags;unsigned long desc; -struct resource *parent, *sibling, *child; +struct list_head child, sibling; +struct resource *parent; };/*
@@ -216,7 +218,6 @@ static inline bool resource_contains(struct resource *r1, struct resource *r2)return r1->start <= r2->start && r1->end >= r2->end; } -/* Convenience shorthand with allocation */ #define request_region (start,n,name) __request_region(&ioport_resource, (start), (n), (name), 0)#define request_muxed_region (start,n,name) __request_region(&ioport_resource, (start), (n), (name), IORESOURCE_MUXED)
@@ -287,6 +288,18 @@ static inline bool resource_overlaps(struct resource *r1, struct resource *r2)return (r1->start <= r2->end && r1->end >= r2->start); } +static inline struct resource *resource_sibling (struct resource *res) +{ +if (res->parent && !list_is_last (&res->sibling, &res->parent->child)) +return list_next_entry (res, sibling); +return NULL ; +} + +static inline struct resource *resource_first_child (struct list_head *head) +{ + return list_first_entry_or_null(head, struct resource, sibling); +} +#endif /* __ASSEMBLY__ */ #endif /* _LINUX_IOPORT_H */
kernel/resource.c +103 -108
482 lines not on this page · raw message
Signature · 6 lines
2.13.6 _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
kbuild test robot
build botI love your patch! Yet something to improve:
Hi Baoquan,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Baoquan-He/resource-Use-list_head-to-link-sibling-resource/20180612-113600
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce:
# save the attached .config to linux build tree
make ARCH=i386 All errors (new ones prefixed by >>):
kernel/resource.c: In function 'reparent_resources':
>> kernel/resource.c:1005:26: error: passing argument 2 of 'list_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
list_add(&res->sibling, &p->sibling.prev);
^
In file included from include/linux/ioport.h:15:0,
from kernel/resource.c:14:
include/linux/list.h:77:20: note: expected 'struct list_head *' but argument is of type 'struct list_head **'
static inline void list_add(struct list_head *new, struct list_head *head)
^~~~~~~~
In file included from include/linux/list.h:9:0,
from include/linux/ioport.h:15,
from kernel/resource.c:14:
>> kernel/resource.c:1013:26: error: 'new' undeclared (first use in this function); did you mean 'net'?
list_for_each_entry(p, &new->child, sibling) {
^
include/linux/kernel.h:963:26: note: in definition of macro 'container_of'
void *__mptr = (void *)(ptr); \
^~~
include/linux/list.h:377:2: note: in expansion of macro 'list_entry'
list_entry((ptr)->next, type, member)
^~~~~~~~~~
include/linux/list.h:464:13: note: in expansion of macro 'list_first_entry'
for (pos = list_first_entry(head, typeof(*pos), member); \
^~~~~~~~~~~~~~~~
kernel/resource.c:1013:2: note: in expansion of macro 'list_for_each_entry'
list_for_each_entry(p, &new->child, sibling) {
^~~~~~~~~~~~~~~~~~~
kernel/resource.c:1013:26: note: each undeclared identifier is reported only once for each function it appears in
list_for_each_entry(p, &new->child, sibling) {
^
include/linux/kernel.h:963:26: note: in definition of macro 'container_of'
void *__mptr = (void *)(ptr); \
^~~
include/linux/list.h:377:2: note: in expansion of macro 'list_entry'
list_entry((ptr)->next, type, member)
^~~~~~~~~~
include/linux/list.h:464:13: note: in expansion of macro 'list_first_entry'
for (pos = list_first_entry(head, typeof(*pos), member); \
^~~~~~~~~~~~~~~~
kernel/resource.c:1013:2: note: in expansion of macro 'list_for_each_entry'
list_for_each_entry(p, &new->child, sibling) {
^~~~~~~~~~~~~~~~~~~cc1: some warnings being treated as errors
vim +/list_add +1005 kernel/resource.c
983
984 /*
985 * Reparent resource children of pr that conflict with res
986 * under res, and make res replace those children.
987 */
988 int reparent_resources(struct resource *parent, struct resource *res)
989 {
990 struct resource *p, *first = NULL;
991
992 list_for_each_entry(p, &parent->child, sibling) {
993 if (p->end < res->start)
994 continue;
995 if (res->end < p->start)
996 break;
997 if (p->start < res->start || p->end > res->end)
998 return -1; /* not completely contained */
999 if (first == NULL)
1000 first = p;
1001 }
1002 if (first == NULL)
1003 return -1; /* didn't find any conflicting entries? */
1004 res->parent = parent;
> 1005 list_add(&res->sibling, &p->sibling.prev);
1006 INIT_LIST_HEAD(&res->child);
1007
1008 /*
1009 * From first to p's previous sibling, they all fall into
1010 * res's region, change them as res's children.
1011 */
1012 list_cut_position(&res->child, first->sibling.prev, res->sibling.prev);
> 1013 list_for_each_entry(p, &new->child, sibling) { 1014 p->parent = new;
1015 pr_debug("PCI: Reparented %s %pR under %s\n",
1016 p->name, p, res->name);
1017 }
1018 return 0;
1019 }
1020 EXPORT_SYMBOL(reparent_resources);
1021
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
kbuild test robot
build botI love your patch! Perhaps something to improve:
Hi Baoquan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Baoquan-He/resource-Use-list_head-to-link-sibling-resource/20180612-113600
config: x86_64-randconfig-x011-201823 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 All warnings (new ones prefixed by >>):
kernel/resource.c: In function 'reparent_resources':
kernel/resource.c:1005:26: error: passing argument 2 of 'list_add' from incompatible pointer type [-Werror=incompatible-pointer-types]
list_add(&res->sibling, &p->sibling.prev);
^
In file included from include/linux/ioport.h:15:0,
from kernel/resource.c:14:
include/linux/list.h:77:20: note: expected 'struct list_head *' but argument is of type 'struct list_head **'
static inline void list_add(struct list_head *new, struct list_head *head)
^~~~~~~~
In file included from include/linux/list.h:9:0,
from include/linux/ioport.h:15,
from kernel/resource.c:14:
kernel/resource.c:1013:26: error: 'new' undeclared (first use in this function); did you mean 'net'?
list_for_each_entry(p, &new->child, sibling) {
^
include/linux/kernel.h:963:26: note: in definition of macro 'container_of'
void *__mptr = (void *)(ptr); \
^~~
include/linux/list.h:377:2: note: in expansion of macro 'list_entry'
list_entry((ptr)->next, type, member)
^~~~~~~~~~
include/linux/list.h:464:13: note: in expansion of macro 'list_first_entry'
for (pos = list_first_entry(head, typeof(*pos), member); \
^~~~~~~~~~~~~~~~
>> kernel/resource.c:1013:2: note: in expansion of macro 'list_for_each_entry'
list_for_each_entry(p, &new->child, sibling) {
^~~~~~~~~~~~~~~~~~~
kernel/resource.c:1013:26: note: each undeclared identifier is reported only once for each function it appears in
list_for_each_entry(p, &new->child, sibling) {
^
include/linux/kernel.h:963:26: note: in definition of macro 'container_of'
void *__mptr = (void *)(ptr); \
^~~
include/linux/list.h:377:2: note: in expansion of macro 'list_entry'
list_entry((ptr)->next, type, member)
^~~~~~~~~~
include/linux/list.h:464:13: note: in expansion of macro 'list_first_entry'
for (pos = list_first_entry(head, typeof(*pos), member); \
^~~~~~~~~~~~~~~~
>> kernel/resource.c:1013:2: note: in expansion of macro 'list_for_each_entry'
list_for_each_entry(p, &new->child, sibling) {
^~~~~~~~~~~~~~~~~~~cc1: some warnings being treated as errors
vim +/list_for_each_entry +1013 kernel/resource.c
983
984 /*
985 * Reparent resource children of pr that conflict with res
986 * under res, and make res replace those children.
987 */
988 int reparent_resources(struct resource *parent, struct resource *res)
989 {
990 struct resource *p, *first = NULL;
991
992 list_for_each_entry(p, &parent->child, sibling) {
993 if (p->end < res->start)
994 continue;
995 if (res->end < p->start)
996 break;
997 if (p->start < res->start || p->end > res->end)
998 return -1; /* not completely contained */
999 if (first == NULL)
1000 first = p;
1001 }
1002 if (first == NULL)
1003 return -1; /* didn't find any conflicting entries? */
1004 res->parent = parent;
1005 list_add(&res->sibling, &p->sibling.prev);
1006 INIT_LIST_HEAD(&res->child);
1007
1008 /*
1009 * From first to p's previous sibling, they all fall into
1010 * res's region, change them as res's children.
1011 */
1012 list_cut_position(&res->child, first->sibling.prev, res->sibling.prev);
> 1013 list_for_each_entry(p, &new->child, sibling) { 1014 p->parent = new;
1015 pr_debug("PCI: Reparented %s %pR under %s\n",
1016 p->name, p, res->name);
1017 }
1018 return 0;
1019 }
1020 EXPORT_SYMBOL(reparent_resources);
1021
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
PATCH v5 3/4 resource: add walk_system_ram_res_rev()
In reply to Baoquan HeThis function, being a variant of walk_system_ram_res() introduced in commit 8c86e70acead ("resource: provide new functions to walk through resources"), walks through a list of all the resources of System RAM in reversed order, i.e., from higher to lower.
It will be used in kexec_file code.
--- include/linux/ioport.h | 3 +++ kernel/resource.c | 40 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+)
include/linux/ioport.h +3 -0
@@ -279,6 +279,9 @@ extern int walk_system_ram_res(u64 start, u64 end, void *arg, int (*func)(struct resource *, void *));extern int +walk_system_ram_res_rev (u64 start,u64 end,void *arg, +int (*func)(struct resource *,void *)); +extern int walk_iomem_res_desc (unsigned long desc,unsigned long flags,u64 start,u64 end,void *arg,int (*func)(struct resource *,void *));
kernel/resource.c +40 -0
@@ -23,6 +23,8 @@#include <linux/pfn.h> #include <linux/mm.h> #include <linux/resource_ext.h> +#include <linux/string.h> +#include <linux/vmalloc.h> #include <asm/io.h>
@@ -443,6 +445,44 @@ int walk_system_ram_res(u64 start, u64 end, void *arg, }/* +* This function, being a variant of walk_system_ram_res(), calls the @func +* callback against all memory ranges of type System RAM which are marked as +* IORESOURCE_SYSTEM_RAM and IORESOUCE_BUSY in reversed order, i.e., from +* higher to lower. +*/ +int walk_system_ram_res_rev (u64 start,u64 end,void *arg, +int (*func)(struct resource *,void *)) +{ +unsigned long flags; +struct resource *res; +int ret =-1 ; + + flags =IORESOURCE_SYSTEM_RAM |IORESOURCE_BUSY ; + +read_lock (&resource_lock); +list_for_each_entry_reverse (res, &iomem_resource.child, sibling) { +if (start >= end) +break ; +if ((res->flags & flags) != flags) +continue ; +if (res->desc !=IORES_DESC_NONE ) +continue ; +if (res->end < start) +break ; + +if ((res->end >= start) && (res->start < end)) { + ret = (*func)(res, arg); +if (ret) +break ; + } + end = res->start -1 ; + + } +read_unlock (&resource_lock); +return ret; +} + +/* * This function calls the @func callback against all memory ranges, which * are ranges marked as IORESOURCE_MEM and IORESOUCE_BUSY. */
Signature · 1 line
2.13.6
PATCH v5 4/4 kexec_file: Load kernel at top of system RAM if required
In reply to Baoquan HeFor kexec_file loading, if kexec_buf.top_down is 'true', the memory which is used to load kernel/initrd/purgatory is supposed to be allocated from top to down. This is what we have been doing all along in the old kexec loading interface and the kexec loading is still default setting in some distributions. However, the current kexec_file loading interface doesn't do likt this. The function arch_kexec_walk_mem() it calls ignores checking kexec_buf.top_down, but calls walk_system_ram_res() directly to go through all resources of System RAM from bottom to up, to try to find memory region which can contain the specific kexec buffer, then call locate_mem_hole_callback() to allocate memory in that found memory region from top to down. This brings confusion especially when KASLR is widely supported , users have to make clear why kexec/kdump kernel loading position is different between these two interfaces in order to exclude unnecessary noises. Hence these two interfaces need be unified on behaviour.
Here add checking if kexec_buf.top_down is 'true' in arch_kexec_walk_mem(), if yes, call the newly added walk_system_ram_res_rev() to find memory region from top to down to load kernel.
--- kernel/kexec_file.c | 2 ++ 1 file changed, 2 insertions(+)
kernel/kexec_file.c +2 -0
@@ -518,6 +518,8 @@ int __weak arch_kexec_walk_mem(struct kexec_buf *kbuf,IORESOURCE_SYSTEM_RAM |IORESOURCE_BUSY , crashk_res.start, crashk_res.end, kbuf, func); + else if (kbuf->top_down) + return walk_system_ram_res_rev(0, ULONG_MAX, kbuf, func); else return walk_system_ram_res(0, ULONG_MAX, kbuf, func); }
Signature · 1 line
2.13.6