Input: xen-kbdfront - allow better run-time configuration
Subsystems (3)
v5 cover Input: xen-kbdfront - allow better run-time configuration
From: Oleksandr Andrushchenko <[email protected]>
Hi, all!
This patch series synchronizes Xen canonical protocol definitions which allow the last two patches in the series to update Xen kbdfront driver with a fix and v5 of the patch to allow better run-time configuration for xen-kbdfront.
As xen-kbdfront patches rely on protocol changes from patch 1 I am sending these all together: Boris, Juergen, if you and Dmitry do not mind, can we have patch 1 applied through Dmitry's tree?
Thank you,
Oleksandr
Changes since v4:
- Added required changes to Xen protocols
- Added a fix for multi-touch XenStore node's locations
- No changes to "Input: xen-kbdfront - allow better run-time configuration"
Changes since v3:
- do not connect backend if all virtual devices are disabled (Dmitry)
Changes since v2:
- based on XenStore kbdif features to control which devices are exposed instead of module parameters.
Oleksandr Andrushchenko (3):
xen: Sync up with the canonical protocol definitions in Xen
Input: xen-kbdfront - fix multi-touch XenStore node's locations
Input: xen-kbdfront - allow better run-time configuration
drivers/input/misc/xen-kbdfront.c | 183 +++++++++++++++++------------ include/xen/interface/io/displif.h | 8 ++ include/xen/interface/io/kbdif.h | 78 +++++++++--- include/xen/interface/io/sndif.h | 10 +- 4 files changed, 180 insertions(+), 99 deletions(-)
Signature · 1 line
2.17.1
PATCH v5 1/3 xen: Sync up with the canonical protocol definitions in Xen
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.
2. Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created
3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.
2. Change type of unique-id field to string for sndif to align with display and input protocols.
--- include/xen/interface/io/displif.h | 8 +++ include/xen/interface/io/kbdif.h | 78 ++++++++++++++++++++++-------- include/xen/interface/io/sndif.h | 10 ++-- 3 files changed, 71 insertions(+), 25 deletions(-)
include/xen/interface/io/displif.h +8 -0
@@ -189,6 +189,13 @@ * *----------------------------- Connector settings ---------------------------- * + * unique-id + * Values: <string> + * + * After device instance initialization each connector is assigned a + * unique ID, so it can be identified by the backend by this ID. + * This can be UUID or such. + * * resolution * Values: <width, uint32_t>x<height, uint32_t> *
@@ -368,6 +375,7 @@#define XENDISPL_FIELD_EVT_CHANNEL "evt-event-channel"#define XENDISPL_FIELD_RESOLUTION "resolution"#define XENDISPL_FIELD_BE_ALLOC "be-alloc" +#define XENDISPL_FIELD_UNIQUE_ID "unique-id"/* ******************************************************************************
include/xen/interface/io/kbdif.h +59 -19
123 lines not on this page · raw message
include/xen/interface/io/sndif.h +4 -6
@@ -278,13 +278,11 @@* defined under the same device. * * unique-id -* Values: <uint32_t> +* Values: <string> * -* After stream initialization it is assigned a unique ID (within the front -* driver), so every stream of the frontend can be identified by the -* backend by this ID. This is not equal to stream-idx as the later is -* zero based within the device, but this index is contigous within the -* driver. +* After stream initialization it is assigned a unique ID, so every +* stream of the frontend can be identified by the backend by this ID. +* This can be UUID or such. * *-------------------- Stream Request Transport Parameters -------------------- *
Signature · 1 line
2.17.1
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
Quoted 21 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Quoted 8 lines
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Signed-off-by Oleksandr Andrushchenko <[email protected]>Cc Konrad Rzeszutek Wilk <[email protected]>
I'm fine with this patch being added via the input tree with the other patches. In case I should take it via the Xen tree, please send me a note.
Juergen
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
Quoted 28 lines · Juergen Gross
Quoted 27 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Quoted 7 lines
Quoted 2 lines
Signed-off-by Oleksandr Andrushchenko <[email protected]>Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the other patches. In case I should take it via the Xen tree, please send me a note.
Thank you
Quoted 2 lines
Juergen
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Juergen GrossQuoted 28 lines · Juergen Gross
Quoted 27 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Quoted 7 lines
Quoted 2 lines
Signed-off-by Oleksandr Andrushchenko <[email protected]>Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the other patches. In case I should take it via the Xen tree, please send me a note.
Thank you
Quoted 2 lines
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Dmitry Torokhov
maintainerRe: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Juergen GrossQuoted 28 lines · Juergen Gross
Quoted 27 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Quoted 8 lines
Quoted 2 lines
Signed-off-by Oleksandr Andrushchenko <[email protected]>Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the other patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case you would want to merge them into your tree without waiting for them to appear in mainline:
git pull git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git ib/4.17-xen-kbdfront-runtime-config
Thanks.
Signature · 1 line
Dmitry
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
Quoted 38 lines · Dmitry Torokhov
Quoted 28 lines · Juergen Gross
Quoted 27 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Quoted 7 lines
Quoted 2 lines
Signed-off-by Oleksandr Andrushchenko <[email protected]>Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the other patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
Quoted 8 lines
I created an immutable branch off v4.17 with these 3 patches in case you would want to merge them into your tree without waiting for them to appear in mainline:
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitib/4.17-xen-kbdfront-runtime-configThanks.
Thank you,
I would prefer the fastest path of course
Dmitry Torokhov
maintainerRe: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
Quoted 49 lines · Oleksandr Andrushchenko
Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines · Juergen Gross
Quoted 2 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by
moving
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 5 lines
Quoted 2 lines
patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case
you
Quoted 3 lines
would want to merge them into your tree without waiting for them to appear in mainline:
Quoted 7 lines
Quoted 1 line
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitib/4.17-xen-kbdfront-runtime-config
Quoted 3 lines
Thanks.
Thank you,
I would prefer the fastest path of course
It will be part of 4.19 pull request; the immutable branch is for Juergen if he does not want to wait till 4.19 merge window to get the changes.
Thanks.
Signature · 1 line
Dmitry
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
Quoted 50 lines · Dmitry Torokhov
Quoted 49 lines · Oleksandr Andrushchenko
Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines · Juergen Gross
Quoted 2 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by
moving
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 5 lines
Quoted 2 lines
patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case
you
Quoted 3 lines
would want to merge them into your tree without waiting for them to appear in mainline:
Quoted 7 lines
Quoted 6 lines
Quoted 1 line
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitib/4.17-xen-kbdfront-runtime-config
Quoted 2 lines
Thanks.
Thank you,
I would prefer the fastest path of courseIt will be part of 4.19 pull request; the immutable branch is for Juergen if he does not want to wait till 4.19 merge window to get the changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which I assume will be faster?
Quoted 3 lines
Thanks.
Thank you,
Oleksandr
Dmitry Torokhov
maintainerRe: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
Quoted 62 lines · Oleksandr Andrushchenko
Quoted 1 line · Dmitry Torokhov
On June 12, 2018 10:49:31 PM PDT, Oleksandr Andrushchenko
Quoted 12 lines · <[email protected]> wrote:
Quoted 12 lines · Dmitry Torokhov
Quoted 11 lines · Juergen Gross
Quoted 10 lines · Oleksandr Andrushchenko
Quoted 9 lines
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
to be created
- set feature-disable-pointer to 1 if no pointer deviceneeds
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
to be created
3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration
nodes
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
while they belong to backend's configuration. Fix this by
moving
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align
with
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 1 line
Quoted 1 line
patches. In case I should take it via the Xen tree, please send me
a
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in
case
Quoted 5 lines
Quoted 5 lines
you
Quoted 4 lines
would want to merge them into your tree without waiting for them to appear in mainline:
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitQuoted 3 lines
Quoted 3 lines
ib/4.17-xen-kbdfront-runtime-config
Quoted 2 lines
Thanks.
Quoted 7 lines
Quoted 3 lines
Quoted 2 lines
Thank you,
I would prefer the fastest path of courseIt will be part of 4.19 pull request; the immutable branch is for
Juergen if he does not want to wait till 4.19 merge window to get the changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which I assume will be faster?
We are in the tail end of 4.18 merge window so it should not make it in 4.18 no matter what tree the patches will go through.
Thanks.
Signature · 1 line
Dmitry
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
Quoted 63 lines · Dmitry Torokhov
Quoted 62 lines · Oleksandr Andrushchenko
Quoted 1 line · Dmitry Torokhov
On June 12, 2018 10:49:31 PM PDT, Oleksandr Andrushchenko
Quoted 12 lines · <[email protected]> wrote:
Quoted 12 lines · Dmitry Torokhov
Quoted 11 lines · Juergen Gross
Quoted 10 lines · Oleksandr Andrushchenko
Quoted 9 lines
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
to be created
- set feature-disable-pointer to 1 if no pointer deviceneeds
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
to be created
3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration
nodes
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
while they belong to backend's configuration. Fix this by
moving
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align
with
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 1 line
Quoted 1 line
patches. In case I should take it via the Xen tree, please send me
a
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in
case
Quoted 5 lines
Quoted 5 lines
you
Quoted 4 lines
would want to merge them into your tree without waiting for them to appear in mainline:
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitQuoted 3 lines
Quoted 3 lines
ib/4.17-xen-kbdfront-runtime-config
Quoted 2 lines
Thanks.
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 2 lines
Thank you,
I would prefer the fastest path of courseIt will be part of 4.19 pull request; the immutable branch is for
Juergen if he does not want to wait till 4.19 merge window to get the changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which I assume will be faster?We are in the tail end of 4.18 merge window so it should not make it in 4.18 no matter what tree the patches will go through.
Hm, but these are updates and fixes (besides the last patch which adds some more functionality), so I thought this is still good to go in 4.18?
Quoted 3 lines
Thanks.
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Dmitry TorokhovQuoted 63 lines · Dmitry Torokhov
Quoted 62 lines · Oleksandr Andrushchenko
Quoted 1 line · Dmitry Torokhov
On June 12, 2018 10:49:31 PM PDT, Oleksandr Andrushchenko
Quoted 12 lines · <[email protected]> wrote:
Quoted 12 lines · Dmitry Torokhov
Quoted 11 lines · Juergen Gross
Quoted 10 lines · Oleksandr Andrushchenko
Quoted 9 lines
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
to be created
- set feature-disable-pointer to 1 if no pointer deviceneeds
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
to be created
3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration
nodes
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
while they belong to backend's configuration. Fix this by
moving
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align
with
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 1 line
Quoted 1 line
patches. In case I should take it via the Xen tree, please send me
a
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in
case
Quoted 5 lines
Quoted 5 lines
you
Quoted 4 lines
would want to merge them into your tree without waiting for them to appear in mainline:
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitQuoted 3 lines
Quoted 3 lines
ib/4.17-xen-kbdfront-runtime-config
Quoted 2 lines
Thanks.
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 2 lines
Thank you,
I would prefer the fastest path of courseIt will be part of 4.19 pull request; the immutable branch is for
Juergen if he does not want to wait till 4.19 merge window to get the changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which I assume will be faster?We are in the tail end of 4.18 merge window so it should not make it in 4.18 no matter what tree the patches will go through.
Hm, but these are updates and fixes (besides the last patch which adds some more functionality), so I thought this is still good to go in 4.18?
Quoted 3 lines
Thanks.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Dmitry Torokhov
maintainerRe: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Oleksandr AndrushchenkoQuoted 62 lines · Oleksandr Andrushchenko
Quoted 1 line · Dmitry Torokhov
On June 12, 2018 10:49:31 PM PDT, Oleksandr Andrushchenko
Quoted 12 lines · <[email protected]> wrote:
Quoted 12 lines · Dmitry Torokhov
Quoted 11 lines · Juergen Gross
Quoted 10 lines · Oleksandr Andrushchenko
Quoted 9 lines
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
to be created
- set feature-disable-pointer to 1 if no pointer deviceneeds
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
to be created
3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration
nodes
Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
while they belong to backend's configuration. Fix this by
moving
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align
with
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 1 line
Quoted 1 line
patches. In case I should take it via the Xen tree, please send me
a
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in
case
Quoted 5 lines
Quoted 5 lines
you
Quoted 4 lines
would want to merge them into your tree without waiting for them to appear in mainline:
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitQuoted 3 lines
Quoted 3 lines
ib/4.17-xen-kbdfront-runtime-config
Quoted 2 lines
Thanks.
Quoted 7 lines
Quoted 3 lines
Quoted 2 lines
Thank you,
I would prefer the fastest path of courseIt will be part of 4.19 pull request; the immutable branch is for
Juergen if he does not want to wait till 4.19 merge window to get the changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which I assume will be faster?
We are in the tail end of 4.18 merge window so it should not make it in 4.18 no matter what tree the patches will go through.
Thanks.
Signature · 6 lines
Dmitry _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Juergen Gross
maintainerRe: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Oleksandr AndrushchenkoQuoted 56 lines · Oleksandr Andrushchenko
Quoted 55 lines · Dmitry Torokhov
Quoted 53 lines · Oleksandr Andrushchenko
Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines · Juergen Gross
Quoted 2 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by
moving
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 5 lines
Quoted 2 lines
patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case
you
Quoted 4 lines
would want to merge them into your tree without waiting for them to appear in mainline:
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitib/4.17-xen-kbdfront-runtime-config
Quoted 2 lines
Thanks.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Thank you,
I would prefer the fastest path of courseIt will be part of 4.19 pull request; the immutable branch is for Juergen if he does not want to wait till 4.19 merge window to get the changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which I assume will be faster?
As Dmitry has it already queued in the input tree I think this is fine. I trust him to take the right decision for which kernel version those patches are to be queued. They belong to the input tree after all.
Juergen
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
Quoted 59 lines · Juergen Gross
Quoted 58 lines · Oleksandr Andrushchenko
Quoted 57 lines · Dmitry Torokhov
Quoted 55 lines · Oleksandr Andrushchenko
Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines · Juergen Gross
Quoted 2 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by
moving
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 5 lines
Quoted 2 lines
patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case
you
Quoted 4 lines
would want to merge them into your tree without waiting for them to appear in mainline:
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitib/4.17-xen-kbdfront-runtime-config
Quoted 2 lines
Thanks.
Thank you,
I would prefer the fastest path of course
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
It will be part of 4.19 pull request; the immutable branch is for Juergen if he does not want to wait till 4.19 merge window to get the changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which I assume will be faster?
As Dmitry has it already queued in the input tree I think this is fine. I trust him to take the right decision for which kernel version those patches are to be queued. They belong to the input tree after all.
Of course, no doubt here
Quoted 3 lines
Juergen
Thank you,
Oleksandr
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Juergen GrossQuoted 59 lines · Juergen Gross
Quoted 58 lines · Oleksandr Andrushchenko
Quoted 57 lines · Dmitry Torokhov
Quoted 55 lines · Oleksandr Andrushchenko
Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines · Juergen Gross
Quoted 2 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by
moving
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 5 lines
Quoted 2 lines
patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case
you
Quoted 4 lines
would want to merge them into your tree without waiting for them to appear in mainline:
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitib/4.17-xen-kbdfront-runtime-config
Quoted 2 lines
Thanks.
Thank you,
I would prefer the fastest path of course
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
It will be part of 4.19 pull request; the immutable branch is for Juergen if he does not want to wait till 4.19 merge window to get the changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which I assume will be faster?
As Dmitry has it already queued in the input tree I think this is fine. I trust him to take the right decision for which kernel version those patches are to be queued. They belong to the input tree after all.
Of course, no doubt here
Quoted 3 lines
Juergen
Thank you,
Oleksandr
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Juergen Gross
maintainerRe: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Oleksandr AndrushchenkoQuoted 56 lines · Oleksandr Andrushchenko
Quoted 55 lines · Dmitry Torokhov
Quoted 53 lines · Oleksandr Andrushchenko
Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines · Juergen Gross
Quoted 2 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by
moving
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 5 lines
Quoted 2 lines
patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case
you
Quoted 4 lines
would want to merge them into your tree without waiting for them to appear in mainline:
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitib/4.17-xen-kbdfront-runtime-config
Quoted 2 lines
Thanks.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Thank you,
I would prefer the fastest path of courseIt will be part of 4.19 pull request; the immutable branch is for Juergen if he does not want to wait till 4.19 merge window to get the changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which I assume will be faster?
As Dmitry has it already queued in the input tree I think this is fine. I trust him to take the right decision for which kernel version those patches are to be queued. They belong to the input tree after all.
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Dmitry TorokhovQuoted 50 lines · Dmitry Torokhov
Quoted 49 lines · Oleksandr Andrushchenko
Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines · Juergen Gross
Quoted 2 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by
moving
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 5 lines
Quoted 2 lines
patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case
you
Quoted 3 lines
would want to merge them into your tree without waiting for them to appear in mainline:
Quoted 7 lines
Quoted 6 lines
Quoted 1 line
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitib/4.17-xen-kbdfront-runtime-config
Quoted 2 lines
Thanks.
Thank you,
I would prefer the fastest path of courseIt will be part of 4.19 pull request; the immutable branch is for Juergen if he does not want to wait till 4.19 merge window to get the changes.
Ah, I see. Juergen, can we please merge this via Xen tree then which I assume will be faster?
Quoted 3 lines
Thanks.
Thank you,
Oleksandr
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Dmitry Torokhov
maintainerRe: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Oleksandr AndrushchenkoQuoted 49 lines · Oleksandr Andrushchenko
Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines · Juergen Gross
Quoted 2 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to
individually
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard deviceneeds
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by
moving
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Signed-off-by Oleksandr AndrushchenkoQuoted 4 lines
Quoted 4 lines
Quoted 1 line
Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the
other
Quoted 5 lines
Quoted 2 lines
patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case
you
Quoted 3 lines
would want to merge them into your tree without waiting for them to appear in mainline:
Quoted 7 lines
Quoted 1 line
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitib/4.17-xen-kbdfront-runtime-config
Quoted 3 lines
Thanks.
Thank you,
I would prefer the fastest path of course
It will be part of 4.19 pull request; the immutable branch is for Juergen if he does not want to wait till 4.19 merge window to get the changes.
Thanks.
Signature · 6 lines
Dmitry _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Dmitry TorokhovQuoted 38 lines · Dmitry Torokhov
Quoted 28 lines · Juergen Gross
Quoted 27 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Quoted 7 lines
Quoted 2 lines
Signed-off-by Oleksandr Andrushchenko <[email protected]>Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the other patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
Quoted 8 lines
I created an immutable branch off v4.17 with these 3 patches in case you would want to merge them into your tree without waiting for them to appear in mainline:
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.gitib/4.17-xen-kbdfront-runtime-configThanks.
Thank you,
I would prefer the fastest path of course
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Dmitry Torokhov
maintainerRe: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Juergen GrossQuoted 28 lines · Juergen Gross
Quoted 27 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Quoted 8 lines
Quoted 2 lines
Signed-off-by Oleksandr Andrushchenko <[email protected]>Cc Konrad Rzeszutek Wilk <[email protected]>Reviewed-by Juergen Gross <[email protected]>I'm fine with this patch being added via the input tree with the other patches. In case I should take it via the Xen tree, please send me a note.
Juergen,
I created an immutable branch off v4.17 with these 3 patches in case you would want to merge them into your tree without waiting for them to appear in mainline:
git pull git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git ib/4.17-xen-kbdfront-runtime-config
Thanks.
Signature · 6 lines
Dmitry _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH v5 1/3] xen: Sync up with the canonical protocol definitions in Xen
In reply to Oleksandr AndrushchenkoQuoted 21 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.2. Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Quoted 8 lines
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.2. Change type of unique-id field to string for sndif to align with display and input protocols.
Signed-off-by Oleksandr Andrushchenko <[email protected]>Cc Konrad Rzeszutek Wilk <[email protected]>
I'm fine with this patch being added via the input tree with the other patches. In case I should take it via the Xen tree, please send me a note.
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH v5 1/3 xen: Sync up with the canonical protocol definitions in Xen
In reply to Oleksandr AndrushchenkoFrom: Oleksandr Andrushchenko <[email protected]>
This is the sync up with the canonical definitions of the input, sound and display protocols in Xen.
Changes to kbdif:
1. Add missing string constants for {feature|request}-raw-pointer to align with the rest of the interface file.
2. Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-disable-keyboard to 1 if no keyboard device needs to be created
- set feature-disable-pointer to 1 if no pointer device needs to be created
3. Move multi-touch device parameters to backend nodes: these are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Unique-id field:
1. Add unique-id XenBus entry for virtual input and display.
2. Change type of unique-id field to string for sndif to align with display and input protocols.
--- include/xen/interface/io/displif.h | 8 +++ include/xen/interface/io/kbdif.h | 78 ++++++++++++++++++++++-------- include/xen/interface/io/sndif.h | 10 ++-- 3 files changed, 71 insertions(+), 25 deletions(-)
include/xen/interface/io/displif.h +8 -0
@@ -189,6 +189,13 @@ * *----------------------------- Connector settings ---------------------------- * + * unique-id + * Values: <string> + * + * After device instance initialization each connector is assigned a + * unique ID, so it can be identified by the backend by this ID. + * This can be UUID or such. + * * resolution * Values: <width, uint32_t>x<height, uint32_t> *
@@ -368,6 +375,7 @@#define XENDISPL_FIELD_EVT_CHANNEL "evt-event-channel"#define XENDISPL_FIELD_RESOLUTION "resolution"#define XENDISPL_FIELD_BE_ALLOC "be-alloc" +#define XENDISPL_FIELD_UNIQUE_ID "unique-id"/* ******************************************************************************
include/xen/interface/io/kbdif.h +59 -19
123 lines not on this page · raw message
include/xen/interface/io/sndif.h +4 -6
@@ -278,13 +278,11 @@* defined under the same device. * * unique-id -* Values: <uint32_t> +* Values: <string> * -* After stream initialization it is assigned a unique ID (within the front -* driver), so every stream of the frontend can be identified by the -* backend by this ID. This is not equal to stream-idx as the later is -* zero based within the device, but this index is contigous within the -* driver. +* After stream initialization it is assigned a unique ID, so every +* stream of the frontend can be identified by the backend by this ID. +* This can be UUID or such. * *-------------------- Stream Request Transport Parameters -------------------- *
Signature · 7 lines
2.17.1 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH v5 2/3 Input: xen-kbdfront - fix multi-touch XenStore node's locations
In reply to Oleksandr AndrushchenkoFrom: Oleksandr Andrushchenko <[email protected]>
kbdif protocol describes multi-touch device parameters as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by reading the parameters as defined by the protocol.
--- drivers/input/misc/xen-kbdfront.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/input/misc/xen-kbdfront.c +4 -4
@@ -229,7 +229,7 @@ static int xenkbd_probe(struct xenbus_device *dev, } } - touch =xenbus_read_unsigned (dev->nodename, + touch =xenbus_read_unsigned (dev->otherend,XENKBD_FIELD_FEAT_MTOUCH ,0 );if (touch) { ret = xenbus_write(XBT_NIL, dev->nodename,
@@ -304,13 +304,13 @@ static int xenkbd_probe(struct xenbus_device *dev,if (!mtouch) goto error_nomem; - num_cont =xenbus_read_unsigned (info->xbdev->nodename, + num_cont =xenbus_read_unsigned (info->xbdev->otherend,XENKBD_FIELD_MT_NUM_CONTACTS ,1 ); - width =xenbus_read_unsigned (info->xbdev->nodename, + width =xenbus_read_unsigned (info->xbdev->otherend,XENKBD_FIELD_MT_WIDTH ,XENFB_WIDTH ); - height =xenbus_read_unsigned (info->xbdev->nodename, + height =xenbus_read_unsigned (info->xbdev->otherend,XENKBD_FIELD_MT_HEIGHT ,XENFB_HEIGHT );
Signature · 1 line
2.17.1
Re: [PATCH v5 2/3] Input: xen-kbdfront - fix multi-touch XenStore node's locations
Quoted 10 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
kbdif protocol describes multi-touch device parameters as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by reading the parameters as defined by the protocol.
Fixes 49aac8204da5 ("Input: xen-kbdfront - add multi-touch support")Signed-off-by Oleksandr Andrushchenko <[email protected]>
Juergen
Re: [PATCH v5 2/3] Input: xen-kbdfront - fix multi-touch XenStore node's locations
In reply to Oleksandr AndrushchenkoQuoted 10 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
kbdif protocol describes multi-touch device parameters as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by reading the parameters as defined by the protocol.
Fixes 49aac8204da5 ("Input: xen-kbdfront - add multi-touch support")Signed-off-by Oleksandr Andrushchenko <[email protected]>
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH v5 2/3 Input: xen-kbdfront - fix multi-touch XenStore node's locations
In reply to Oleksandr AndrushchenkoFrom: Oleksandr Andrushchenko <[email protected]>
kbdif protocol describes multi-touch device parameters as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by reading the parameters as defined by the protocol.
--- drivers/input/misc/xen-kbdfront.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/input/misc/xen-kbdfront.c +4 -4
@@ -229,7 +229,7 @@ static int xenkbd_probe(struct xenbus_device *dev, } } - touch =xenbus_read_unsigned (dev->nodename, + touch =xenbus_read_unsigned (dev->otherend,XENKBD_FIELD_FEAT_MTOUCH ,0 );if (touch) { ret = xenbus_write(XBT_NIL, dev->nodename,
@@ -304,13 +304,13 @@ static int xenkbd_probe(struct xenbus_device *dev,if (!mtouch) goto error_nomem; - num_cont =xenbus_read_unsigned (info->xbdev->nodename, + num_cont =xenbus_read_unsigned (info->xbdev->otherend,XENKBD_FIELD_MT_NUM_CONTACTS ,1 ); - width =xenbus_read_unsigned (info->xbdev->nodename, + width =xenbus_read_unsigned (info->xbdev->otherend,XENKBD_FIELD_MT_WIDTH ,XENFB_WIDTH ); - height =xenbus_read_unsigned (info->xbdev->nodename, + height =xenbus_read_unsigned (info->xbdev->otherend,XENKBD_FIELD_MT_HEIGHT ,XENFB_HEIGHT );
Signature · 7 lines
2.17.1 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH v5 3/3 Input: xen-kbdfront - allow better run-time configuration
In reply to Oleksandr AndrushchenkoFrom: Oleksandr Andrushchenko <[email protected]>
It is now only possible to control if multi-touch virtual device is created or not (via the corresponding XenStore entries), but keyboard and pointer devices are always created. In some cases this is not desirable. For example, if virtual keyboard device is exposed to Android then the latter won't automatically show on-screen keyboard as it expects that a physical keyboard device can be used for typing.
Utilize keyboard and pointer device XenStore feature fields to configure which virtual devices are created:
- set "feature-disable-keyboard" to 1 if no keyboard device needs to be created
- set "feature-disable-pointer" to 1 if no pointer device needs to be created
Keep old behavior by default.
--- drivers/input/misc/xen-kbdfront.c | 177 ++++++++++++++++++------------ 1 file changed, 106 insertions(+), 71 deletions(-)
drivers/input/misc/xen-kbdfront.c +106 -71
@@ -63,6 +63,9 @@ static void xenkbd_disconnect_backend(struct xenkbd_info *);static void xenkbd_handle_motion_event (struct xenkbd_info *info,struct xenkbd_motion *motion) { +if (unlikely (!info->ptr)) +return ; +input_report_rel (info->ptr,REL_X , motion->rel_x);input_report_rel (info->ptr,REL_Y , motion->rel_y);if (motion->rel_z)
@@ -73,6 +76,9 @@ static void xenkbd_handle_motion_event(struct xenkbd_info *info,static void xenkbd_handle_position_event (struct xenkbd_info *info,struct xenkbd_position *pos) { +if (unlikely (!info->ptr)) +return ; +input_report_abs (info->ptr,ABS_X , pos->abs_x);input_report_abs (info->ptr,ABS_Y , pos->abs_y);if (pos->rel_z)
@@ -97,6 +103,9 @@ static void xenkbd_handle_key_event(struct xenkbd_info *info,return ; } +if (unlikely (!dev)) +return ; +input_event (dev,EV_KEY , key->keycode, value);input_sync (dev); }
@@ -192,7 +201,7 @@ static int xenkbd_probe(struct xenbus_device *dev, const struct xenbus_device_id *id) {int ret, i; -unsigned int abs, touch; +bool with_mtouch, with_kbd, with_ptr;struct xenkbd_info *info;struct input_dev *kbd, *ptr, *mtouch;
@@ -211,93 +220,114 @@ static int xenkbd_probe(struct xenbus_device *dev,if (!info->page) goto error_nomem; -/* Set input abs params to match backend screen res */ - abs =xenbus_read_unsigned (dev->otherend, -XENKBD_FIELD_FEAT_ABS_POINTER ,0 ); - ptr_size[KPARAM_X ] =xenbus_read_unsigned (dev->otherend, -XENKBD_FIELD_WIDTH , - ptr_size[KPARAM_X ]); - ptr_size[KPARAM_Y ] =xenbus_read_unsigned (dev->otherend, -XENKBD_FIELD_HEIGHT , - ptr_size[KPARAM_Y ]); -if (abs) { - ret =xenbus_write (XBT_NIL , dev->nodename, -XENKBD_FIELD_REQ_ABS_POINTER ,"1" ); -if (ret) { -pr_warn ("xenkbd: can't request abs-pointer\n" ); - abs =0 ; - } - } +/* +* The below are reverse logic, e.g. if the feature is set, then +* do not expose the corresponding virtual device. +*/ + with_kbd = !xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_FEAT_DSBL_KEYBRD ,0 ); + + with_ptr = !xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_FEAT_DSBL_POINTER ,0 ); - touch =xenbus_read_unsigned (dev->otherend, -XENKBD_FIELD_FEAT_MTOUCH ,0 ); -if (touch) { +/* Direct logic: if set, then create multi-touch device. */ + with_mtouch =xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_FEAT_MTOUCH ,0 ); +if (with_mtouch) { ret =xenbus_write (XBT_NIL , dev->nodename,XENKBD_FIELD_REQ_MTOUCH ,"1" );if (ret) {pr_warn ("xenkbd: can't request multi-touch" ); - touch =0 ; + with_mtouch =0 ; } }/* keyboard */ - kbd =input_allocate_device (); -if (!kbd) - goto error_nomem; - kbd->name ="Xen Virtual Keyboard" ; - kbd->phys = info->phys; - kbd->id.bustype =BUS_PCI ; - kbd->id.vendor =0x5853 ; - kbd->id.product =0xffff ; - -__set_bit (EV_KEY , kbd->evbit); -for (i =KEY_ESC ; i <KEY_UNKNOWN ; i++) -__set_bit (i, kbd->keybit); -for (i =KEY_OK ; i <KEY_MAX ; i++) -__set_bit (i, kbd->keybit); - - ret =input_register_device (kbd); -if (ret) { -input_free_device (kbd); -xenbus_dev_fatal (dev, ret,"input_register_device(kbd)" ); - goto error; +if (with_kbd) { + kbd =input_allocate_device (); +if (!kbd) + goto error_nomem; + kbd->name ="Xen Virtual Keyboard" ; + kbd->phys = info->phys; + kbd->id.bustype =BUS_PCI ; + kbd->id.vendor =0x5853 ; + kbd->id.product =0xffff ; + +__set_bit (EV_KEY , kbd->evbit); +for (i =KEY_ESC ; i <KEY_UNKNOWN ; i++) +__set_bit (i, kbd->keybit); +for (i =KEY_OK ; i <KEY_MAX ; i++) +__set_bit (i, kbd->keybit); + + ret =input_register_device (kbd); +if (ret) { +input_free_device (kbd); +xenbus_dev_fatal (dev, ret, +"input_register_device(kbd)" ); + goto error; + } + info->kbd = kbd; } - info->kbd = kbd;/* pointing device */ - ptr =input_allocate_device (); -if (!ptr) - goto error_nomem; - ptr->name ="Xen Virtual Pointer" ; - ptr->phys = info->phys; - ptr->id.bustype =BUS_PCI ; - ptr->id.vendor =0x5853 ; - ptr->id.product =0xfffe ; - -if (abs) { -__set_bit (EV_ABS , ptr->evbit); -input_set_abs_params (ptr,ABS_X ,0 , ptr_size[KPARAM_X ],0 ,0 ); -input_set_abs_params (ptr,ABS_Y ,0 , ptr_size[KPARAM_Y ],0 ,0 ); - }else { -input_set_capability (ptr,EV_REL ,REL_X ); -input_set_capability (ptr,EV_REL ,REL_Y ); - } -input_set_capability (ptr,EV_REL ,REL_WHEEL ); +if (with_ptr) { +unsigned int abs; + +/* Set input abs params to match backend screen res */ + abs =xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_FEAT_ABS_POINTER ,0 ); + ptr_size[KPARAM_X ] =xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_WIDTH , + ptr_size[KPARAM_X ]); + ptr_size[KPARAM_Y ] =xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_HEIGHT , + ptr_size[KPARAM_Y ]); +if (abs) { + ret =xenbus_write (XBT_NIL , dev->nodename, +XENKBD_FIELD_REQ_ABS_POINTER ,"1" ); +if (ret) { +pr_warn ("xenkbd: can't request abs-pointer\n" ); + abs =0 ; + } + } -__set_bit (EV_KEY , ptr->evbit); -for (i =BTN_LEFT ; i <=BTN_TASK ; i++) -__set_bit (i, ptr->keybit); + ptr =input_allocate_device (); +if (!ptr) + goto error_nomem; + ptr->name ="Xen Virtual Pointer" ; + ptr->phys = info->phys; + ptr->id.bustype =BUS_PCI ; + ptr->id.vendor =0x5853 ; + ptr->id.product =0xfffe ; + +if (abs) { +__set_bit (EV_ABS , ptr->evbit); +input_set_abs_params (ptr,ABS_X ,0 , + ptr_size[KPARAM_X ],0 ,0 ); +input_set_abs_params (ptr,ABS_Y ,0 , + ptr_size[KPARAM_Y ],0 ,0 ); + }else { +input_set_capability (ptr,EV_REL ,REL_X ); +input_set_capability (ptr,EV_REL ,REL_Y ); + } +input_set_capability (ptr,EV_REL ,REL_WHEEL ); - ret =input_register_device (ptr); -if (ret) { -input_free_device (ptr); -xenbus_dev_fatal (dev, ret,"input_register_device(ptr)" ); - goto error; +__set_bit (EV_KEY , ptr->evbit); +for (i =BTN_LEFT ; i <=BTN_TASK ; i++) +__set_bit (i, ptr->keybit); + + ret =input_register_device (ptr); +if (ret) { +input_free_device (ptr); +xenbus_dev_fatal (dev, ret, +"input_register_device(ptr)" ); + goto error; + } + info->ptr = ptr; } - info->ptr = ptr;/* multi-touch device */ -if (touch) { +if (with_mtouch) {int num_cont, width, height; mtouch =input_allocate_device ();
@@ -346,6 +376,11 @@ static int xenkbd_probe(struct xenbus_device *dev, info->mtouch = mtouch; } +if (!(with_kbd | with_ptr | with_mtouch)) { + ret = -ENXIO ; + goto error; + } + ret =xenkbd_connect_backend (dev, info);if (ret <0 ) goto error;
Signature · 1 line
2.17.1
Quoted 18 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
It is now only possible to control if multi-touch virtual device is created or not (via the corresponding XenStore entries), but keyboard and pointer devices are always created. In some cases this is not desirable. For example, if virtual keyboard device is exposed to Android then the latter won't automatically show on-screen keyboard as it expects that a physical keyboard device can be used for typing.
Utilize keyboard and pointer device XenStore feature fields to configure which virtual devices are created:
- set "feature-disable-keyboard" to 1 if no keyboard device needs to be created
- set "feature-disable-pointer" to 1 if no pointer device needs to be created
Keep old behavior by default.
Quoted 3 lines
Signed-off-by Oleksandr Andrushchenko <[email protected]>Suggested-by Andrii Chepurnyi <[email protected]>Tested-by Andrii Chepurnyi <[email protected]>
Juergen
Quoted 18 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
It is now only possible to control if multi-touch virtual device is created or not (via the corresponding XenStore entries), but keyboard and pointer devices are always created. In some cases this is not desirable. For example, if virtual keyboard device is exposed to Android then the latter won't automatically show on-screen keyboard as it expects that a physical keyboard device can be used for typing.
Utilize keyboard and pointer device XenStore feature fields to configure which virtual devices are created:
- set "feature-disable-keyboard" to 1 if no keyboard device needs to be created
- set "feature-disable-pointer" to 1 if no pointer device needs to be created
Keep old behavior by default.
Quoted 3 lines
Signed-off-by Oleksandr Andrushchenko <[email protected]>Suggested-by Andrii Chepurnyi <[email protected]>Tested-by Andrii Chepurnyi <[email protected]>
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Dmitry Torokhov
maintainerdrivers/input/misc/xen-kbdfront.c static int xenkbd_probe(struct xenbus_device *dev, · line 379
Quoted 2 lines · Oleksandr Andrushchenko
drivers/input/misc/xen-kbdfront.c +1
-0+if (!(with_kbd | with_ptr | with_mtouch)) {
I changed this to logical "OR" and applied, thank you.
Quoted 10 lines
drivers/input/misc/xen-kbdfront.c +4
-0+ ret = -ENXIO ; + goto error; + } + ret =xenkbd_connect_backend (dev, info);if (ret <0 ) goto error;Signature · 1 line
2.17.1
Signature · 1 line
Dmitry
Quoted 4 lines · Dmitry Torokhov
drivers/input/misc/xen-kbdfront.c static int xenkbd_probe(struct xenbus_device *dev, · line 379
Quoted 2 lines · Oleksandr Andrushchenko
drivers/input/misc/xen-kbdfront.c +1
-0+if (!(with_kbd | with_ptr | with_mtouch)) {I changed this to logical "OR" and applied, thank you.
Yes, that's better, thank you
Quoted 10 lines
Quoted 10 lines
drivers/input/misc/xen-kbdfront.c +4
-0+ ret = -ENXIO ; + goto error; + } + ret =xenkbd_connect_backend (dev, info);if (ret <0 ) goto error;Signature · 1 line
2.17.1
Quoted 4 lines · Dmitry Torokhov
drivers/input/misc/xen-kbdfront.c static int xenkbd_probe(struct xenbus_device *dev, · line 379
Quoted 2 lines · Oleksandr Andrushchenko
drivers/input/misc/xen-kbdfront.c +1
-0+if (!(with_kbd | with_ptr | with_mtouch)) {I changed this to logical "OR" and applied, thank you.
Yes, that's better, thank you
Quoted 10 lines
Quoted 10 lines
drivers/input/misc/xen-kbdfront.c +4
-0+ ret = -ENXIO ; + goto error; + } + ret =xenkbd_connect_backend (dev, info);if (ret <0 ) goto error;Signature · 1 line
2.17.1
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Dmitry Torokhov
maintainerdrivers/input/misc/xen-kbdfront.c static int xenkbd_probe(struct xenbus_device *dev, · line 379
Quoted 2 lines · Oleksandr Andrushchenko
drivers/input/misc/xen-kbdfront.c +1
-0+if (!(with_kbd | with_ptr | with_mtouch)) {
I changed this to logical "OR" and applied, thank you.
Quoted 10 lines
drivers/input/misc/xen-kbdfront.c +4
-0+ ret = -ENXIO ; + goto error; + } + ret =xenkbd_connect_backend (dev, info);if (ret <0 ) goto error;Signature · 1 line
2.17.1
Signature · 6 lines
Dmitry _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH v5 3/3 Input: xen-kbdfront - allow better run-time configuration
In reply to Oleksandr AndrushchenkoFrom: Oleksandr Andrushchenko <[email protected]>
It is now only possible to control if multi-touch virtual device is created or not (via the corresponding XenStore entries), but keyboard and pointer devices are always created. In some cases this is not desirable. For example, if virtual keyboard device is exposed to Android then the latter won't automatically show on-screen keyboard as it expects that a physical keyboard device can be used for typing.
Utilize keyboard and pointer device XenStore feature fields to configure which virtual devices are created:
- set "feature-disable-keyboard" to 1 if no keyboard device needs to be created
- set "feature-disable-pointer" to 1 if no pointer device needs to be created
Keep old behavior by default.
--- drivers/input/misc/xen-kbdfront.c | 177 ++++++++++++++++++------------ 1 file changed, 106 insertions(+), 71 deletions(-)
drivers/input/misc/xen-kbdfront.c +106 -71
@@ -63,6 +63,9 @@ static void xenkbd_disconnect_backend(struct xenkbd_info *);static void xenkbd_handle_motion_event (struct xenkbd_info *info,struct xenkbd_motion *motion) { +if (unlikely (!info->ptr)) +return ; +input_report_rel (info->ptr,REL_X , motion->rel_x);input_report_rel (info->ptr,REL_Y , motion->rel_y);if (motion->rel_z)
@@ -73,6 +76,9 @@ static void xenkbd_handle_motion_event(struct xenkbd_info *info,static void xenkbd_handle_position_event (struct xenkbd_info *info,struct xenkbd_position *pos) { +if (unlikely (!info->ptr)) +return ; +input_report_abs (info->ptr,ABS_X , pos->abs_x);input_report_abs (info->ptr,ABS_Y , pos->abs_y);if (pos->rel_z)
@@ -97,6 +103,9 @@ static void xenkbd_handle_key_event(struct xenkbd_info *info,return ; } +if (unlikely (!dev)) +return ; +input_event (dev,EV_KEY , key->keycode, value);input_sync (dev); }
@@ -192,7 +201,7 @@ static int xenkbd_probe(struct xenbus_device *dev, const struct xenbus_device_id *id) {int ret, i; -unsigned int abs, touch; +bool with_mtouch, with_kbd, with_ptr;struct xenkbd_info *info;struct input_dev *kbd, *ptr, *mtouch;
@@ -211,93 +220,114 @@ static int xenkbd_probe(struct xenbus_device *dev,if (!info->page) goto error_nomem; -/* Set input abs params to match backend screen res */ - abs =xenbus_read_unsigned (dev->otherend, -XENKBD_FIELD_FEAT_ABS_POINTER ,0 ); - ptr_size[KPARAM_X ] =xenbus_read_unsigned (dev->otherend, -XENKBD_FIELD_WIDTH , - ptr_size[KPARAM_X ]); - ptr_size[KPARAM_Y ] =xenbus_read_unsigned (dev->otherend, -XENKBD_FIELD_HEIGHT , - ptr_size[KPARAM_Y ]); -if (abs) { - ret =xenbus_write (XBT_NIL , dev->nodename, -XENKBD_FIELD_REQ_ABS_POINTER ,"1" ); -if (ret) { -pr_warn ("xenkbd: can't request abs-pointer\n" ); - abs =0 ; - } - } +/* +* The below are reverse logic, e.g. if the feature is set, then +* do not expose the corresponding virtual device. +*/ + with_kbd = !xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_FEAT_DSBL_KEYBRD ,0 ); + + with_ptr = !xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_FEAT_DSBL_POINTER ,0 ); - touch =xenbus_read_unsigned (dev->otherend, -XENKBD_FIELD_FEAT_MTOUCH ,0 ); -if (touch) { +/* Direct logic: if set, then create multi-touch device. */ + with_mtouch =xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_FEAT_MTOUCH ,0 ); +if (with_mtouch) { ret =xenbus_write (XBT_NIL , dev->nodename,XENKBD_FIELD_REQ_MTOUCH ,"1" );if (ret) {pr_warn ("xenkbd: can't request multi-touch" ); - touch =0 ; + with_mtouch =0 ; } }/* keyboard */ - kbd =input_allocate_device (); -if (!kbd) - goto error_nomem; - kbd->name ="Xen Virtual Keyboard" ; - kbd->phys = info->phys; - kbd->id.bustype =BUS_PCI ; - kbd->id.vendor =0x5853 ; - kbd->id.product =0xffff ; - -__set_bit (EV_KEY , kbd->evbit); -for (i =KEY_ESC ; i <KEY_UNKNOWN ; i++) -__set_bit (i, kbd->keybit); -for (i =KEY_OK ; i <KEY_MAX ; i++) -__set_bit (i, kbd->keybit); - - ret =input_register_device (kbd); -if (ret) { -input_free_device (kbd); -xenbus_dev_fatal (dev, ret,"input_register_device(kbd)" ); - goto error; +if (with_kbd) { + kbd =input_allocate_device (); +if (!kbd) + goto error_nomem; + kbd->name ="Xen Virtual Keyboard" ; + kbd->phys = info->phys; + kbd->id.bustype =BUS_PCI ; + kbd->id.vendor =0x5853 ; + kbd->id.product =0xffff ; + +__set_bit (EV_KEY , kbd->evbit); +for (i =KEY_ESC ; i <KEY_UNKNOWN ; i++) +__set_bit (i, kbd->keybit); +for (i =KEY_OK ; i <KEY_MAX ; i++) +__set_bit (i, kbd->keybit); + + ret =input_register_device (kbd); +if (ret) { +input_free_device (kbd); +xenbus_dev_fatal (dev, ret, +"input_register_device(kbd)" ); + goto error; + } + info->kbd = kbd; } - info->kbd = kbd;/* pointing device */ - ptr =input_allocate_device (); -if (!ptr) - goto error_nomem; - ptr->name ="Xen Virtual Pointer" ; - ptr->phys = info->phys; - ptr->id.bustype =BUS_PCI ; - ptr->id.vendor =0x5853 ; - ptr->id.product =0xfffe ; - -if (abs) { -__set_bit (EV_ABS , ptr->evbit); -input_set_abs_params (ptr,ABS_X ,0 , ptr_size[KPARAM_X ],0 ,0 ); -input_set_abs_params (ptr,ABS_Y ,0 , ptr_size[KPARAM_Y ],0 ,0 ); - }else { -input_set_capability (ptr,EV_REL ,REL_X ); -input_set_capability (ptr,EV_REL ,REL_Y ); - } -input_set_capability (ptr,EV_REL ,REL_WHEEL ); +if (with_ptr) { +unsigned int abs; + +/* Set input abs params to match backend screen res */ + abs =xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_FEAT_ABS_POINTER ,0 ); + ptr_size[KPARAM_X ] =xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_WIDTH , + ptr_size[KPARAM_X ]); + ptr_size[KPARAM_Y ] =xenbus_read_unsigned (dev->otherend, +XENKBD_FIELD_HEIGHT , + ptr_size[KPARAM_Y ]); +if (abs) { + ret =xenbus_write (XBT_NIL , dev->nodename, +XENKBD_FIELD_REQ_ABS_POINTER ,"1" ); +if (ret) { +pr_warn ("xenkbd: can't request abs-pointer\n" ); + abs =0 ; + } + } -__set_bit (EV_KEY , ptr->evbit); -for (i =BTN_LEFT ; i <=BTN_TASK ; i++) -__set_bit (i, ptr->keybit); + ptr =input_allocate_device (); +if (!ptr) + goto error_nomem; + ptr->name ="Xen Virtual Pointer" ; + ptr->phys = info->phys; + ptr->id.bustype =BUS_PCI ; + ptr->id.vendor =0x5853 ; + ptr->id.product =0xfffe ; + +if (abs) { +__set_bit (EV_ABS , ptr->evbit); +input_set_abs_params (ptr,ABS_X ,0 , + ptr_size[KPARAM_X ],0 ,0 ); +input_set_abs_params (ptr,ABS_Y ,0 , + ptr_size[KPARAM_Y ],0 ,0 ); + }else { +input_set_capability (ptr,EV_REL ,REL_X ); +input_set_capability (ptr,EV_REL ,REL_Y ); + } +input_set_capability (ptr,EV_REL ,REL_WHEEL ); - ret =input_register_device (ptr); -if (ret) { -input_free_device (ptr); -xenbus_dev_fatal (dev, ret,"input_register_device(ptr)" ); - goto error; +__set_bit (EV_KEY , ptr->evbit); +for (i =BTN_LEFT ; i <=BTN_TASK ; i++) +__set_bit (i, ptr->keybit); + + ret =input_register_device (ptr); +if (ret) { +input_free_device (ptr); +xenbus_dev_fatal (dev, ret, +"input_register_device(ptr)" ); + goto error; + } + info->ptr = ptr; } - info->ptr = ptr;/* multi-touch device */ -if (touch) { +if (with_mtouch) {int num_cont, width, height; mtouch =input_allocate_device ();
@@ -346,6 +376,11 @@ static int xenkbd_probe(struct xenbus_device *dev, info->mtouch = mtouch; } +if (!(with_kbd | with_ptr | with_mtouch)) { + ret = -ENXIO ; + goto error; + } + ret =xenkbd_connect_backend (dev, info);if (ret <0 ) goto error;
Signature · 7 lines
2.17.1 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel