Skip to contentSkip to conversation

HID: wacom: Correct logical maximum Y for 2nd-gen Intuos Pro large

PATCH Applied Jason Gerecke 2 participants 2 messages Jun 12, 2018 – Jun 13, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: wacom: Correct logical maximum Y for 2nd-gen Intuos Pro large

The HID descriptor for the 2nd-gen Intuos Pro large (PTH-860) contains a typo which defines an incorrect logical maximum Y value. This causes a small portion of the bottom of the tablet to become unusable (both because the area is below the "bottom" of the tablet and because 'wacom_wac_event' ignores out-of-range values). It also results in a skewed aspect ratio.

To fix this, we add a quirk to 'wacom_usage_mapping' which overwrites the data with the correct value.

---
 drivers/hid/wacom_sys.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/hid/wacom_sys.c +8 -0
index ee7a37eb159a..545986cfb978 100644
@@ -395,6 +395,14 @@ static void wacom_usage_mapping(struct hid_device *hdev,
 		}
 	}
 
+	/* 2nd-generation Intuos Pro Large has incorrect Y maximum */
+	if (hdev->vendor == USB_VENDOR_ID_WACOM &&
+	    hdev->product == 0x0358 &&
+	    WACOM_PEN_FIELD(field) &&
+	    wacom_equivalent_usage(usage->hid) == HID_GD_Y) {
+		field->logical_maximum = 43200;
+	}
+
 	switch (usage->hid) {
 	case HID_GD_X:
 		features->x_max = field->logical_maximum;
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 7 lines · Jason Gerecke

The HID descriptor for the 2nd-gen Intuos Pro large (PTH-860) contains a typo which defines an incorrect logical maximum Y value. This causes a small portion of the bottom of the tablet to become unusable (both because the area is below the "bottom" of the tablet and because 'wacom_wac_event' ignores out-of-range values). It also results in a skewed aspect ratio.

Quoted 5 lines

To fix this, we add a quirk to 'wacom_usage_mapping' which overwrites the data with the correct value.

Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs