Skip to contentSkip to conversation

selftests: sparc64: Fix to do nothing on non-sparc64

PATCH In review Shuah Khan (Samsung OSG) 3 participants 5 messages Jun 12, 2018 – Jun 15, 2018 Kselftest

lore
Share & tools
lore

Shuah Khan (Samsung OSG)

author maintainer
#0 lore raw

PATCH 1/1 selftests: sparc64: Fix to do nothing on non-sparc64

sparc64 test fails with the following errors on non-sparc64 systems. Fix the Makefile to do nothing on non-sparc64 systems to suppress the errors:

make run_tests
adi-test.c: Assembler messages:
adi-test.c:302: Error: no such instruction: rd %tick,%r13' adi-test.c:304: Error: no such instruction: rd %tick,%rbp' adi-test.c:190: Error: no such instruction: rd %tick,%rbp' adi-test.c:192: Error: no such instruction: rd %tick,%rdx' adi-test.c:273: Error: no such instruction: rd %tick,%rbx' adi-test.c:276: Error: no such instruction: rd %tick,%rdx' adi-test.c:217: Error: no such instruction: rd %tick,%rbp' adi-test.c:220: Error: no such instruction: rd %tick,%rdx' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:246: Error: no such instruction: rd %tick,%rbp' adi-test.c:248: Error: no such instruction: rd %tick,%rdx' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' <builtin>: recipe for target 'adi-test' failed make[1]: *** [adi-test] Error 1
adi: [FAIL]
./drivers_test.sh: 24: ./drivers_test.sh: ./adi-test: not found ../lib.mk:73: recipe for target 'run_tests' failed
make: *** [run_tests] Error 1

Signed-off-by Shuah Khan (Samsung OSG) <shuah at kernel.org>
---
 tools/testing/selftests/sparc64/Makefile | 11 +++++++++++
 1 file changed, 11 insertions(+)
tools/testing/selftests/sparc64/Makefile +11 -0
index 2082eeffd779..442f0ca45441 100644
@@ -1,7 +1,17 @@
+uname_M := $(shell uname -m 2>/dev/null || echo not)
+ARCH ?= $(shell echo $(uname_M) | sed -e s/x86_64/x86/)
+
+ifneq ($(ARCH),sparc64)
+nothing:
+.PHONY: all clean run_tests install
+.SILENT:
+else
+
 SUBDIRS := drivers
 
 TEST_PROGS := run.sh
 
+
 .PHONY: all clean
 
 include ../lib.mk
@@ -44,3 +54,4 @@ override define CLEAN
 		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
 	done
 endef
+endif
Signature · 6 lines
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reviewed-by on v1 1/1
#1 lore raw

Thanks, Shuah!

Tom

Quoted 29 lines · Shuah Khan (Samsung OSG)

sparc64 test fails with the following errors on non-sparc64 systems. Fix the Makefile to do nothing on non-sparc64 systems to suppress the errors:

make run_tests
adi-test.c: Assembler messages:
adi-test.c:302: Error: no such instruction: rd %tick,%r13' adi-test.c:304: Error: no such instruction: rd %tick,%rbp' adi-test.c:190: Error: no such instruction: rd %tick,%rbp' adi-test.c:192: Error: no such instruction: rd %tick,%rdx' adi-test.c:273: Error: no such instruction: rd %tick,%rbx' adi-test.c:276: Error: no such instruction: rd %tick,%rdx' adi-test.c:217: Error: no such instruction: rd %tick,%rbp' adi-test.c:220: Error: no such instruction: rd %tick,%rdx' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:246: Error: no such instruction: rd %tick,%rbp' adi-test.c:248: Error: no such instruction: rd %tick,%rdx' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' <builtin>: recipe for target 'adi-test' failed make[1]: *** [adi-test] Error 1
adi: [FAIL]
./drivers_test.sh: 24: ./drivers_test.sh: ./adi-test: not found ../lib.mk:73: recipe for target 'run_tests' failed
make: *** [run_tests] Error 1

Quoted 1 line
Signed-off-by Shuah Khan (Samsung OSG) <shuah at kernel.org>

Reviewed-by: Tom Hromatka <tom.hromatka at oracle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#2 lore raw
Quoted 35 lines · Tom Hromatka

Thanks, Shuah!

Tom

Quoted 29 lines · Shuah Khan (Samsung OSG)

sparc64 test fails with the following errors on non-sparc64 systems. Fix the Makefile to do nothing on non-sparc64 systems to suppress the errors:

make run_tests
adi-test.c: Assembler messages:
adi-test.c:302: Error: no such instruction: rd %tick,%r13' adi-test.c:304: Error: no such instruction: rd %tick,%rbp' adi-test.c:190: Error: no such instruction: rd %tick,%rbp' adi-test.c:192: Error: no such instruction: rd %tick,%rdx' adi-test.c:273: Error: no such instruction: rd %tick,%rbx' adi-test.c:276: Error: no such instruction: rd %tick,%rdx' adi-test.c:217: Error: no such instruction: rd %tick,%rbp' adi-test.c:220: Error: no such instruction: rd %tick,%rdx' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:246: Error: no such instruction: rd %tick,%rbp' adi-test.c:248: Error: no such instruction: rd %tick,%rdx' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' <builtin>: recipe for target 'adi-test' failed make[1]: *** [adi-test] Error 1
adi: [FAIL]
./drivers_test.sh: 24: ./drivers_test.sh: ./adi-test: not found ../lib.mk:73: recipe for target 'run_tests' failed
make: *** [run_tests] Error 1

Quoted 4 lines
Quoted 1 line
Signed-off-by Shuah Khan (Samsung OSG) <shuah at kernel.org>
Reviewed-by Tom Hromatka <tom.hromatka at oracle.com>

Hi Dave,

get_maintainers didn't include your name for this patch. Would you like to take this fix through sparc tree? It would be good to get this in for 4.18-rc2

If so, please let me know if you would like me to resend the patch with Tom's Reviewed-by tag.

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Acked-by David S. Miller
#3 lore raw

From: Shuah Khan <[email protected]>
Date: Fri, 15 Jun 2018 10:33:21 -0600

Quoted 41 lines · Tom Hromatka
Quoted 35 lines

Thanks, Shuah!

Tom

Quoted 29 lines · Shuah Khan (Samsung OSG)

sparc64 test fails with the following errors on non-sparc64 systems. Fix the Makefile to do nothing on non-sparc64 systems to suppress the errors:

make run_tests
adi-test.c: Assembler messages:
adi-test.c:302: Error: no such instruction: rd %tick,%r13' adi-test.c:304: Error: no such instruction: rd %tick,%rbp' adi-test.c:190: Error: no such instruction: rd %tick,%rbp' adi-test.c:192: Error: no such instruction: rd %tick,%rdx' adi-test.c:273: Error: no such instruction: rd %tick,%rbx' adi-test.c:276: Error: no such instruction: rd %tick,%rdx' adi-test.c:217: Error: no such instruction: rd %tick,%rbp' adi-test.c:220: Error: no such instruction: rd %tick,%rdx' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:246: Error: no such instruction: rd %tick,%rbp' adi-test.c:248: Error: no such instruction: rd %tick,%rdx' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' <builtin>: recipe for target 'adi-test' failed make[1]: *** [adi-test] Error 1
adi: [FAIL]
./drivers_test.sh: 24: ./drivers_test.sh: ./adi-test: not found ../lib.mk:73: recipe for target 'run_tests' failed
make: *** [run_tests] Error 1

Quoted 4 lines
Quoted 1 line
Signed-off-by Shuah Khan (Samsung OSG) <shuah at kernel.org>
Reviewed-by Tom Hromatka <tom.hromatka at oracle.com>
Quoted 6 lines

get_maintainers didn't include your name for this patch. Would you like to take this fix through sparc tree? It would be good to get this in for 4.18-rc2

If so, please let me know if you would like me to resend the patch with Tom's Reviewed-by tag.

I'm very busy, so this time could you merge this for me? Thanks!

Acked-by: David S. Miller <davem at davemloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#4 lore raw
Quoted 48 lines · David Miller

From: Shuah Khan <shuah at kernel.org>
Date: Fri, 15 Jun 2018 10:33:21 -0600

Quoted 45 lines · Tom Hromatka
Quoted 35 lines

Thanks, Shuah!

Tom

Quoted 29 lines · Shuah Khan (Samsung OSG)

sparc64 test fails with the following errors on non-sparc64 systems. Fix the Makefile to do nothing on non-sparc64 systems to suppress the errors:

make run_tests
adi-test.c: Assembler messages:
adi-test.c:302: Error: no such instruction: rd %tick,%r13' adi-test.c:304: Error: no such instruction: rd %tick,%rbp' adi-test.c:190: Error: no such instruction: rd %tick,%rbp' adi-test.c:192: Error: no such instruction: rd %tick,%rdx' adi-test.c:273: Error: no such instruction: rd %tick,%rbx' adi-test.c:276: Error: no such instruction: rd %tick,%rdx' adi-test.c:217: Error: no such instruction: rd %tick,%rbp' adi-test.c:220: Error: no such instruction: rd %tick,%rdx' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:246: Error: no such instruction: rd %tick,%rbp' adi-test.c:248: Error: no such instruction: rd %tick,%rdx' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: rd %tick,%rax' adi-test.c:79: Error: no such instruction: `rd %tick,%rax' <builtin>: recipe for target 'adi-test' failed make[1]: *** [adi-test] Error 1
adi: [FAIL]
./drivers_test.sh: 24: ./drivers_test.sh: ./adi-test: not found ../lib.mk:73: recipe for target 'run_tests' failed
make: *** [run_tests] Error 1

Quoted 4 lines
Quoted 1 line
Signed-off-by Shuah Khan (Samsung OSG) <shuah at kernel.org>
Reviewed-by Tom Hromatka <tom.hromatka at oracle.com>

get_maintainers didn't include your name for this patch. Would you like to take this fix through sparc tree? It would be good to get this in for 4.18-rc2

Quoted 7 lines
Quoted 2 lines

If so, please let me know if you would like me to resend the patch with Tom's Reviewed-by tag.

I'm very busy, so this time could you merge this for me? Thanks!

Acked-by David S. Miller <davem at davemloft.net>

Okay. I will take care of this.

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html