Skip to contentSkip to conversation

selftests: sparc64: delete RUN_TESTS and EMIT_TESTS overrides

PATCH In review Shuah Khan (Samsung OSG) 2 participants 3 messages Jun 12, 2018 – Jun 15, 2018 Kselftest

lore
Share & tools
lore

Shuah Khan (Samsung OSG)

author maintainer
#0 lore raw

PATCH 1/1 selftests: sparc64: delete RUN_TESTS and EMIT_TESTS overrides

Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in lib.mk. Common defines work just fine and there is no need to define custom overrides.

Signed-off-by Shuah Khan (Samsung OSG) <shuah at kernel.org>
---
 tools/testing/selftests/sparc64/Makefile | 8 --------
 1 file changed, 8 deletions(-)
tools/testing/selftests/sparc64/Makefile +0 -8
index 442f0ca45441..76b2206932c3 100644
@@ -28,10 +28,6 @@ all:
 		fi \
 	done
 
-override define RUN_TESTS
-	@cd $(OUTPUT); ./run.sh
-endef
-
 override define INSTALL_RULE
 	mkdir -p $(INSTALL_PATH)
 	install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)
@@ -43,10 +39,6 @@ override define INSTALL_RULE
 	done;
 endef
 
-override define EMIT_TESTS
-	echo "./run.sh"
-endef
-
 override define CLEAN
 	@for DIR in $(SUBDIRS); do		\
 		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
Signature · 6 lines
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reviewed-by on v1 1/1
#1 lore raw

Thanks for the clean up, Shuah.  Looks good to me.

Tom

Quoted 5 lines · Shuah Khan (Samsung OSG)

Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in lib.mk. Common defines work just fine and there is no need to define custom overrides.

Signed-off-by Shuah Khan (Samsung OSG) <shuah at kernel.org>
Reviewed-by Tom Hromatka <tom.hromatka at oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#2 lore raw
Quoted 6 lines · Tom Hromatka

Thanks for the clean up, Shuah.  Looks good to me.

Tom

Quoted 10 lines
Quoted 5 lines · Shuah Khan (Samsung OSG)

Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in lib.mk. Common defines work just fine and there is no need to define custom overrides.

Signed-off-by Shuah Khan (Samsung OSG) <shuah at kernel.org>
Reviewed-by Tom Hromatka <tom.hromatka at oracle.com>

get_maintainers didn't include your name for this patch. Would you like to take this fix through sparc tree? This is cleanup fix would be good candidate for 4.18-rc2

If so, please let me know if you would like me to resend the patch with Tom's Reviewed-by tag.

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html