PM / OPP: Update voltage in case freq == old_freq
PATCH 1/1 PM / OPP: Update voltage in case freq == old_freq
This commit fixes a rare but possible case when the clk rate is updated without update of the regulator voltage.
At boot up, CPUfreq checks if the system is running at the right freq. This is a sanity check in case a bootloader set clk rate that is outside of freq table present with cpufreq core. In such cases system can be unstable so better to change it to a freq that is preset in freq-table.
The CPUfreq takes next freq that is >= policy->cur and this is our target_freq that needs to be set now.
dev_pm_opp_set_rate(dev, target_freq) checks the target_freq and the old_freq (a current rate). If these are equal it returns early. If not, it searches for OPP (old_opp) that fits best to old_freq (not listed in the table) and updates old_freq (!).
Here, we can end up with old_freq = old_opp.rate = target_freq, which is not handled in _generic_set_opp_regulator(). It's supposed to update voltage only when freq > old_freq || freq > old_freq.
if (freq > old_freq) {
ret = _set_opp_voltage(dev, reg, new_supply);
[...]
if (freq < old_freq) {
ret = _set_opp_voltage(dev, reg, new_supply);
if (ret)It results in, no voltage update while clk rate is updated.
Example:
freq-table = {
1000MHz 1.15V
666MHZ 1.10V
333MHz 1.05V
}
boot-up-freq = 800MHz # not listed in freq-table
freq = target_freq = 1GHz
old_freq = 800Mhzold_opp = _find_freq_ceil(opp_table, &old_freq); #(old_freq is modified!)old_freq = 1GHz
--- drivers/opp/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/opp/core.c +1 -1
@@ -598,7 +598,7 @@ static int _generic_set_opp_regulator(const struct opp_table *opp_table, }/* Scaling up? Scale voltage before frequency */ -if (freq > old_freq) { +if (freq >= old_freq) { ret =_set_opp_voltage (dev, reg, new_supply);if (ret) goto restore_voltage;
Signature · 1 line
2.10.1
Quoted 51 lines · Waldemar Rymarkiewicz
This commit fixes a rare but possible case when the clk rate is updated without update of the regulator voltage.
At boot up, CPUfreq checks if the system is running at the right freq. This is a sanity check in case a bootloader set clk rate that is outside of freq table present with cpufreq core. In such cases system can be unstable so better to change it to a freq that is preset in freq-table.
The CPUfreq takes next freq that is >=
policy->curand this is ourtarget_freqthat needs to be set now.
dev_pm_opp_set_rate(dev, target_freq)checks thetarget_freqand theold_freq(a current rate). If these are equal it returns early. If not, it searches for OPP (old_opp) that fits best toold_freq(not listed in the table) and updatesold_freq(!).Here, we can end up with
old_freq= old_opp.rate =target_freq, which is not handled in_generic_set_opp_regulator(). It's supposed to update voltage only when freq >old_freq|| freq >old_freq.if (freq > old_freq) { ret = _set_opp_voltage(dev, reg, new_supply); [...] if (freq < old_freq) { ret = _set_opp_voltage(dev, reg, new_supply); if (ret)It results in, no voltage update while clk rate is updated.
Example:
freq-table = { 1000MHz 1.15V 666MHZ 1.10V 333MHz 1.05V } boot-up-freq = 800MHz # not listed in freq-table freq = target_freq = 1GHz old_freq = 800Mhz
old_opp=_find_freq_ceil(opp_table, &old_freq); #(old_freq is modified!)old_freq= 1GHzSigned-off-by Waldemar Rymarkiewicz <[email protected]>--- drivers/opp/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/opp/core.c +0
-0
drivers/opp/core.c static int _generic_set_opp_regulator(const struct opp_table *opp_table, · line 604
Quoted 8 lines
drivers/opp/core.c +1
-1@@ -598,7 +598,7 @@ static int _generic_set_opp_regulator(const struct opp_table *opp_table, }/* Scaling up? Scale voltage before frequency */ -if (freq > old_freq) { +if (freq >= old_freq) { ret =_set_opp_voltage (dev, reg, new_supply);if (ret) goto restore_voltage;
Applied with:
Thanks.
Signature · 1 line
viresh