Skip to contentSkip to conversation

ath10k: Handle resource init failure case

PATCH In review Govind Singh 2 participants 3 messages Jun 13, 2018 – Jun 14, 2018 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore

Govind Singh

author
#0 lore raw

PATCH 1/1 ath10k: Handle resource init failure case

Return type of resource init method is not assigned. Handle resource init failures for graceful exit.

Signed-off-by Govind Singh <[email protected]>
---
 drivers/net/wireless/ath/ath10k/snoc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath10k/snoc.c +2 -2
index aa8a9b36250e..a0504b8e003c 100644
@@ -1500,13 +1500,13 @@ static int ath10k_snoc_probe(struct platform_device *pdev)
 	ar_snoc->ce.bus_ops = &ath10k_snoc_bus_ops;
 	ar->ce_priv = &ar_snoc->ce;
 
-	ath10k_snoc_resource_init(ar);
+	ret = ath10k_snoc_resource_init(ar);
 	if (ret) {
 		ath10k_warn(ar, "failed to initialize resource: %d\n", ret);
 		goto err_core_destroy;
 	}
 
-	ath10k_snoc_setup_resource(ar);
+	ret = ath10k_snoc_setup_resource(ar);
 	if (ret) {
 		ath10k_warn(ar, "failed to setup resource: %d\n", ret);
 		goto err_core_destroy;
Signature · 1 line
2.17.0
#1 lore raw
Quoted 5 lines · Govind Singh

Return type of resource init method is not assigned. Handle resource init failures for graceful exit.

Signed-off-by Govind Singh <[email protected]>
Signed-off-by Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

d16a7ab20ac9 ath10k: handle resource init failure case

Signature · 3 lines
https://patchwork.kernel.org/patch/10461677/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
In reply to Govind Singh
Quoted 5 lines · Govind Singh

Return type of resource init method is not assigned. Handle resource init failures for graceful exit.

Signed-off-by Govind Singh <[email protected]>
Signed-off-by Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

d16a7ab20ac9 ath10k: handle resource init failure case

Signature · 9 lines
https://patchwork.kernel.org/patch/10461677/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k