Skip to contentSkip to conversation

nvme-cli: Implement printing the get Keep Alive Timer feature

PATCH New Revanth Rajashekar 2 participants 2 messages Jun 13, 2018 – Jun 15, 2018 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme-cli: Implement printing the get Keep Alive Timer feature

Signed-off-by Revanth Rajashekar <revanth.rajashekar at intel.com>
---
 nvme-print.c | 3 +++
 1 file changed, 3 insertions(+)
nvme-print.c +3 -0
index cdaf1cb..74af732 100644
@@ -1807,6 +1807,9 @@ void nvme_feature_show_fields(__u32 fid, unsigned int result, unsigned char *buf
 	case NVME_FEAT_RESV_PERSIST:
 		printf("\tPersist Through Power Loss (PTPL): %s\n", (result & 0x00000001) ? "True":"False");
 		break;
+	case NVME_FEAT_KATO:
+		printf("\tKeep Alive Timeout (KATO) in milliseconds: %u\n", result);
+		break;
 	}
 }
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 nvme-cli: Implement printing the get Keep Alive Timer feature

nvme-print.c void nvme_feature_show_fields(__u32 fid, unsigned int result, unsigned char *buf · line 1812

Quoted 3 lines
nvme-print.c +3 -0
+	case NVME_FEAT_KATO:
+		printf("\tKeep Alive Timeout (KATO) in milliseconds: %u\n", result);
+		break;

Again a line break would be nice.

Otherwise looks fine:

Reviewed-by Christoph Hellwig <hch at lst.de>