drm/xen-front: Replace NULL with error value in xen_drm_front_gem_get_sg_table
Subsystems (3)
PATCH 1/1 drm/xen-front: Replace NULL with error value in xen_drm_front_gem_get_sg_table
From: Oleksandr Andrushchenko <[email protected]>
Dan Carpenter has reported that there is the following static checker warning:
drivers/gpu/drm/drm_prime.c:317 drm_gem_map_dma_buf() warn: 'sgt' can also be NULL
314 sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
315
316 if (!IS_ERR(sgt)) {
317 if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
And one of the problematic functions is xen_drm_front_gem_get_sg_table. Fix this by replacing NULL with error value.
Signed-off-by Oleksandr Andrushchenko <[email protected]>
Reported-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xen/xen_drm_front_gem.c +1 -1
@@ -179,7 +179,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj)struct xen_gem_object *xen_obj =to_xen_gem_obj (gem_obj);if (!xen_obj->pages) -return NULL ; +return ERR_PTR (-ENOMEM );return drm_prime_pages_to_sg (xen_obj->pages, xen_obj->num_pages); }
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel