Skip to contentSkip to conversation

sqlite3: consistent set of features for nativesdk

PATCH Superseded S. Lockwood-Childs 2 participants 3 messages Jun 15, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sqlite3: consistent set of features for nativesdk

Enable use of pread() and enable column metadata API for nativesdk builds. This brings nativesdk in line with target and native builds.

---
 meta/recipes-support/sqlite/sqlite3.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/sqlite/sqlite3.inc +2 -0
index 95ec89c..30847b9 100644
@@ -37,10 +37,12 @@ CFLAGS_append = " -fPIC"
 
 # pread() is in POSIX.1-2001 so any reasonable system must surely support it
 BUILD_CFLAGS += "-DUSE_PREAD"
+BUILDSDK_CFLAGS += "-DUSE_PREAD"
 TARGET_CFLAGS += "-DUSE_PREAD"
 
 # Provide column meta-data API
 BUILD_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
+BUILDSDK_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
 TARGET_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
 
 PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
Signature · 1 line
1.9.4
#1 lore raw
Quoted 12 lines · S. Lockwood-Childs

Enable use of pread() and enable column metadata API for nativesdk builds. This brings nativesdk in line with target and native builds.

---
 meta/recipes-support/sqlite/sqlite3.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/sqlite/sqlite3.inc +0 -0
index 95ec89c..30847b9 100644

meta/recipes-support/sqlite/sqlite3.inc CFLAGS_append = " -fPIC" · line 42

Quoted 6 lines
meta/recipes-support/sqlite/sqlite3.inc +1 -0
@@ -37,10 +37,12 @@ CFLAGS_append = " -fPIC"
 
 # pread() is in POSIX.1-2001 so any reasonable system must surely support it
 BUILD_CFLAGS += "-DUSE_PREAD"
+BUILDSDK_CFLAGS += "-DUSE_PREAD"
 TARGET_CFLAGS += "-DUSE_PREAD"
 

Perhaps, we can just add it to CPPFLAGS and remove all three lines above

meta/recipes-support/sqlite/sqlite3.inc CFLAGS_append = " -fPIC" · line 47

Quoted 5 lines
meta/recipes-support/sqlite/sqlite3.inc +1 -0
 # Provide column meta-data API
 BUILD_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
+BUILDSDK_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
 TARGET_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
 

same as above

Quoted 9 lines
meta/recipes-support/sqlite/sqlite3.inc +0 -1
 PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
--

1.9.4

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw

PATCH v2 1/1 sqlite3: consistent set of features for nativesdk

Enable use of pread() and enable column metadata API for all builds. This brings nativesdk in line with target and native builds.

---
 meta/recipes-support/sqlite/sqlite3.inc | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
meta/recipes-support/sqlite/sqlite3.inc +2 -4
index 95ec89c..1834867d 100644
@@ -36,12 +36,10 @@ EXTRA_OECONF = " \
 CFLAGS_append = " -fPIC"
 
 # pread() is in POSIX.1-2001 so any reasonable system must surely support it
-BUILD_CFLAGS += "-DUSE_PREAD"
-TARGET_CFLAGS += "-DUSE_PREAD"
+CFLAGS += "-DUSE_PREAD"
 
 # Provide column meta-data API
-BUILD_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
-TARGET_CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
+CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
 
 PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"
 
Signature · 1 line
1.9.4