Skip to contentSkip to conversation

qt53d: fix install issue with qt5.6

PATCH New Gaël PORTAY 4 participants 5 messages Jun 11, 2018 – Jul 18, 2018

lore
Share & tools
lore

Gaël PORTAY

author
#0 lore raw

PATCH 1/1 qt53d: fix install issue with qt5.6

Both plugins geometryloaders' and renderplugins' are available since Qt 5.9.

Fixes:

	>>> qt53d 5.6.3 Installing to target
	cp -dpf /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libQt53D*.so.*

/home/gportay/src/buildroot/output/target/usr/lib
cp -dpfr /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders
/home/gportay/src/buildroot/output/target/usr/lib/qt/plugins
cp: cannot stat '/home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders': No such file or directory package/pkg-generic.mk:310: recipe for target '/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed' failed make[2]: *** [/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed] Error 1

Signed-off-by Ga?l PORTAY <[email protected]>
---
 package/qt5/qt53d/qt53d.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
package/qt5/qt53d/qt53d.mk +8 -2
index 6896b00318..48a931d60b 100644
@@ -37,13 +37,19 @@ endef
 endif
 
 ifeq ($(BR2_STATIC_LIBS),)
-define QT53D_INSTALL_TARGET_CMDS
-	cp -dpf $(STAGING_DIR)/usr/lib/libQt53D*.so.* $(TARGET_DIR)/usr/lib
+ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
+# Available since 5.9
+define QT53D_INSTALL_TARGET_LATEST
 	cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/geometryloaders $(TARGET_DIR)/usr/lib/qt/plugins
 	cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/renderplugins $(TARGET_DIR)/usr/lib/qt/plugins
+endef
+endif
+define QT53D_INSTALL_TARGET_CMDS
+	cp -dpf $(STAGING_DIR)/usr/lib/libQt53D*.so.* $(TARGET_DIR)/usr/lib
 	cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/sceneparsers $(TARGET_DIR)/usr/lib/qt/plugins
 	cp -dpfr $(STAGING_DIR)/usr/qml/Qt3D $(TARGET_DIR)/usr/qml
 	cp -dpfr $(STAGING_DIR)/usr/qml/QtQuick $(TARGET_DIR)/usr/qml
+	$(QT53D_INSTALL_TARGET_LATEST)
 	$(QT53D_INSTALL_TARGET_EXAMPLES)
 endef
 endif
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 qt53d: fix install issue with qt5.6

This patch make sense. Sorry for the regression with my last contribution.

Le lun. 11 juin 2018 ? 21:56, Ga?l PORTAY <[email protected]> a ?crit :

Quoted 50 lines

Both plugins geometryloaders' and renderplugins' are available since Qt 5.9.

Fixes:

        >>> qt53d 5.6.3 Installing to target
        cp -dpf

/home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libQt53D*.so.* /home/gportay/src/buildroot/output/target/usr/lib
cp -dpfr
/home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders /home/gportay/src/buildroot/output/target/usr/lib/qt/plugins
cp: cannot stat
'/home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders':
No such file or directory
package/pkg-generic.mk:310: recipe for target
'/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed'
failed

        make[2]: ***

[/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed] Error 1

Signed-off-by Ga?l PORTAY <[email protected]>
---
 package/qt5/qt53d/qt53d.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
package/qt5/qt53d/qt53d.mk +3 -2
index 6896b00318..48a931d60b 100644
@@ -37,13 +37,19 @@ endef
 endif
 
 ifeq ($(BR2_STATIC_LIBS),)
-define QT53D_INSTALL_TARGET_CMDS
-       cp -dpf $(STAGING_DIR)/usr/lib/libQt53D*.so.* $(TARGET_DIR)/usr/lib
+ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
+# Available since 5.9
+define QT53D_INSTALL_TARGET_LATEST
        cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/geometryloaders

$(TARGET_DIR)/usr/lib/qt/plugins

        cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/renderplugins

$(TARGET_DIR)/usr/lib/qt/plugins

package/qt5/qt53d/qt53d.mk +4 -0
+endef
+endif
+define QT53D_INSTALL_TARGET_CMDS
+       cp -dpf $(STAGING_DIR)/usr/lib/libQt53D*.so.* $(TARGET_DIR)/usr/lib
        cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/sceneparsers

$(TARGET_DIR)/usr/lib/qt/plugins

Quoted 10 lines
        cp -dpfr $(STAGING_DIR)/usr/qml/Qt3D $(TARGET_DIR)/usr/qml
        cp -dpfr $(STAGING_DIR)/usr/qml/QtQuick $(TARGET_DIR)/usr/qml
+       $(QT53D_INSTALL_TARGET_LATEST)
        $(QT53D_INSTALL_TARGET_EXAMPLES)

endef
endif
--
2.11.0

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180611/f10e1095/attachment.html>

author
#2 lore raw

PATCH 1/1 qt53d: fix install issue with qt5.6

Romain,

Quoted 2 lines · Romain REIGNIER

This patch make sense. Sorry for the regression with my last contribution.

No worries about the regression ;)

I added you in cc to let you know that I am fixing an issue with 5.6. I hope it will no break what you have fixed. You probably know more things about qt3d than me :).

Regards,
Gael

Applied
#3 lore raw

PATCH 1/1 qt53d: fix install issue with qt5.6

In reply to Gaël PORTAY

Hello,

Quoted 14 lines · Ga?l PORTAY

Both plugins geometryloaders' and renderplugins' are available since Qt 5.9.

Fixes:

	>>> qt53d 5.6.3 Installing to target  
	cp -dpf /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libQt53D*.so.*

/home/gportay/src/buildroot/output/target/usr/lib
cp -dpfr /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders
/home/gportay/src/buildroot/output/target/usr/lib/qt/plugins
cp: cannot stat '/home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders': No such file or directory package/pkg-generic.mk:310: recipe for target '/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed' failed make[2]: *** [/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed] Error 1

Quoted 4 lines
Signed-off-by Ga?l PORTAY <[email protected]>
---
 package/qt5/qt53d/qt53d.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 qt53d: fix install issue with qt5.6

In reply to Gaël PORTAY
Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ga?l" == Ga?l PORTAY <[email protected]> writes:

Both plugins geometryloaders' and renderplugins' are available since Qt 5.9.

Fixes:

Quoted 1 line
Quoted 1 line
Quoted 1 line

qt53d 5.6.3 Installing to target

cp -dpf /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libQt53D*.so.*
/home/gportay/src/buildroot/output/target/usr/lib
cp -dpfr /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders
/home/gportay/src/buildroot/output/target/usr/lib/qt/plugins
cp: cannot stat '/home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders': No such file or directory package/pkg-generic.mk:310: recipe for target '/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed' failed make[2]: *** [/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed] Error 1

Quoted 1 line
Signed-off-by Ga?l PORTAY <[email protected]>

Committed to 2018.02.x and 2018.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard