Skip to contentSkip to conversation

drm/i915: Replace {un/reference} with {put, get} functions

PATCH In review Thomas Zimmermann 3 participants 11 messages Jun 18, 2018 – Jun 28, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover drm/i915: Replace {un/reference} with {put, get} functions

This patch set replaces functions named {un,reference} by their {put,get} counterparts. Affected data types are struct drm_connector, struct drm_gem_object, and struct drm_device.

With the reference-counting functions being named {put,get}, the DRM interface is more aligned to Linux kernel nameing standard. The patch set does not change driver-internal interfaces.

Thomas Zimmermann (5):
drm/i915: Replace drm_connector_{un/reference} with put,get functions drm/i915: Replace drm_gem_object_{un/reference} with {put,get}
functions
drm/i915: Replace __drm_gem_object_unreference with
__drm_gem_object_put
drm/i915: Replace drm_gem_object_unreference_unlocked with put
function
drm/i915: Replace drm_dev_unref with drm_dev_put

 drivers/gpu/drm/i915/i915_gem_object.h             | 13 ++-----------
 drivers/gpu/drm/i915/intel_display.c               |  4 ++--
 drivers/gpu/drm/i915/intel_dp_mst.c                |  2 +-
 drivers/gpu/drm/i915/selftests/huge_pages.c        |  2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_context.c  |  2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_dmabuf.c   |  2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_evict.c    |  2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c      |  2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_object.c   |  2 +-
 drivers/gpu/drm/i915/selftests/i915_request.c      |  2 +-
 drivers/gpu/drm/i915/selftests/i915_vma.c          |  2 +-
 drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c |  2 +-
 12 files changed, 14 insertions(+), 23 deletions(-)

--
2.14.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#1 lore raw

PATCH 1/5 drm/i915: Replace drm_connector_{un/reference} with put, get functions

This patch unifies the naming of DRM functions for reference counting of struct drm_connector. The resulting code is more aligned with the rest of the Linux kernel interfaces.

---
 drivers/gpu/drm/i915/intel_display.c | 4 ++--
 drivers/gpu/drm/i915/intel_dp_mst.c  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_display.c +2 -2
index 9939e092d9aa..593979cbd215 100644
@@ -10725,7 +10725,7 @@ static void intel_modeset_update_connector_atomic_state(struct drm_device *dev)
 	drm_connector_list_iter_begin(dev, &conn_iter);
 	for_each_intel_connector_iter(connector, &conn_iter) {
 		if (connector->base.state->crtc)
-			drm_connector_unreference(&connector->base);
+			drm_connector_put(&connector->base);
 
 		if (connector->base.encoder) {
 			connector->base.state->best_encoder =
@@ -10733,7 +10733,7 @@ static void intel_modeset_update_connector_atomic_state(struct drm_device *dev)
 			connector->base.state->crtc =
 				connector->base.encoder->crtc;
 
-			drm_connector_reference(&connector->base);
+			drm_connector_get(&connector->base);
 		} else {
 			connector->base.state->best_encoder = NULL;
 			connector->base.state->crtc = NULL;
drivers/gpu/drm/i915/intel_dp_mst.c +1 -1
index 5890500a3a8b..789a403e9f99 100644
@@ -524,7 +524,7 @@ static void intel_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
 	intel_connector->mst_port = NULL;
 	drm_modeset_unlock(&connector->dev->mode_config.connection_mutex);
 
-	drm_connector_unreference(connector);
+	drm_connector_put(connector);
 }
 
 static void intel_dp_mst_hotplug(struct drm_dp_mst_topology_mgr *mgr)
Signature · 6 lines
2.14.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

PATCH 2/5 drm/i915: Replace drm_gem_object_{un/reference} with {put, get} functions

In reply to Thomas Zimmermann

This patch unifies the naming of DRM functions for reference counting of struct drm_gem_object. The resulting code is more aligned with the rest of the Linux kernel interfaces.

---
 drivers/gpu/drm/i915/i915_gem_object.h | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/gpu/drm/i915/i915_gem_object.h +1 -7
index 54f00b350779..da6e849f41a4 100644
@@ -337,13 +337,10 @@ __attribute__((nonnull))
 static inline struct drm_i915_gem_object *
 i915_gem_object_get(struct drm_i915_gem_object *obj)
 {
-	drm_gem_object_reference(&obj->base);
+	drm_gem_object_get(&obj->base);
 	return obj;
 }
 
-__deprecated
-extern void drm_gem_object_reference(struct drm_gem_object *);
-
 __attribute__((nonnull))
 static inline void
 i915_gem_object_put(struct drm_i915_gem_object *obj)
@@ -351,9 +348,6 @@ i915_gem_object_put(struct drm_i915_gem_object *obj)
 	__drm_gem_object_unreference(&obj->base);
 }
 
-__deprecated
-extern void drm_gem_object_unreference(struct drm_gem_object *);
-
 __deprecated
 extern void drm_gem_object_unreference_unlocked(struct drm_gem_object *);
 
Signature · 6 lines
2.14.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#3 lore raw

PATCH 3/5 drm/i915: Replace __drm_gem_object_unreference with __drm_gem_object_put

In reply to Thomas Zimmermann

This patch unifies the naming of DRM functions for reference counting of struct drm_gem_object. The resulting code is more aligned with the rest of the Linux kernel interfaces.

---
 drivers/gpu/drm/i915/i915_gem_object.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem_object.h +1 -1
index da6e849f41a4..0042496216fe 100644
@@ -345,7 +345,7 @@ __attribute__((nonnull))
 static inline void
 i915_gem_object_put(struct drm_i915_gem_object *obj)
 {
-	__drm_gem_object_unreference(&obj->base);
+	__drm_gem_object_put(&obj->base);
 }
 
 __deprecated
Signature · 6 lines
2.14.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#4 lore raw

PATCH 4/5 drm/i915: Replace drm_gem_object_unreference_unlocked with put function

In reply to Thomas Zimmermann

This patch unifies the naming of DRM functions for reference counting of struct drm_gem_object. The resulting code is more aligned with the rest of the Linux kernel interfaces.

---
 drivers/gpu/drm/i915/i915_gem_object.h | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/i915/i915_gem_object.h +0 -3
index 0042496216fe..c3c6f2e588fb 100644
@@ -348,9 +348,6 @@ i915_gem_object_put(struct drm_i915_gem_object *obj)
 	__drm_gem_object_put(&obj->base);
 }
 
-__deprecated
-extern void drm_gem_object_unreference_unlocked(struct drm_gem_object *);
-
 static inline void i915_gem_object_lock(struct drm_i915_gem_object *obj)
 {
 	reservation_object_lock(obj->resv, NULL);
Signature · 6 lines
2.14.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw

PATCH 5/5 drm/i915: Replace drm_dev_unref with drm_dev_put

In reply to Thomas Zimmermann

This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.

---
 drivers/gpu/drm/i915/selftests/huge_pages.c        | 2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_context.c  | 2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_dmabuf.c   | 2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_evict.c    | 2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c      | 2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_object.c   | 2 +-
 drivers/gpu/drm/i915/selftests/i915_request.c      | 2 +-
 drivers/gpu/drm/i915/selftests/i915_vma.c          | 2 +-
 drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/selftests/huge_pages.c +1 -1
index fbe4324116d7..b5e87fcdcdae 100644
@@ -1724,7 +1724,7 @@ int i915_gem_huge_page_mock_selftests(void)
 
 	i915_modparams.enable_ppgtt = saved_ppgtt;
 
-	drm_dev_unref(&dev_priv->drm);
+	drm_dev_put(&dev_priv->drm);
 
 	return err;
 }
drivers/gpu/drm/i915/selftests/i915_gem_context.c +1 -1
index 836f1af8b833..07fd3fe24157 100644
@@ -586,7 +586,7 @@ int i915_gem_context_mock_selftests(void)
 
 	err = i915_subtests(tests, i915);
 
-	drm_dev_unref(&i915->drm);
+	drm_dev_put(&i915->drm);
 	return err;
 }
 
drivers/gpu/drm/i915/selftests/i915_gem_dmabuf.c +1 -1
index 89dc25a5a53b..a7055b12e53c 100644
@@ -389,7 +389,7 @@ int i915_gem_dmabuf_mock_selftests(void)
 
 	err = i915_subtests(tests, i915);
 
-	drm_dev_unref(&i915->drm);
+	drm_dev_put(&i915->drm);
 	return err;
 }
 
drivers/gpu/drm/i915/selftests/i915_gem_evict.c +1 -1
index 2dc72a984d45..8059268800fa 100644
@@ -490,7 +490,7 @@ int i915_gem_evict_mock_selftests(void)
 	err = i915_subtests(tests, i915);
 	mutex_unlock(&i915->drm.struct_mutex);
 
-	drm_dev_unref(&i915->drm);
+	drm_dev_put(&i915->drm);
 	return err;
 }
 
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +1 -1
index a4060238bef0..a28ee0cc6a63 100644
@@ -1644,7 +1644,7 @@ int i915_gem_gtt_mock_selftests(void)
 	err = i915_subtests(tests, i915);
 	mutex_unlock(&i915->drm.struct_mutex);
 
-	drm_dev_unref(&i915->drm);
+	drm_dev_put(&i915->drm);
 	return err;
 }
 
drivers/gpu/drm/i915/selftests/i915_gem_object.c +1 -1
index 2b2dde94526f..549707b9d738 100644
@@ -586,7 +586,7 @@ int i915_gem_object_mock_selftests(void)
 
 	err = i915_subtests(tests, i915);
 
-	drm_dev_unref(&i915->drm);
+	drm_dev_put(&i915->drm);
 	return err;
 }
 
drivers/gpu/drm/i915/selftests/i915_request.c +1 -1
index 63cd9486cc13..521ae4a90ddf 100644
@@ -262,7 +262,7 @@ int i915_request_mock_selftests(void)
 		return -ENOMEM;
 
 	err = i915_subtests(tests, i915);
-	drm_dev_unref(&i915->drm);
+	drm_dev_put(&i915->drm);
 
 	return err;
 }
drivers/gpu/drm/i915/selftests/i915_vma.c +1 -1
index 8400a8cc5cf2..ffa74290e054 100644
@@ -733,7 +733,7 @@ int i915_vma_mock_selftests(void)
 	err = i915_subtests(tests, i915);
 	mutex_unlock(&i915->drm.struct_mutex);
 
-	drm_dev_unref(&i915->drm);
+	drm_dev_put(&i915->drm);
 	return err;
 }
 
drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c +1 -1
index d6926e7820e5..f03b407fdbe2 100644
@@ -464,7 +464,7 @@ int intel_breadcrumbs_mock_selftests(void)
 		return -ENOMEM;
 
 	err = i915_subtests(tests, i915->engine[RCS]);
-	drm_dev_unref(&i915->drm);
+	drm_dev_put(&i915->drm);
 
 	return err;
 }
Signature · 6 lines
2.14.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw

✓ Fi.CI.BAT: success for drm/i915: Replace {un/reference} with {put, get} functions

In reply to Thomas Zimmermann
== Series Details ==

== Series Details ==

Series: drm/i915: Replace {un/reference} with {put, get} functions
URL : https://patchwork.freedesktop.org/series/44932/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4333 -> Patchwork_9350 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9350 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9350, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/44932/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9350:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_exec_gttfill@basic:
      fi-pnv-d510:        PASS -> SKIP

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      fi-glk-j4005:       SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_9350 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_gttfill@basic:
      fi-byt-n2820:       PASS -> FAIL (fdo#106744)

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106000)

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-c:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106238)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         NOTRUN -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106238 https://bugs.freedesktop.org/show_bug.cgi?id=106238
fdo#106744 https://bugs.freedesktop.org/show_bug.cgi?id=106744

== Participating hosts (40 -> 37) ==

Additional (2): fi-bxt-dsi fi-kbl-r
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4333 -> Patchwork_9350

CI_DRM_4333: 5fad115a81a20aa6b4ffd3f7f6663d43c88fa395 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4523: 778497e7965dc8662c770a89ebbd741778feb71e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9350: f576ff5cb564ee2fdcb2c688a5d37f486d0d418f @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

f576ff5cb564 drm/i915: Replace drm_dev_unref with drm_dev_put 9e55b9ee654e drm/i915: Replace drm_gem_object_unreference_unlocked with put function e2a2fce627f1 drm/i915: Replace __drm_gem_object_unreference with __drm_gem_object_put 33b46e158311 drm/i915: Replace drm_gem_object_{un/reference} with {put, get} functions 773002149531 drm/i915: Replace drm_connector_{un/reference} with put, get functions

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9350/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

✗ Fi.CI.IGT: failure for drm/i915: Replace {un/reference} with {put, get} functions

In reply to Thomas Zimmermann
== Series Details ==

== Series Details ==

Series: drm/i915: Replace {un/reference} with {put, get} functions
URL : https://patchwork.freedesktop.org/series/44932/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4333_full -> Patchwork_9350_full =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_9350_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9350_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9350_full:

=== Piglit changes ===

    ==== Possible regressions ====

    [email protected]@execution@tex-miplevel-selection gl2:textureproj(bias) 2d_projvec4:
      pig-skl-6260u:      NOTRUN -> FAIL

== Known issues ==

Here are the changes found in Patchwork_9350_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      shard-kbl:          PASS -> DMESG-FAIL (fdo#106947)

    igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          PASS -> FAIL (fdo#106509, fdo#105454)

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#105363)

    igt@kms_flip@busy-flip:
      shard-hsw:          PASS -> DMESG-WARN (fdo#102614)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-glk:          DMESG-WARN (fdo#105763) -> PASS

    igt@kms_flip@modeset-vs-vblank-race:
      shard-hsw:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS +1

    igt@kms_flip_tiling@flip-to-y-tiled:
      shard-glk:          FAIL (fdo#104724) -> PASS +1

    igt@kms_flip_tiling@flip-x-tiled:
      shard-glk:          FAIL (fdo#104724, fdo#103822) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@kms_setmode@basic:
      shard-hsw:          FAIL (fdo#99912) -> PASS

    igt@perf@blocking:
      shard-hsw:          FAIL (fdo#102252) -> PASS

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (5 -> 6) ==

Additional (1): pig-skl-6260u

== Build changes ==

* Linux: CI_DRM_4333 -> Patchwork_9350

CI_DRM_4333: 5fad115a81a20aa6b4ffd3f7f6663d43c88fa395 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4523: 778497e7965dc8662c770a89ebbd741778feb71e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9350: f576ff5cb564ee2fdcb2c688a5d37f486d0d418f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9350/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

✓ Fi.CI.BAT: success for drm/i915: Replace {un/reference} with {put, get} functions

In reply to Thomas Zimmermann
== Series Details ==

== Series Details ==

Series: drm/i915: Replace {un/reference} with {put, get} functions
URL : https://patchwork.freedesktop.org/series/44932/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4376 -> Patchwork_9421 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/44932/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_9421 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_gttfill@basic:
      fi-byt-n2820:       PASS -> FAIL (fdo#106744)

    igt@kms_flip@basic-flip-vs-dpms:
      fi-kbl-r:           PASS -> DMESG-WARN (fdo#105602)

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-skl-6600u:       DMESG-WARN (k.org#196399) -> PASS

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
      fi-skl-guc:         FAIL (fdo#103191, fdo#104724) -> PASS

fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106744 https://bugs.freedesktop.org/show_bug.cgi?id=106744
k.org#196399 https://bugzilla.kernel.org/show_bug.cgi?id=196399

== Participating hosts (43 -> 38) ==

Missing (5): fi-byt-j1900 fi-ctg-p8600 fi-bsw-cyan fi-ilk-m540 fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4376 -> Patchwork_9421

CI_DRM_4376: b64deb6f5bec9732aff68734c2e2382f044403f2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4530: 0e98bf69f146eb72fe3a7c3b19a049b5786f0ca3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9421: 58d16583fe3458c546f61f7d42eda884abf8ddd4 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

58d16583fe34 drm/i915: Replace drm_dev_unref with drm_dev_put 3f70b0fc8989 drm/i915: Replace drm_gem_object_unreference_unlocked with put function 114d4d66aedb drm/i915: Replace __drm_gem_object_unreference with __drm_gem_object_put 14760b7cc03a drm/i915: Replace drm_gem_object_{un/reference} with {put, get} functions b26d98cb1103 drm/i915: Replace drm_connector_{un/reference} with put, get functions

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9421/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

✓ Fi.CI.IGT: success for drm/i915: Replace {un/reference} with {put, get} functions

In reply to Thomas Zimmermann
== Series Details ==

== Series Details ==

Series: drm/i915: Replace {un/reference} with {put, get} functions
URL : https://patchwork.freedesktop.org/series/44932/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4376_full -> Patchwork_9421_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9421_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9421_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9421_full:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-blt:
      shard-kbl:          PASS -> SKIP +2

    igt@gem_exec_schedule@deep-vebox:
      shard-kbl:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_9421_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      shard-kbl:          PASS -> DMESG-FAIL (fdo#106947, fdo#106560)

    igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          PASS -> FAIL (fdo#106509)

    igt@kms_flip@modeset-vs-vblank-race:
      shard-glk:          PASS -> FAIL (fdo#103060)

    igt@kms_flip@plain-flip-fb-recreate:
      shard-glk:          PASS -> FAIL (fdo#100368)

    igt@kms_flip_tiling@flip-y-tiled:
      shard-glk:          PASS -> FAIL (fdo#103822, fdo#104724)

    igt@perf_pmu@busy-accuracy-98-vcs1:
      shard-snb:          NOTRUN -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_gtt:
      shard-glk:          FAIL (fdo#105347) -> PASS

    igt@drv_suspend@shrink:
      shard-apl:          FAIL (fdo#106886) -> PASS

    igt@gem_exec_schedule@preemptive-hang-render:
      shard-snb:          INCOMPLETE (fdo#105411) -> SKIP

    igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
      shard-glk:          FAIL (fdo#105703) -> PASS

    igt@kms_flip@2x-plain-flip-fb-recreate:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-hsw:          FAIL (fdo#102887, fdo#105363) -> PASS
      shard-glk:          FAIL (fdo#105189) -> PASS

    igt@kms_flip_tiling@flip-to-y-tiled:
      shard-glk:          FAIL (fdo#103822, fdo#104724) -> PASS

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4376 -> Patchwork_9421

CI_DRM_4376: b64deb6f5bec9732aff68734c2e2382f044403f2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4530: 0e98bf69f146eb72fe3a7c3b19a049b5786f0ca3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9421: 58d16583fe3458c546f61f7d42eda884abf8ddd4 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9421/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

Re: [PATCH 0/5] drm/i915: Replace {un/reference} with {put,get} functions

In reply to Thomas Zimmermann
Quoted 7 lines · Thomas Zimmermann

This patch set replaces functions named {un,reference} by their {put,get} counterparts. Affected data types are struct drm_connector, struct drm_gem_object, and struct drm_device.

With the reference-counting functions being named {put,get}, the DRM interface is more aligned to Linux kernel nameing standard. The patch set does not change driver-internal interfaces.

Ok after kicking CI the spurious fail in the piglit tests is gone. Everythign applied for 4.19, thanks a lot for your patches. -Daniel

Quoted 28 lines

Thomas Zimmermann (5):
drm/i915: Replace drm_connector_{un/reference} with put,get functions drm/i915: Replace drm_gem_object_{un/reference} with {put,get}
functions
drm/i915: Replace __drm_gem_object_unreference with
__drm_gem_object_put
drm/i915: Replace drm_gem_object_unreference_unlocked with put
function
drm/i915: Replace drm_dev_unref with drm_dev_put

 drivers/gpu/drm/i915/i915_gem_object.h             | 13 ++-----------
 drivers/gpu/drm/i915/intel_display.c               |  4 ++--
 drivers/gpu/drm/i915/intel_dp_mst.c                |  2 +-
 drivers/gpu/drm/i915/selftests/huge_pages.c        |  2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_context.c  |  2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_dmabuf.c   |  2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_evict.c    |  2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c      |  2 +-
 drivers/gpu/drm/i915/selftests/i915_gem_object.c   |  2 +-
 drivers/gpu/drm/i915/selftests/i915_request.c      |  2 +-
 drivers/gpu/drm/i915/selftests/i915_vma.c          |  2 +-
 drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c |  2 +-
 12 files changed, 14 insertions(+), 23 deletions(-)

--
2.14.4

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel