drm/omapdrm: Replace {un/reference} with {put, get} functions

This patch set replaces functions named {un,reference} by their {put,get} counterparts. Affected data types are struct drm_gem_object, and struct drm_device.

With the reference-counting functions being named {put,get}, the DRM interface is more aligned to Linux kernel nameing standard. The patch set does not change driver-internal interfaces.

Thomas Zimmermann (3):
drm/omapdrm: Replace drm_gem_object_{un/reference} with put,get
functions
drm/omapdrm: Replace drm_gem_object_unreference_unlocked with put
function
drm/omapdrm: Replace drm_dev_unref with drm_dev_put

 drivers/gpu/drm/omapdrm/omap_drv.c        | 6 +++---
 drivers/gpu/drm/omapdrm/omap_fb.c         | 2 +-
 drivers/gpu/drm/omapdrm/omap_fbdev.c      | 2 +-
 drivers/gpu/drm/omapdrm/omap_gem.c        | 4 ++--
 drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

Hi,

Quoted 15 lines · Thomas Zimmermann

This patch set replaces functions named {un,reference} by their {put,get} counterparts. Affected data types are struct drm_gem_object, and struct drm_device.

With the reference-counting functions being named {put,get}, the DRM interface is more aligned to Linux kernel nameing standard. The patch set does not change driver-internal interfaces.

Thomas Zimmermann (3):
drm/omapdrm: Replace drm_gem_object_{un/reference} with put,get
functions
drm/omapdrm: Replace drm_gem_object_unreference_unlocked with put
function
drm/omapdrm: Replace drm_dev_unref with drm_dev_put

Quoted 6 lines

 drivers/gpu/drm/omapdrm/omap_drv.c        | 6 +++---
 drivers/gpu/drm/omapdrm/omap_fb.c         | 2 +-
 drivers/gpu/drm/omapdrm/omap_fbdev.c      | 2 +-
 drivers/gpu/drm/omapdrm/omap_gem.c        | 4 ++--
 drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

Thanks, I have picked these up (better later than never... sorry I missed these).

Tomi

Hi

Thanks. I rebased just today. Patch 3 is slightly out of date. Do you want me to post an update?

Quoted 4 lines

Hi

Thanks. I rebased just today. Patch 3 is slightly out of date. Do you want me to post an update?

Yes, the third one conflicted. I fixed it as follows. If it looks the same as your rebased one, no need to resend:

From 1ebbed291771d486aa25d42d024c9040c1254b3a Mon Sep 17 00:00:00 2001
From: Thomas Zimmermann <[email protected]>
Date: Mon, 18 Jun 2018 15:07:27 +0200
Subject: [PATCH] drm/omap: Replace drm_dev_unref with drm_dev_put

This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces.

Signed-off-by Thomas Zimmermann <[email protected]>

Signed-off-by Tomi Valkeinen <[email protected]>

---
 drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/gpu/drm/omapdrm/omap_drv.c +2 -2

index f14d02ca968c..5e67d58cbc28 100644
@@ -614,7 +614,7 @@ static int omapdrm_init(struct omap_drm_private *priv, struct device *dev)
 	omap_disconnect_pipelines(ddev);
 err_crtc_uninit:
 	omap_crtc_pre_uninit(priv);
-	drm_dev_unref(ddev);
+	drm_dev_put(ddev);
 	return ret;
 }
 

@@ -643,7 +643,7 @@ static void omapdrm_cleanup(struct omap_drm_private *priv)
 	omap_disconnect_pipelines(ddev);
 	omap_crtc_pre_uninit(priv);
 
-	drm_dev_unref(ddev);
+	drm_dev_put(ddev);
 }
 
 static int pdev_probe(struct platform_device *pdev)