drivers: qcom: rpmh-rsc: Check cmd_db_ready() to help children
Subsystems (2)
PATCH 1/1 drivers: qcom: rpmh-rsc: Check cmd_db_ready() to help children
Children of RPMh will need access to cmd_db. Rather than having each child have code to check if cmd_db is ready let's add the check to RPMh.
---
This code is based upon v11 of Lina and Raju's RPMh series.
With this we'll be able to remove this boilerplate code from clk-rpmh.c and qcom-rpmh-regulator.c. Neither of these files has landed upstream yet but patches are pretty far along.
drivers/soc/qcom/rpmh-rsc.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
drivers/soc/qcom/rpmh-rsc.c +13 -0
@@ -18,6 +18,7 @@#include <linux/slab.h> #include <linux/spinlock.h> +#include <soc/qcom/cmd-db.h> #include <soc/qcom/tcs.h> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
@@ -621,6 +622,18 @@ static int rpmh_rsc_probe(struct platform_device *pdev)struct rsc_drv *drv;int ret, irq; +/* +* Even though RPMh doesn't directly use cmd-db, all of its children +* do. To avoid adding this check to our children we'll do it now. +*/ + ret =cmd_db_ready (); +if (ret) { +if (ret != -EPROBE_DEFER ) +dev_err (&pdev->dev,"Command DB not available (%d)\n" , + ret); +return ret; + } + drv =devm_kzalloc (&pdev->dev,sizeof (*drv),GFP_KERNEL );if (!drv)return -ENOMEM ;
Signature · 1 line
2.18.0.rc1.244.gcf134e6275-goog
Quoted 6 lines · Douglas Anderson
Children of RPMh will need access to
cmd_db. Rather than having each child have code to check ifcmd_dbis ready let's add the check to RPMh.Suggested-by Stephen Boyd <[email protected]>Signed-off-by Douglas Anderson <[email protected]>
Quoted 23 lines
---
This code is based upon v11 of Lina and Raju's RPMh series.With this we'll be able to remove this boilerplate code from
clk-rpmh.candqcom-rpmh-regulator.c. Neither of these files has landed upstream yet but patches are pretty far along.
drivers/soc/qcom/rpmh-rsc.c| 13 +++++++++++++1 file changed, 13 insertions(+)drivers/soc/qcom/rpmh-rsc.c +1
-0@@ -18,6 +18,7 @@#include <linux/slab.h> #include <linux/spinlock.h> +#include <soc/qcom/cmd-db.h> #include <soc/qcom/tcs.h> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
drivers/soc/qcom/rpmh-rsc.c static int rpmh_rsc_probe(struct platform_device *pdev) · line 627
Quoted 6 lines
drivers/soc/qcom/rpmh-rsc.c +3
-0@@ -621,6 +622,18 @@ static int rpmh_rsc_probe(struct platform_device *pdev)struct rsc_drv *drv;int ret, irq; +/* +* Even though RPMh doesn't directly use cmd-db, all of its children +* do. To avoid adding this check to our children we'll do it now.
nit: Double space before To
Quoted 15 lines
drivers/soc/qcom/rpmh-rsc.c +9
-1+*/ + ret =cmd_db_ready (); +if (ret) { +if (ret != -EPROBE_DEFER ) +dev_err (&pdev->dev,"Command DB not available (%d)\n" , + ret); +return ret; + } + drv =devm_kzalloc (&pdev->dev,sizeof (*drv),GFP_KERNEL );if (!drv)return -ENOMEM ; --2.18.0.rc1.244.gcf134e6275-goog
Quoted 6 lines · Douglas Anderson
Children of RPMh will need access to
cmd_db. Rather than having each child have code to check ifcmd_dbis ready let's add the check to RPMh.Suggested-by Stephen Boyd <[email protected]>Signed-off-by Douglas Anderson <[email protected]>
Regards,
Bjorn
Quoted 48 lines
---
This code is based upon v11 of Lina and Raju's RPMh series.With this we'll be able to remove this boilerplate code from
clk-rpmh.candqcom-rpmh-regulator.c. Neither of these files has landed upstream yet but patches are pretty far along.drivers/soc/qcom/rpmh-rsc.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)drivers/soc/qcom/rpmh-rsc.c +13
-0@@ -18,6 +18,7 @@#include <linux/slab.h> #include <linux/spinlock.h> +#include <soc/qcom/cmd-db.h> #include <soc/qcom/tcs.h> #include <dt-bindings/soc/qcom,rpmh-rsc.h> @@ -621,6 +622,18 @@ static int rpmh_rsc_probe(struct platform_device *pdev)struct rsc_drv *drv;int ret, irq; +/* +* Even though RPMh doesn't directly use cmd-db, all of its children +* do. To avoid adding this check to our children we'll do it now. +*/ + ret =cmd_db_ready (); +if (ret) { +if (ret != -EPROBE_DEFER ) +dev_err (&pdev->dev,"Command DB not available (%d)\n" , + ret); +return ret; + } + drv =devm_kzalloc (&pdev->dev,sizeof (*drv),GFP_KERNEL );if (!drv)return -ENOMEM ;Signature · 6 lines
2.18.0.rc1.244.gcf134e6275-goog -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html