arm64: dts: exynos: Remove leading 0x from unit addresses in Exynos5433

The decon, decon_tv and dsi nodes have only one child port so address/size mappings are not necessary. This fixes DTC warnings like:

Warning (graph_child_address): /soc/decon at 13800000/ports:
graph node has single child node 'port at 0', #address-cells/#size-cells are not necessary

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi |  6 +-----
 arch/arm64/boot/dts/exynos/exynos5433.dtsi            | 12 ++----------
 2 files changed, 3 insertions(+), 15 deletions(-)

The decon, decon_tv and dsi nodes have only one child port so address/size mappings are not necessary. This fixes DTC warnings like:

Warning (graph_child_address): /soc/decon at 13800000/ports:
graph node has single child node 'port at 0', #address-cells/#size-cells are not necessary

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi |  6 +-----
 arch/arm64/boot/dts/exynos/exynos5433.dtsi            | 12 ++----------
 2 files changed, 3 insertions(+), 15 deletions(-)

arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +1 -5

index a1e3194b7483..0a15ee513f5c 100644
@@ -321,11 +321,7 @@
 	status = "okay";
 
 	ports {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		port at 0 {
-			reg = <0>;
+		port {
 			tv_to_hdmi: endpoint {
 				remote-endpoint = <&hdmi_to_tv>;
 			};

arch/arm64/boot/dts/exynos/exynos5433.dtsi +2 -10

index 3a9b4c4b9c63..e4367fd39120 100644
@@ -850,11 +850,7 @@
 			iommu-names = "m0", "m1";
 
 			ports {
-				#address-cells = <1>;
-				#size-cells = <0>;
-
-				port at 0 {
-					reg = <0>;
+				port {
 					decon_to_mic: endpoint {
 						remote-endpoint =
 							<&mic_to_decon>;

@@ -914,11 +910,7 @@
 			#size-cells = <0>;
 
 			ports {
-				#address-cells = <1>;
-				#size-cells = <0>;
-
-				port at 0 {
-					reg = <0>;
+				port {
 					dsi_to_mic: endpoint {
 						remote-endpoint = <&mic_to_dsi>;
 					};

The decon, decon_tv and dsi nodes have only one child port so address/size mappings are not necessary. This fixes DTC warnings like:

Warning (graph_child_address): /soc/decon at 13800000/ports:
graph node has single child node 'port at 0', #address-cells/#size-cells are not necessary

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
  arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi |  6 +-----
  arch/arm64/boot/dts/exynos/exynos5433.dtsi            | 12 ++----------
  2 files changed, 3 insertions(+), 15 deletions(-)

arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +1 -5

index a1e3194b7483..0a15ee513f5c 100644
@@ -321,11 +321,7 @@
  	status = "okay";
 
  	ports {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		port at 0 {
-			reg = <0>;
+		port {
  			tv_to_hdmi: endpoint {
  				remote-endpoint = <&hdmi_to_tv>;
  			};

arch/arm64/boot/dts/exynos/exynos5433.dtsi +1 -5

index 3a9b4c4b9c63..e4367fd39120 100644
@@ -850,11 +850,7 @@
  			iommu-names = "m0", "m1";
 
  			ports {
-				#address-cells = <1>;
-				#size-cells = <0>;
-
-				port at 0 {
-					reg = <0>;
+				port {
  					decon_to_mic: endpoint {
  						remote-endpoint =
  							<&mic_to_decon>;

@@ -914,11 +910,7 @@
  			#size-cells = <0>;
 

Hi Krzysztof,

Quoted 3 lines · Krzysztof Kozlowski

The decon, decon_tv and dsi nodes have only one child port so address/size mappings are not necessary. This fixes DTC warnings like:

Quoted 4 lines

Warning (graph_child_address): /soc/decon at 13800000/ports:
graph node has single child node 'port at 0', #address-cells/#size-cells are not necessary

Signed-off-by Krzysztof Kozlowski <[email protected]>

Works fine with current Exynos DRM Decon/MIC/DSI drivers.

Tested-by Marek Szyprowski <[email protected]>

Quoted 9 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 6 lines · Krzysztof Kozlowski

The decon, decon_tv and dsi nodes have only one child port so address/size mappings are not necessary. This fixes DTC warnings like:

Warning (graph_child_address): /soc/decon at 13800000/ports:
graph node has single child node 'port at 0', #address-cells/#size-cells are not necessary

Quoted 5 lines

Quoted 1 line

Signed-off-by Krzysztof Kozlowski <[email protected]>

Works fine with current Exynos DRM Decon/MIC/DSI drivers.

Tested-by Marek Szyprowski <[email protected]>

Thanks for review and testing!

Quoted 11 lines · Krzysztof Kozlowski

Quoted 10 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 7 lines · Krzysztof Kozlowski

The decon, decon_tv and dsi nodes have only one child port so address/size mappings are not necessary. This fixes DTC warnings like:

Warning (graph_child_address): /soc/decon at 13800000/ports:
graph node has single child node 'port at 0', #address-cells/#size-cells are not necessary

Signed-off-by Krzysztof Kozlowski <[email protected]>

Quoted 4 lines

Quoted 3 lines

Works fine with current Exynos DRM Decon/MIC/DSI drivers.

Tested-by Marek Szyprowski <[email protected]>

Thanks for review and testing!

I have second thoughs whether this patch is correct. AFAIU, the drivers get the remote endpoints by reg==0 (for example the of_graph_get_remote_node() in exynos_dsi_parse_dt()). If the port shall be ignored, then reg==-1 should be passed.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 15 lines · Krzysztof Kozlowski

Quoted 14 lines · Krzysztof Kozlowski

Quoted 13 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 7 lines · Krzysztof Kozlowski

The decon, decon_tv and dsi nodes have only one child port so address/size mappings are not necessary. This fixes DTC warnings like:

Warning (graph_child_address): /soc/decon at 13800000/ports:
graph node has single child node 'port at 0', #address-cells/#size-cells are not necessary

Signed-off-by Krzysztof Kozlowski <[email protected]>

Works fine with current Exynos DRM Decon/MIC/DSI drivers.

Tested-by Marek Szyprowski <[email protected]>

Quoted 5 lines

Quoted 1 line

Thanks for review and testing!

I have second thoughs whether this patch is correct. AFAIU, the drivers get the remote endpoints by reg==0 (for example the of_graph_get_remote_node() in exynos_dsi_parse_dt()). If the port shall be ignored, then reg==-1 should be passed.

All this is about purity, DECON bindings says explicitly that there should be a port with reg=0.

So your patch and DTC warnings are incorrect from bindings PoV.

On the other side graph bindings are too bloated ( so many lines to describe one connection ) so I am happy if there are shrinking attempts :) Functionally nothing changes, of graph helpers assume reg=0 if it is not present in port/endpoint node.

And regarding real issues, DECON could have more ports, possible candidates:
- GSCALER0/1/2,
- GSD/DSD - interconnect between GSCALERs and DECONs,
- SMIES - image enhancer (not implemented),
- MIC0/1 - image enhancers,
- DSIM0/1 - DSI encoders,
- HDMI - HDMI encoder.

But since all these connections can be configured dynamically, and more importantly are inside specific SoC I dont think they need of_graphs. In fact I think current of graph is also not necessary, but this is different story, removal is on my long TODO list :)

Remove leading 0x from recently introduced unit addresses to fix DTC warnings:

    Warning (unit_address_format): /soc/sysmmu at 0x15040000: unit name should not have leading "0x"

arch/arm64/boot/dts/exynos/exynos5433.dtsi +1 -1

@@ -1171,7 +1171,7 @@
 			power-domains = <&pd_gscl>;
 		};
 
-		sysmmu_scaler_0: sysmmu at 0x15040000 {
+		sysmmu_scaler_0: sysmmu at 15040000 {
 			compatible = "samsung,exynos-sysmmu";
 			reg = <0x15040000 0x1000>;
 			interrupts = <GIC_SPI 404 IRQ_TYPE_LEVEL_HIGH>;

Quoted 4 lines · Krzysztof Kozlowski

Remove leading 0x from recently introduced unit addresses to fix DTC warnings:

    Warning (unit_address_format): /soc/sysmmu at 0x15040000: unit name should not have leading "0x"

[]

arch/arm64/boot/dts/exynos/exynos5433.dtsi

Quoted 1 line

arch/arm64/boot/dts/exynos/exynos5433.dtsi +0 -0

[]

Quoted 10 lines

arch/arm64/boot/dts/exynos/exynos5433.dtsi +1 -1

@@ -1171,7 +1171,7 @@
                      power-domains = <&pd_gscl>;
              };
 
-             sysmmu_scaler_0: sysmmu at 0x15040000 {
+             sysmmu_scaler_0: sysmmu at 15040000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x15040000 0x1000>;
                      interrupts = <GIC_SPI 404 IRQ_TYPE_LEVEL_HIGH>;

arch/arm64/boot/dts/exynos/exynos5433.dtsi line 1188

Quoted 8 lines

arch/arm64/boot/dts/exynos/exynos5433.dtsi +1 -1

@@ -1182,7 +1182,7 @@
                      power-domains = <&pd_mscl>;
              };
 
-             sysmmu_scaler_1: sysmmu at 0x15050000 {
+             sysmmu_scaler_1: sysmmu at 15050000 {
                      compatible = "samsung,exynos-sysmmu";
                      reg = <0x15050000 0x1000>;
                      interrupts = <GIC_SPI 406 IRQ_TYPE_LEVEL_HIGH>;

Presumably these 3 other entries too?

$ git grep -P "\b\w+:\s+\w+ at 0x" -- "*.dt*"
arch/arc/boot/dts/abilis_tb10x.dtsi:            spi0: spi at 0xFE010000 {
arch/arc/boot/dts/abilis_tb10x.dtsi:            spi1: spi at 0xFE011000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:   uio_ev: uio at 0xD0000000 {