cxd2099: cleanup licensing

PATCH In review Daniel Scheller 2 participants 7 messages Jun 19, 2018 – Jun 22, 2018

Subsystems (2)

Media (V4L/DVB) Media drivers for CXD2099AR ci controllers

lore

Share & tools

lore

Daniel Scheller

author

2018-06-19 18:51 UTC #0 lore raw

cover cxd2099: cleanup licensing

From: Daniel Scheller <[email protected]>

Upstream committed a change to the dddvb driver package ([1]) that makes things clear everything is licensed under the terms of the GPLv2-only. So, apply the MODULE_LICENSE change to cxd2099 and, as things are sorted now, apply SPDX license identifiers (and fix two spurious whitespaces).

Split from the series that touches all other Digital Devices drivers since Jasmin is the maintainer for the cxd2099 driver.

Ralph/Manfred: Although all license related things should be clear by now, please be so kind and send Acks (or complaints, if any) on these patches so we can finally get rid of any mismatches in the in-kernel drivers.

[1] https://github.com/DigitalDevices/dddvb/commit/3db30defab4bd5429f6563b084a215b83da01ea0

Daniel Scheller (3):
[media] dvb-frontends/cxd2099: fix MODULE_LICENSE to 'GPL v2' [media] dvb-frontends/cxd2099: add SPDX license identifier [media] dvb-frontends/cxd2099: fix boilerplate whitespace

 drivers/media/dvb-frontends/cxd2099.c | 5 +++--
 drivers/media/dvb-frontends/cxd2099.h | 3 ++-
 2 files changed, 5 insertions(+), 3 deletions(-)

Signature · 1 line

2.16.4

Daniel Scheller

author

2018-06-19 18:51 UTC #1 lore raw

PATCH 1/3 dvb-frontends/cxd2099: fix MODULE_LICENSE to 'GPL v2'

From: Daniel Scheller <[email protected]>

In commit 3db30defab4b ("use correct MODULE_LINCESE for GPL v2 only according to notice in header") in the upstream repository for the mentioned driver at https://github.com/DigitalDevices/dddvb.git, the MODULE_LICENSE was fixed to "GPL v2" and is now in sync with the GPL copyright boilerplate. Apply this change to the kernel tree driver aswell.

Cc Ralph Metzler <[email protected]>

Cc Manfred Voelkel <[email protected]>

Signed-off-by Daniel Scheller <[email protected]>

---
 drivers/media/dvb-frontends/cxd2099.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/media/dvb-frontends/cxd2099.c +1 -1

index 4a0ce3037fd6..42de3d0badba 100644
@@ -701,4 +701,4 @@ module_i2c_driver(cxd2099_driver);
 
 MODULE_DESCRIPTION("Sony CXD2099AR Common Interface controller driver");
 MODULE_AUTHOR("Ralph Metzler");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");

Signature · 1 line

2.16.4

Jasmin J.

maintainer

2018-06-22 18:30 UTC #2 lore raw

Re: [PATCH 1/3] [media] dvb-frontends/cxd2099: fix MODULE_LICENSE to 'GPL v2'

You can add my Acked-by: Jasmin Jessich <[email protected]>

Quoted 27 lines · Daniel Scheller

From: Daniel Scheller <[email protected]>
In commit 3db30defab4b ("use correct MODULE_LINCESE for GPL v2 only according to notice in header") in the upstream repository for the mentioned driver at https://github.com/DigitalDevices/dddvb.git, the MODULE_LICENSE was fixed to "GPL v2" and is now in sync with the GPL copyright boilerplate. Apply this change to the kernel tree driver aswell.
Cc Ralph Metzler <[email protected]>
Cc Manfred Voelkel <[email protected]>
Signed-off-by Daniel Scheller <[email protected]>
---
 drivers/media/dvb-frontends/cxd2099.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/dvb-frontends/cxd2099.c +1 -1
index 4a0ce3037fd6..42de3d0badba 100644
@@ -701,4 +701,4 @@ module_i2c_driver(cxd2099_driver);
 
 MODULE_DESCRIPTION("Sony CXD2099AR Common Interface controller driver");
 MODULE_AUTHOR("Ralph Metzler");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");

Daniel Scheller

author

2018-06-19 18:51 UTC #3 lore raw

PATCH 2/3 dvb-frontends/cxd2099: add SPDX license identifier

In reply to Daniel Scheller

From: Daniel Scheller <[email protected]>

As both the MODULE_LICENSE and the boilerplates are now in sync and clear that the driver is licensed under the terms of the GPLv2-only, add a matching SPDX license identifier tag.

Cc Ralph Metzler <[email protected]>

Cc Manfred Voelkel <[email protected]>

Signed-off-by Daniel Scheller <[email protected]>

---
 drivers/media/dvb-frontends/cxd2099.c | 1 +
 drivers/media/dvb-frontends/cxd2099.h | 1 +
 2 files changed, 2 insertions(+)

drivers/media/dvb-frontends/cxd2099.c +1 -0

index 42de3d0badba..5264e873850e 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * cxd2099.c: Driver for the Sony CXD2099AR Common Interface Controller
  *

drivers/media/dvb-frontends/cxd2099.h +1 -0

index ec1910dec3f3..0c101bdef01d 100644
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * cxd2099.h: Driver for the Sony CXD2099AR Common Interface Controller
  *

Signature · 1 line

2.16.4

Jasmin J.

maintainer

2018-06-22 18:30 UTC #4 lore raw

Re: [PATCH 2/3] [media] dvb-frontends/cxd2099: add SPDX license identifier

You can add my Acked-by: Jasmin Jessich <[email protected]>

Quoted 33 lines · Daniel Scheller

From: Daniel Scheller <[email protected]>
As both the MODULE_LICENSE and the boilerplates are now in sync and clear that the driver is licensed under the terms of the GPLv2-only, add a matching SPDX license identifier tag.
Cc Ralph Metzler <[email protected]>
Cc Manfred Voelkel <[email protected]>
Signed-off-by Daniel Scheller <[email protected]>
---
 drivers/media/dvb-frontends/cxd2099.c | 1 +
 drivers/media/dvb-frontends/cxd2099.h | 1 +
 2 files changed, 2 insertions(+)
drivers/media/dvb-frontends/cxd2099.c +1 -0
index 42de3d0badba..5264e873850e 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * cxd2099.c: Driver for the Sony CXD2099AR Common Interface Controller
  *
drivers/media/dvb-frontends/cxd2099.h +1 -0
index ec1910dec3f3..0c101bdef01d 100644
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * cxd2099.h: Driver for the Sony CXD2099AR Common Interface Controller
  *

Daniel Scheller

author

2018-06-19 18:51 UTC #5 lore raw

PATCH 3/3 dvb-frontends/cxd2099: fix boilerplate whitespace

In reply to Daniel Scheller

From: Daniel Scheller <[email protected]>

There's a superfluous whitespace in the boilerplate license text in both .c and .h files. Fix this.

Cc Ralph Metzler <[email protected]>

Cc Manfred Voelkel <[email protected]>

Signed-off-by Daniel Scheller <[email protected]>

---
 drivers/media/dvb-frontends/cxd2099.c | 2 +-
 drivers/media/dvb-frontends/cxd2099.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/media/dvb-frontends/cxd2099.c +1 -1

index 5264e873850e..5d8884ed64ef 100644
@@ -10,7 +10,7 @@
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  * GNU General Public License for more details.
  */

drivers/media/dvb-frontends/cxd2099.h +1 -1

index 0c101bdef01d..30787095843a 100644
@@ -10,7 +10,7 @@
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  * GNU General Public License for more details.
  */

Signature · 1 line

2.16.4

Jasmin J.

maintainer

2018-06-22 18:30 UTC #6 lore raw

Re: [PATCH 3/3] [media] dvb-frontends/cxd2099: fix boilerplate whitespace

You can add my Acked-by: Jasmin Jessich <[email protected]>

Quoted 40 lines · Daniel Scheller

From: Daniel Scheller <[email protected]>

There's a superfluous whitespace in the boilerplate license text in both .c and .h files. Fix this.

Cc Ralph Metzler <[email protected]>

Cc Manfred Voelkel <[email protected]>

Signed-off-by Daniel Scheller <[email protected]>

---
 drivers/media/dvb-frontends/cxd2099.c | 2 +-
 drivers/media/dvb-frontends/cxd2099.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/media/dvb-frontends/cxd2099.c +1 -1

index 5264e873850e..5d8884ed64ef 100644
@@ -10,7 +10,7 @@
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  * GNU General Public License for more details.
  */

drivers/media/dvb-frontends/cxd2099.h +1 -1

index 0c101bdef01d..30787095843a 100644
@@ -10,7 +10,7 @@
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  * GNU General Public License for more details.
  */