riscv: remove unnecessary of_platform_populate call
PATCH 1/1 riscv: remove unnecessary of_platform_populate call
The DT core will call of_platform_default_populate, so it is not necessary for arch specific code to call it unless there are custom match entries, auxdata or parent device. Neither of those apply here, so remove the call.
--- arch/riscv/kernel/setup.c | 5 ----- 1 file changed, 5 deletions(-)
arch/riscv/kernel/setup.c +0 -5
@@ -220,8 +220,3 @@ void __init setup_arch(char **cmdline_p)riscv_fill_hwcap (); } -static int __init riscv_device_init (void ) -{ -return of_platform_populate (NULL , of_default_bus_match_table,NULL ,NULL ); -} -subsys_initcall_sync (riscv_device_init);
Signature · 1 line
2.17.1
Quoted 6 lines · Rob Herring
The DT core will call
of_platform_default_populate, so it is not necessary for arch specific code to call it unless there are custom match entries, auxdata or parent device. Neither of those apply here, so remove the call.
Quoted 7 lines
Cc Palmer Dabbelt <[email protected]>Cc Albert Ou <[email protected]>Cc linux-riscv at lists.infradead.orgSigned-off-by Rob Herring <[email protected]>--- arch/riscv/kernel/setup.c | 5 ----- 1 file changed, 5 deletions(-)
Ping?
Quoted 17 lines
arch/riscv/kernel/setup.c +0
-6@@ -220,8 +220,3 @@ void __init setup_arch(char **cmdline_p)riscv_fill_hwcap (); } -static int __init riscv_device_init (void ) -{ -return of_platform_populate (NULL , of_default_bus_match_table,NULL ,NULL ); -} -subsys_initcall_sync (riscv_device_init); --2.17.1
Quoted 15 lines · robh at kernel.org
Quoted 6 lines · Rob Herring
The DT core will call
of_platform_default_populate, so it is not necessary for arch specific code to call it unless there are custom match entries, auxdata or parent device. Neither of those apply here, so remove the call.Quoted 7 lines
Cc Palmer Dabbelt <[email protected]>Cc Albert Ou <[email protected]>Cc linux-riscv at lists.infradead.orgSigned-off-by Rob Herring <[email protected]>--- arch/riscv/kernel/setup.c | 5 ----- 1 file changed, 5 deletions(-)
Quoted 1 line
Ping?
Sorry for not saying anything, I don't have a good scheme for automatically tracking patches as they flow through my tree and my inbox is a bit backed up. This landed as part of b19b9282093588e73401f9d4981310a8de975f7d.
Thanks for the fix!
Quoted 14 lines
Quoted 14 lines
arch/riscv/kernel/setup.c +0
-5@@ -220,8 +220,3 @@ void __init setup_arch(char **cmdline_p)riscv_fill_hwcap (); } -static int __init riscv_device_init (void ) -{ -return of_platform_populate (NULL , of_default_bus_match_table,NULL ,NULL ); -} -subsys_initcall_sync (riscv_device_init);