Skip to contentSkip to conversation

dm raid: don't use 'const' in function return

PATCH New Geert Uytterhoeven 1 participant 1 message Jun 22, 2018 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm raid: don't use 'const' in function return

From: Arnd Bergmann <[email protected]>

A newly introduced function has 'const int' as the return type, but as "make W=1" reports, that has no meaning:

drivers/md/dm-raid.c:510:18: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

This changes the return type to plain 'int'.

Fixes 33e53f06850f ("dm raid: introduce extended superblock and new raid types to support takeover/reshaping")
Fixes 552aa679f2657431 ("dm raid: use rs_is_raid*()")

---
Cherry-picked from 68c1c4d5eafc65dd ("dm raid: don't use 'const' in function return") with new Fixes tag, as the issue has been reintroduced.

---
 drivers/md/dm-raid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/dm-raid.c +1 -1
index ab13fcec3fca046c..75df4c9d8b541de4 100644
@@ -588,7 +588,7 @@ static const char *raid10_md_layout_to_format(int layout)
 }
 
 /* Return md raid10 algorithm for @name */
-static const int raid10_name_to_format(const char *name)
+static int raid10_name_to_format(const char *name)
 {
 	if (!strcasecmp(name, "near"))
 		return ALGORITHM_RAID10_NEAR;
Signature · 1 line
2.17.1